[Solved][1.8.9] WorldSavedData not loading correctly

[ratismal]

Salutations,

 

I am trying to implement wireless redstone signals through channels (similar to mods such as ChickenBones' Wireless Redstone).

 

Objective: Make a HashMap containing a flag ID (int) and a custom class (RedstoneChannel) that contains the flag's power level and, if set, name.

 

Source (GitHub): https://github.com/Ratismal/Triggers/blob/master/src/main/java/ratismal/triggers/common/channels/ChannelRedstone.java

 

Issue: When readFromNBT is called, it iterates through the tagcompound. However, each tag is read with a value of 0.

 

Console output (world load):

[13:04:53] [server thread/INFO]: reading channels to nbt
[13:04:53] [server thread/INFO]: 0
[13:04:53] [server thread/INFO]: 0
[13:04:53] [server thread/INFO]: 0
[13:04:53] [server thread/INFO]: 0

 

Console output (world save):

[13:13:03] [server thread/INFO]: Writing channels to nbt
[13:13:03] [server thread/INFO]: 0
[13:13:03] [server thread/INFO]: 0
[13:13:03] [server thread/INFO]: 5
[13:13:03] [server thread/INFO]: 0
[13:13:03] [server thread/INFO]: test

 

Note: Console output values are outputted in order of:

    - flag

    - power

    - name (if exists)

I apologize for the ugliness, but I haven't gotten around to formatting this temporary debug message.

 

Contents of TriggersRedstoneChannels.dat:

 

From the console outputs, the correct NBT data is being written. This can be verified by looking at the TriggersRedstoneChannels.dat file, where the NBT data is stored. However, when it comes to being read, all tags are being read as simply 0 rather than their stored data.

 

I suspect it may have something to do with sides, but I don't know how to verify or fix this. Any help would be greatly appreciated.

 

Sincerely,

Ratismal

[Ernio]

@Override
    public void readFromNBT(NBTTagCompound nbt) {
        TriggersMod.logger.info("reading channels to nbt");
        redstoneChannels.clear();
        NBTTagList channels = nbt.getTagList("channels", Constants.NBT.TAG_COMPOUND);
        for (int i = 0; i < channels.tagCount(); i++) {
            NBTTagCompound miniCompound = new NBTTagCompound();  // HERE

 

You are reading NOT from list provided but making new Compounds. You should get Compounds from within list.

[ratismal]

You are reading NOT from list provided but making new Compounds. You should get Compounds from within list.

 

Thank you, I spent hours trying to debug but completely missed this.

 

That static instance field is a bad idea. Your WorldSavedData will a) exist for many worlds and b) exist for server & client. You can't just keep a static instance field.

 

I'll keep this in mind. Thanks!