Multiple Potion effect bug ??

[MrFloatingCow]

So, I'm making a mod. There is an armor that gives anyone who wears it get regeneration & other stuff, but when i tried it, the mod did start, but the regeneration didn't work and some other buffs didn't too. So, the regeneration pops up and everything, but it is not regenerating the hearts faster. When i take off the armor though, the regen works. This is my code:

 

    @Override

    public void onArmorTick(World world, EntityPlayer player, ItemStack armor) {

    if(player.getCurrentArmor(0) != null && player.getCurrentArmor(1) != null && player.getCurrentArmor(2) != null && player.getCurrentArmor(3) != null){

    ItemStack boots = player.getCurrentArmor(0);

        ItemStack legs = player.getCurrentArmor(1);

        ItemStack chest = player.getCurrentArmor(2);

        ItemStack helmet = player.getCurrentArmor(3);

       

        if(boots.getItem() == MItems.rbBoots && chest.getItem() == MItems.rbChestplate && legs.getItem() == MItems.rbPants && helmet.getItem() == MItems.rbHelmet){

        player.addPotionEffect(new PotionEffect(1, 200, 3));

        player.addPotionEffect(new PotionEffect(3, 200, 3));

        player.addPotionEffect(new PotionEffect(5, 200, 3));

        player.addPotionEffect(new PotionEffect(10, 200, 1));

        player.addPotionEffect(new PotionEffect(11, 200, 1));

        player.addPotionEffect(new PotionEffect(12, 200, 3));

        player.addPotionEffect(new PotionEffect(13, 200, 3));

        player.addPotionEffect(new PotionEffect(16, 200, 3));

        player.addPotionEffect(new PotionEffect(23, 200, 3));

        }

    }

 

If anyone understands what my problem is, please reply.

 

[MrFloatingCow]

Ok, Thanks diesieben07, but can you give me an example please ?

[MrFloatingCow]

The example of where the part where i did wrong, or just help me fix the code

[MrFloatingCow]

I mean, how could i fix it ?

Actually when i tried to export the mod, th regen is 100% faster, but i set it to regen 2 but its like regen 25 or something. Why is it like that, can you tell me HOW to fix it ?

[MrFloatingCow]

So, is it like this ?

 

        if(boots.getItem() == MItems.rbBoots && chest.getItem() == MItems.rbChestplate && legs.getItem() == MItems.rbPants && helmet.getItem() == MItems.rbHelmet){

                if(!world.isRemote){

            player.addPotionEffect(new PotionEffect(1, 400, 3));

            player.addPotionEffect(new PotionEffect(3, 400, 3));

            player.addPotionEffect(new PotionEffect(5, 400, 3));

            player.addPotionEffect(new PotionEffect(10, 400, 3));

            player.addPotionEffect(new PotionEffect(11, 400, 1));

            player.addPotionEffect(new PotionEffect(12, 400, 3));

            player.addPotionEffect(new PotionEffect(13, 400, 3));

            player.addPotionEffect(new PotionEffect(16, 400, 3));

            player.addPotionEffect(new PotionEffect(23, 400, 3));

                }

        }

    }

   

    }

 

}

 

Btw, i changed some stuff

[Draco18s]

Also do not add a new potion effect every tick.

 

This is kiiiiiind of a big deal with the regeneration effect.

 

but its like regen 25 or something

 

Because regeneration heals you when the ticks remaining % 10 == 0.  If it's always 400 ticks left, then it's always %10==0, ergo it heals every tick.

[MrFloatingCow]

How how can i fix it ? it would be helpful

[Draco18s]

By not adding a new potion effect every tick.

[MrFloatingCow]

Can you use my code & fix it please?

[Draco18s]

$25?  That's far too low.  I'm getting $35 contract right now, I wouldn't take less than $75/hr freelance.

[Draco18s]

$25?  That's far too low.  I'm getting $35 contract right now, I wouldn't take less than $75/hr freelance.

If anyone doesn't get that this is a joke... then I don't even know.

Also /me is German, so no idea about the dollars.

Roughly equal to a Euro, calling them equal is good enough for forum work.  It's really about 8 cents weak on the dollar side ($1.08 = 1€)