[1.7.10] Problem with NBT not properly saving

[Roboguy99]

My aim is to save settings for an item on a per-item basis, and so I want to save the settings to NBT. The items have inventories, and the NBT data is saved fine and its working correctly, but I cannot get the settings to save (although they stay loaded even if you exit a world and load it again, if you restart the game everything is set to 0).

 

Each of the variables is correct when writing to NBT, but no tag is actually created. Then, when it reads obviously no tag is found so the variable is set to 0.

 

The NBT reading/writing code is here (and everything below that in that class): https://github.com/Roboguy99/HotbarBag/blob/master/src/main/java/roboguy99/hotbarBag/inventory/BagInventory.java#L169

 

The class that handles the changing/saving/loading of settings to/from NBT is here: https://github.com/Roboguy99/HotbarBag/blob/master/src/main/java/roboguy99/hotbarBag/gui/GuiConfig.java

[Draco18s]

I'm sure it would help if writeSettingsToNBT and readSettingsFromNBT was actually being called somewhere.

[Roboguy99]

I'm sure it would help if writeSettingsToNBT and readSettingsFromNBT was actually being called somewhere.

 

They are...inside GuiConfig. Sorry, I probably should have specified.

 

See here: https://github.com/Roboguy99/HotbarBag/blob/master/src/main/java/roboguy99/hotbarBag/gui/GuiConfig.java#L96

And here: https://github.com/Roboguy99/HotbarBag/blob/master/src/main/java/roboguy99/hotbarBag/gui/GuiConfig.java#L205

And here: https://github.com/Roboguy99/HotbarBag/blob/master/src/main/java/roboguy99/hotbarBag/gui/GuiConfig.java#L229

 

I don't think I'm missing anything that stupid, am I?

[coolAlias]

GUIs are CLIENT-side only, so any settings you change there are lost when the client closes. You need to save settings on the server, so you will need to send packets if you want the settings to be changed from client side.

 

Also, I didn't actually look at the settings you are changing, but most settings should only be set server side anyway and usually you don't want to expose them client-side at all.

[Roboguy99]

GUIs are CLIENT-side only, so any settings you change there are lost when the client closes. You need to save settings on the server, so you will need to send packets if you want the settings to be changed from client side.

 

Also, I didn't actually look at the settings you are changing, but most settings should only be set server side anyway and usually you don't want to expose them client-side at all.

 

Ah ok, I thought that you didn't need packets with NBT. As for the settings, they're purely for client-side settings. Even if I do put any server-side values in, they won't be anything beyond the colour of an item or its name, so there's no real danger of exploits there.

[coolAlias]

ItemStack NBT data syncs only one way automatically: from server to client. So, if you make changes on the server (e.g. by sending a packet from the GUI), those changes will be visible on the client side as well.

[Roboguy99]

ItemStack NBT data syncs only one way automatically: from server to client. So, if you make changes on the server (e.g. by sending a packet from the GUI), those changes will be visible on the client side as well.

 

Ah, that makes sense. Thanks a lot.