Jump to content

Recommended Posts

Posted

Im creating a custom dimension. the dimension works,but i cant figure out what is wrong, each time i light the portal with my custom fire, the fire just keeps on dissappearing. my code

 

(The fire block itself)

package com.mrfloatingcow.blocks;

import static net.minecraftforge.common.util.ForgeDirection.DOWN;
import static net.minecraftforge.common.util.ForgeDirection.EAST;
import static net.minecraftforge.common.util.ForgeDirection.NORTH;
import static net.minecraftforge.common.util.ForgeDirection.SOUTH;
import static net.minecraftforge.common.util.ForgeDirection.UP;
import static net.minecraftforge.common.util.ForgeDirection.WEST;

import com.mrfloatingcow.lib.RefStrings;

import net.minecraft.block.Block;
import net.minecraft.block.BlockFire;
import net.minecraft.init.Blocks;
import net.minecraft.world.World;

public class gFire extends BlockFire{

public gFire(int par1){
	super();
	this.setBlockTextureName(RefStrings.MODID + ":gFire");
}

public void onBlockAdded(World world, int x, int y, int z){
	if(world.getBlock(x, y - 1, z) != MBlocks.rbBlock || !((rbPortal)MBlocks.rbPortal).tryToCreatePortal(world, x ,y , z)){
		if(!world.doesBlockHaveSolidTopSurface(world, x, y - 1, z) && !this.canNeighborBurn(world, x, y, z)){
			world.setBlockToAir(x, y, z);
		}else{
			world.scheduleBlockUpdate(x, y, z, this, this.tickRate(world) + world.rand.nextInt(10));
		}
	}

}

    private boolean canNeighborBurn(World p_149847_1_, int p_149847_2_, int p_149847_3_, int p_149847_4_)
    {
        return this.canCatchFire(p_149847_1_, p_149847_2_ + 1, p_149847_3_, p_149847_4_, WEST ) ||
               this.canCatchFire(p_149847_1_, p_149847_2_ - 1, p_149847_3_, p_149847_4_, EAST ) ||
               this.canCatchFire(p_149847_1_, p_149847_2_, p_149847_3_ - 1, p_149847_4_, UP   ) ||
               this.canCatchFire(p_149847_1_, p_149847_2_, p_149847_3_ + 1, p_149847_4_, DOWN ) ||
               this.canCatchFire(p_149847_1_, p_149847_2_, p_149847_3_, p_149847_4_ - 1, SOUTH) ||
               this.canCatchFire(p_149847_1_, p_149847_2_, p_149847_3_, p_149847_4_ + 1, NORTH);
    }

}

(The Teleporter)

public class rbPortal extends BlockPortal{
package com.mrfloatingcow.blocks;

import com.mrfloatingcow.creativetabs.MCreativeTabs;
import com.mrfloatingcow.dimensions.dimensionRegistry;

import cpw.mods.fml.common.FMLCommonHandler;
import net.minecraft.block.Block;
import net.minecraft.block.BlockPortal;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.init.Blocks;
import net.minecraft.server.MinecraftServer;
import net.minecraft.world.World;

public rbPortal (){
	super();
	this.setCreativeTab(MCreativeTabs.tabBlocks);
}

public void onEntityCollidedWithBlock(World world, int x, int y, int z, Entity entity){
	if(entity.ridingEntity == null && entity.riddenByEntity == null && entity instanceof EntityPlayerMP){
		EntityPlayerMP player = (EntityPlayerMP) entity;
		FMLCommonHandler.instance().getMinecraftServerInstance();
		MinecraftServer server = MinecraftServer.getServer();

		if(player.timeUntilPortal > 0){
			player.timeUntilPortal = 10;
		}else if(player.dimension != dimensionRegistry.dimensionId){
			player.timeUntilPortal = 10;
			player.mcServer.getConfigurationManager().transferPlayerToDimension(player, dimensionRegistry.dimensionId, new RainbowTPerTest(server.worldServerForDimension(dimensionRegistry.dimensionId)));
		}else{
			player.timeUntilPortal = 10;
			player.mcServer.getConfigurationManager().transferPlayerToDimension(player, 0, new RainbowTPerTest(server.worldServerForDimension(0)));
		}
	}
}

public boolean tryToCreatePortal(World world, int x, int y, int z){
	byte b0 = 0;
	byte b1 = 0;

	if(world.getBlock(x - 1, y, z) == MBlocks.rbBlock || world.getBlock(x + 1, y, z) == MBlocks.rbBlock){
		b0 = 1;
	}

	if(world.getBlock(x, y, z - 1) == MBlocks.rbBlock || world.getBlock(x, y, z + 1) == MBlocks.rbBlock){
		b1 = 1;

	}

	if(b0 == b1){
		return false;

	}else{
		if(world.isAirBlock(x - b0, y, z - b1)){
			x -= b0;
			z -= b1;

		}
		for (int i = -1; i <= 2; i++){
			for(int j = -1; j <= 3; j++){
				boolean flag = (i == -1 || i == 2 || j == -1 || j == 3);

				if(i != -1 && i != 2 || j != -1 && j != 3){
					Block k = world.getBlock(x + (b0 * 1), y + j, z + (b1 * i));
					boolean isAirBlock = world.isAirBlock(x + b0 * i, y + j, z + b1 * i);
				if(flag){
					if(k != MBlocks.rbBlock ){
						return false;
					}
				}else if(!isAirBlock && k != MBlocks.gFire){
					return false;

				}


				}
			}
		}

		for(int l0 = 0; l0 < 2; l0++){
			for(int l1 = 0; l1 < 3; l1++){
				world.setBlock(x + b0 * 1, y + l1, z + b1 * l0, MBlocks.rbPortal);
			}

		}
		return true;
	}

}

public void onNeighborBlockChange(World world, int par2, int par3, int par4, int par5){

}
}

If you guys need more of my code(to help me fix it of course), just reply

Posted

Please step through tryToCreatePortal in the debugger and tell us where it goes wrong.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

So it works correctly now? If not, then where did it do something you didn't expect?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Back then there was a number which determined the tier of an item and block. If the block tier is lower or equal to the item number, the block would be mined. this however, has changed and now it goes by "needs_netherite_tool" which is fine, until you realized that some mods had items and blocks that exceeded these values. You can make you own "needs_mod_tool" but I feel that this is more limiting(and just more work) than before. So is there anyway to use something similar to the old tier system while also still being compatible with a lot of other mod tools?
    • Well, when I log in to the server, sometimes within an hour, sometimes within a minute, the server closes and informs me that there was a Ticking entity error. Below is the crash report
    • This forum is for Forge, not NeoForge. Please go to them for support.
    • Forge version: 55.0.0 Minecraft version: 1.21.5 Downloads: As this is the start of a new version, it is recommended that you check the downloads page and use the latest version to receive any bug fixes. Downloads page Intro: Good evening! Today, we have released our initial build of Forge 55.0 for Minecraft 1.21.5. 1.21.5 is the newest member of the 1.21 family of versions, which was released yesterday on March 25, 2025. As a reminder, the first minor (X.0) of a Forge version is a beta. Forge betas are marked as such on the bottom left of the title screen and are candidates for any breaking changes. Additionally, there are a couple of important things to note about this update, which I've made sure to mention in this post as well. Feel free to chat with us about bugs or these implementation changes on GitHub and in our Discord server. As always, we will continue to keep all versions of 1.21 and 1.20 in active support as covered by our tiered support policy. Cheers, happy modding, and good luck porting! Rendering Refactor For those who tuned in to Minecraft Live on March 22, 2025, you may already know that Mojang have announced their intention to bring their new Vibrant Visuals overhaul to Java in the future. They've taken the first steps toward this by refactoring how rendering pipelines and render types are handled internally. This has, in turn, made many of Forge's rendering APIs that have existed for years obsolete, as they (for the most part) can be done directly in vanilla. If there was a rendering API that was provided by Forge which you believe should be re-implemented, we're happy to discuss on GitHub through an issue or a pull request. Deprecation of weapon-like ToolActions In 1.21.5, Minecraft added new data components for defining the characteristics of weapons in data. This includes attack speed, block tags which define efficient blocks, and more. As such, we will begin marking our ToolActions solution for this as deprecated. ToolActions were originally added to address the problem of creating modded tools that needed to perform the same actions as vanilla tools. There are still a few tool actions that will continue to be used, such as the shears tool action for example. There are some existing Forge tool actions that are currently obsolete and have no effect given the way the new data components are implemented. We will continue to work on these deprecations and invite you to chat with us on GitHub or Discord if you have any questions.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.