[1.8] Custom Item Inventory, don't save the Items. (SOLVED)

YoungErtu · February 8, 2016

I have the problem that my Item Inventory don't save the Items that i drag in or shift click, after re-opening the gui they are not saved.

but when i use this method in right clicking the item while sneaking:

new InventoryKeyring(player.getHeldItem()).setInventorySlotContents(0, new ItemStack(Items.diamond, 4));

it saves the diamonds, but when i take the diamond and re open the gui the diamond is still there.

Seems for me like a Client/Server Problem, how can i fix that?

or maybe a problem at the method when clicking on a slot to put a item or take a item

My files:

Container

Reveal hidden contents

package youngertu.fairytail.inventory;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import scala.tools.nsc.backend.icode.BBFlags;
import youngertu.fairytail.items.ItemKeyRing;

public class ContainerKeyring extends Container
{
private ItemStack bookStack;

/** The Item Inventory for this Container */
private final InventoryKeyring inventory;

private static final int
ARMOR_START = InventoryKeyring.INV_SIZE, // INV_SIZE = 10, so slots 0 to 9 are the custom inventory, armor starts at the next slot (i.e. 10)
ARMOR_END = ARMOR_START+3, // 4 slots total, e.g. 10-13 (10, 11, 12, 13)
INV_START = ARMOR_END+1, // start at next slot after armor, e.g. 14
INV_END = INV_START+26, // 27 vanilla inventory slots total (i.e. the first one plus 26 more)
HOTBAR_START = INV_END+1, // start at next slot after inventory
HOTBAR_END = HOTBAR_START+8; // 9 slots total (i.e. the first one plus 8 more)

public ContainerKeyring(EntityPlayer player, InventoryPlayer inv, InventoryKeyring bag)
{
	int i = 0;
	inventory = bag;

	// CUSTOM INVENTORY SLOTS
	for (i = 0; i < InventoryKeyring.INV_SIZE; ++i) {
		addSlotToContainer(new SlotKeyring(inventory, i, 80 + (18*(i%5)), 8 + (18 * (int)(i/5))));
	}

	// PLAYER INVENTORY - uses default locations for standard inventory texture file
	for (i = 0; i < 3; ++i) {
		for (int j = 0; j < 9; ++j) {
			addSlotToContainer(new Slot(inv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
		}
	}

	// PLAYER ACTION BAR - uses default locations for standard action bar texture file
	for (i = 0; i < 9; ++i) {
		addSlotToContainer(new Slot(inv, i, 8 + i * 18, 142));
	}
}

@Override
public boolean canInteractWith(EntityPlayer player) {
	return inventory.isUseableByPlayer(player);
}

@Override
public ItemStack transferStackInSlot(EntityPlayer player, int index)
{
	ItemStack itemstack = null;
	Slot slot = (Slot) this.inventorySlots.get(index);

	if (slot != null && slot.getHasStack())
	{
		ItemStack itemstack1 = slot.getStack();
		itemstack = itemstack1.copy();

		// If item is in our custom Inventory or an ARMOR slot
		if (index < INV_START)
		{
			if (!this.mergeItemStack(itemstack1, INV_START, HOTBAR_END+1, true))
			{
				return null;
			}

			slot.onSlotChange(itemstack1, itemstack);
		}

		else
		{

			if (itemstack1.getItem() instanceof ItemArmor)
			{
				int type = ((ItemArmor) itemstack1.getItem()).armorType;
				if (!this.mergeItemStack(itemstack1, ARMOR_START + type, ARMOR_START + type + 1, false))
				{
					return null;
				}
			}


			else if (index >= INV_START)
			{

				if (!this.mergeItemStack(itemstack1, 0, ARMOR_START, false))
				{
					return null;
				}
			}
		}

		if (itemstack1.stackSize == 0) {
			slot.putStack((ItemStack) null);
		} else {
			slot.onSlotChanged();
		}

		if (itemstack1.stackSize == itemstack.stackSize) {
			return null;
		}

		slot.onPickupFromSlot(player, itemstack1);
	}

	return itemstack;
}

@Override
public ItemStack slotClick(int slot, int button, int flag, EntityPlayer player) {
	if (slot >= 0 && getSlot(slot) != null && getSlot(slot).getStack() == player.getHeldItem()) {
		return null;
	}
	return super.slotClick(slot, button, flag, player);
}

/**
 * Vanilla method fails to account for stack size limits of one, resulting in only one
 * item getting placed in the slot and the rest disappearing into thin air; vanilla
 * method also fails to check whether stack is valid for slot
 */
@Override
protected boolean mergeItemStack(ItemStack stack, int start, int end, boolean backwards)
{
	boolean flag1 = false;
	int k = (backwards ? end - 1 : start);
	Slot slot;
	ItemStack itemstack1;

	if (stack.isStackable())
	{
		while (stack.stackSize > 0 && (!backwards && k < end || backwards && k >= start))
		{
			slot = (Slot) inventorySlots.get(k);
			itemstack1 = slot.getStack();

			if (!slot.isItemValid(stack)) {
				k += (backwards ? -1 : 1);
				continue;
			}

			if (itemstack1 != null && itemstack1.getItem() == stack.getItem() &&
					(!stack.getHasSubtypes() || stack.getItemDamage() == itemstack1.getItemDamage()) &&
					ItemStack.areItemStackTagsEqual(stack, itemstack1))
			{
				int l = itemstack1.stackSize + stack.stackSize;

				if (l <= stack.getMaxStackSize() && l <= slot.getSlotStackLimit()) {
					stack.stackSize = 0;
					itemstack1.stackSize = l;
					inventory.markDirty();
					flag1 = true;
				} else if (itemstack1.stackSize < stack.getMaxStackSize() && l < slot.getSlotStackLimit()) {
					stack.stackSize -= stack.getMaxStackSize() - itemstack1.stackSize;
					itemstack1.stackSize = stack.getMaxStackSize();
					inventory.markDirty();
					flag1 = true;
				}
			}

			k += (backwards ? -1 : 1);
		}
	}

	if (stack.stackSize > 0)
	{
		k = (backwards ? end - 1 : start);

		while (!backwards && k < end || backwards && k >= start) {
			slot = (Slot) inventorySlots.get(k);
			itemstack1 = slot.getStack();

			if (!slot.isItemValid(stack)) {
				k += (backwards ? -1 : 1);
				continue;
			}

			if (itemstack1 == null) {
				int l = stack.stackSize;

				if (l <= slot.getSlotStackLimit()) {
					slot.putStack(stack.copy());
					stack.stackSize = 0;
					inventory.markDirty();
					flag1 = true;
					break;
				} else {
					putStackInSlot(k, new ItemStack(stack.getItem(), slot.getSlotStackLimit(), stack.getItemDamage()));
					stack.stackSize -= slot.getSlotStackLimit();
					inventory.markDirty();
					flag1 = true;
				}
			}

			k += (backwards ? -1 : 1);
		}
	}

	return flag1;
}

}

Inventory:

Reveal hidden contents

package youngertu.fairytail.inventory;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import youngertu.fairytail.items.keys.KeyBase;

public class InventoryKeyring extends AbstractInventory
{
private String name = "Key Ring";

/** The key used to store and retrieve the inventory from NBT */
private static final String SAVE_KEY = "InventoryKeyring";

/** Defining your inventory size this way is handy */
public static final int INV_SIZE = 18;

/** Provides NBT Tag Compound to reference */
private final ItemStack invStack;

public InventoryKeyring(ItemStack stack) {
	inventory = new ItemStack[iNV_SIZE];
	this.invStack = stack;
	if (!invStack.hasTagCompound()) {
		invStack.setTagCompound(new NBTTagCompound());
	}
	readFromNBT(invStack.getTagCompound());
}

@Override
public String getName() {
	return name;
}

@Override
public boolean hasCustomName() {
	return name.length() > 0;
}

@Override
public int getInventoryStackLimit() {
	return 1;
}

/**
 * For inventories stored in ItemStacks, it is critical to implement this method
 * in order to write the inventory to the ItemStack's NBT whenever it changes.
 */
@Override
public void markDirty() {
	for (int i = 0; i < getSizeInventory(); ++i) {
		if (getStackInSlot(i) != null && getStackInSlot(i).stackSize == 0)
			inventory[i] = null;
	}
	writeToNBT(invStack.getTagCompound());
}

@Override
public boolean isUseableByPlayer(EntityPlayer player) {
	return true;
}

@Override
public boolean isItemValidForSlot(int slot, ItemStack stack) {
	return (stack.getItem() instanceof KeyBase);
}

@Override
protected String getNbtKey() {
	return SAVE_KEY;
}
}

GuiHandler

Reveal hidden contents

public class GuiHandler implements IGuiHandler
{
@Override
public Object getServerGuiElement(int guiId, EntityPlayer player, World world, int x, int y, int z) {
	switch(guiId) {

	case FairyTail.GUI_KEYRING_INV: return new ContainerKeyring(player, player.inventory, new InventoryKeyring(player.getHeldItem())); 
	default: return null;
	}

	/*if (guiId == FairyTail.GUI_KEYRING_INV)  {
		System.out.println("RETURNED KEYRING INV");
		return new ContainerKeyring(player, player.inventory, new InventoryKeyring(player.getHeldItem()));
	} else {
		return null;
	}*/
}

@Override
public Object getClientGuiElement(int guiId, EntityPlayer player, World world, int x, int y, int z) {
	switch(guiId) {
	case FairyTail.GUI_KEYRING_INV: return new GuiKeyring(player, player.inventory, new InventoryKeyring(player.getHeldItem()));
	default: return null;
	}
	/*if (guiId == FairyTail.GUI_KEYRING_INV)  {
		return new GuiKeyring(player, player.inventory, new InventoryKeyring(player.getHeldItem()));
	} else {
		return null;
	}*/
}

}

Failender · February 8, 2016

Well you are never saving your data to the itemstacks'nbt.

override onContainerClosed and save your inventory to the itemstacks nbt there

YoungErtu · February 8, 2016

On 2/8/2016 at 3:05 AM, Failender said:

Well you are never saving your data to the itemstacks'nbt.

override onContainerClosed and save your inventory to the itemstacks nbt there

it is saving, because when i open it again there is a diamond. but im not able to add or take something.

Failender · February 8, 2016

I think the diamond is there because you are adding it everytime you create a new inventory..?

new InventoryKeyring(player.getHeldItem()).setInventorySlotContents(0, new ItemStack(Items.diamond, 4));

YoungErtu · February 8, 2016

On 2/8/2016 at 3:13 AM, Failender said:
I think the diamond is there because you are adding it everytime you create a new inventory..?
new InventoryKeyring(player.getHeldItem()).setInventorySlotContents(0, new ItemStack(Items.diamond, 4));

thats possible, i'll try out what you said before.

YoungErtu · February 8, 2016

On 2/8/2016 at 3:05 AM, Failender said:

Well you are never saving your data to the itemstacks'nbt.

override onContainerClosed and save your inventory to the itemstacks nbt there

but then you didn't saw this:

/**
 * For inventories stored in ItemStacks, it is critical to implement this method
 * in order to write the inventory to the ItemStack's NBT whenever it changes.
 */
@Override
public void markDirty() {
	for (int i = 0; i < getSizeInventory(); ++i) {
		if (getStackInSlot(i) != null && getStackInSlot(i).stackSize == 0)
			inventory[i] = null;
	}
	writeToNBT(invStack.getTagCompound());
}

there is a other reason i think, but why?

EDIT: When i try to shift-click the Diamond the game crashes.

EDIT 2: this method is only for TileEntities i'll try to writeNBTTag and readNBTTag

Draco18s · February 8, 2016

1) That is not what Mark Dirty is supposed to be doing.

2) That function utterly deletes the entire contained inventory. Good jorb.

3) Never, ever, EVER call

writeToNBT

yourself.

YoungErtu · February 9, 2016

On 2/8/2016 at 11:40 PM, Draco18s said:
1) That is not what Mark Dirty is supposed to be doing.

2) That function utterly deletes the entire contained inventory. Good jorb.

3) Never, ever, EVER call
writeToNBT
yourself.

I just followed the Tutorial of coolAlias seems that this doesn't work for 1.8 or im not able to get it to work.

I think i'll start the tutorial from begining.

YoungErtu · February 9, 2016

I posted this under the topic of coolAlias Tutorial and here are the problems that i detected:

Changed everything but still no difference, the Item Inventory is still not saved. Also when I try to set Items to the Inventory in the Item Right-Click Method it is saving the Item but when i take the item and open the inventory again it is still there.

here my 2 classes inventory and container:

Container

Reveal hidden contents

package youngertu.fairytail.inventory;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import youngertu.fairytail.items.keys.KeyBase;

public class ContainerKeyRing extends Container
{
/** The Item Inventory for this Container */
private final InventoryKeyRing inventory;

private static final int
ARMOR_START = InventoryKeyRing.INV_SIZE, // INV_SIZE = 10, so slots 0 to 9 are the custom inventory, armor starts at the next slot (i.e. 10)
ARMOR_END = ARMOR_START+3, // 4 slots total, e.g. 10-13 (10, 11, 12, 13)
INV_START = ARMOR_END+1, // start at next slot after armor, e.g. 14
INV_END = INV_START+26, // 27 vanilla inventory slots total (i.e. the first one plus 26 more)
HOTBAR_START = INV_END+1, // start at next slot after inventory
HOTBAR_END = HOTBAR_START+8; // 9 slots total (i.e. the first one plus 8 more)

public ContainerKeyRing(EntityPlayer player, InventoryPlayer inv, InventoryKeyRing bag)
{
	int i = 0;
	inventory = bag;

	// CUSTOM INVENTORY SLOTS
	for (i = 0; i < InventoryKeyRing.INV_SIZE; ++i) {
		addSlotToContainer(new SlotKeyRing(inventory, i, 80 + (18*(i%5)), 8 + (18 * (int)(i/5))));
	}

	// PLAYER INVENTORY - uses default locations for standard inventory texture file
	for (i = 0; i < 3; ++i) {
		for (int j = 0; j < 9; ++j) {
			addSlotToContainer(new Slot(inv, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
		}
	}

	// PLAYER ACTION BAR - uses default locations for standard action bar texture file
	for (i = 0; i < 9; ++i) {
		addSlotToContainer(new Slot(inv, i, 8 + i * 18, 142));
	}
}

@Override
public boolean canInteractWith(EntityPlayer player) {
	return inventory.isUseableByPlayer(player);
}


@Override
public ItemStack transferStackInSlot (EntityPlayer player, int par2) {
	ItemStack itemstack = null;
	Slot slot = this.inventorySlots.get(par2);

	if (slot != null && slot.getHasStack()) {
		ItemStack itemstack1 = slot.getStack();
		itemstack = itemstack1.copy();

		if (par2 < INV_START) {
			if (!mergeItemStack(itemstack1, INV_START, HOTBAR_END + 1, true)) return null;

			slot.onSlotChange(itemstack1, itemstack);
		} else if (itemstack1.getItem() instanceof KeyBase) {
			if (!mergeItemStack(itemstack1, 0, InventoryKeyRing.INV_SIZE, false)) return null;
		} else if (par2 >= INV_START && par2 < HOTBAR_START) {
			if (!mergeItemStack(itemstack1, HOTBAR_START, HOTBAR_START + 1, false)) return null;
		} else if (par2 >= HOTBAR_START && par2 < HOTBAR_END + 1) if (!mergeItemStack(itemstack1, INV_START, INV_END + 1, false)) return null;

		if (itemstack1.stackSize == 0)
			slot.putStack((ItemStack) null);
		else
			slot.onSlotChanged();

		if (itemstack1.stackSize == itemstack.stackSize) return null;

		slot.onPickupFromSlot(player, itemstack1);
	}

	return itemstack;
}

@Override
public ItemStack slotClick(int slot, int button, int flag, EntityPlayer player) {
	if (slot >= 0 && getSlot(slot) != null && getSlot(slot).getStack() == player.getHeldItem()) {
		return null;
	}
	return super.slotClick(slot, button, flag, player);
}

@Override
protected boolean mergeItemStack (ItemStack stack, int start, int end, boolean backwards) {
	boolean flag1 = false;
	int k = (backwards ? end - 1 : start);
	Slot slot;
	ItemStack itemstack1;

	if (stack.isStackable()) while (stack.stackSize > 0 && (!backwards && k < end || backwards && k >= start)) {
		slot = inventorySlots.get(k);
		itemstack1 = slot.getStack();

		if (!slot.isItemValid(stack)) {
			k += (backwards ? -1 : 1);
			continue;
		}

		if (itemstack1 != null && itemstack1.getItem() == stack.getItem() && (!stack.getHasSubtypes() || stack.getItemDamage() == itemstack1.getItemDamage()) && ItemStack.areItemStackTagsEqual(stack, itemstack1)) {
			int l = itemstack1.stackSize + stack.stackSize;

			if (l <= stack.getMaxStackSize() && l <= slot.getSlotStackLimit()) {
				stack.stackSize = 0;
				itemstack1.stackSize = l;
				inventory.markDirty();
				flag1 = true;
			} else if (itemstack1.stackSize < stack.getMaxStackSize() && l < slot.getSlotStackLimit()) {
				stack.stackSize -= stack.getMaxStackSize() - itemstack1.stackSize;
				itemstack1.stackSize = stack.getMaxStackSize();
				inventory.markDirty();
				flag1 = true;
			}
		}

		k += (backwards ? -1 : 1);
	}

	if (stack.stackSize > 0) {
		k = (backwards ? end - 1 : start);

		while (!backwards && k < end || backwards && k >= start) {
			slot = inventorySlots.get(k);
			itemstack1 = slot.getStack();

			if (!slot.isItemValid(stack)) {
				k += (backwards ? -1 : 1);
				continue;
			}

			if (itemstack1 == null) {
				int l = stack.stackSize;

				if (l <= slot.getSlotStackLimit()) {
					slot.putStack(stack.copy());
					stack.stackSize = 0;
					inventory.markDirty();
					flag1 = true;
					break;
				} else {
					putStackInSlot(k, new ItemStack(stack.getItem(), slot.getSlotStackLimit(), stack.getItemDamage()));
					stack.stackSize -= slot.getSlotStackLimit();
					inventory.markDirty();
					flag1 = true;
				}
			}

			k += (backwards ? -1 : 1);
		}
	}

	return flag1;
}
}

Inventory

Reveal hidden contents

package youngertu.fairytail.inventory;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import youngertu.fairytail.items.keys.KeyBase;

public class InventoryKeyRing extends AbstractInventory
{
private String name = "Key Ring";

/** The key used to store and retrieve the inventory from NBT */
private static final String SAVE_KEY = "KeyRingInventory";

/** Defining your inventory size this way is handy */
public static final int INV_SIZE = 18;

/** Provides NBT Tag Compound to reference */
private final ItemStack invStack;

public InventoryKeyRing(ItemStack stack) {
inventory = new ItemStack[iNV_SIZE];
this.invStack = stack;
if (!invStack.hasTagCompound()) {
invStack.setTagCompound(new NBTTagCompound());
}
readFromNBT(invStack.getTagCompound());
}

@Override
public String getName() {
return name;
}

@Override
public boolean hasCustomName() {
return name.length() > 0;
}

@Override
public int getInventoryStackLimit() {
return 1;
}

/**
* For inventories stored in ItemStacks, it is critical to implement this method
* in order to write the inventory to the ItemStack's NBT whenever it changes.
*/
@Override
public void markDirty()
{
for (int i = 0; i < getSizeInventory(); ++i)
{
if (getStackInSlot(i) != null && getStackInSlot(i).stackSize == 0)
{
setInventorySlotContents(i, null);
}
}
writeToNBT(invStack.getTagCompound());
}

@Override
public boolean isUseableByPlayer(EntityPlayer player) {
return true;
}

@Override
public boolean isItemValidForSlot(int slot, ItemStack stack) {
return stack.getItem() instanceof KeyBase;
}

@Override
protected String getNbtKey() {
return SAVE_KEY;
}

public void copy (AbstractInventory inv) {
for (int i = 0; i < inv.getSizeInventory(); ++i) {
ItemStack stack = inv.getStackInSlot(i);
inventory = (stack == null ? null : stack.copy());
}
markDirty();
}

@Override
public ItemStack removeStackFromSlot(int slot) {
ItemStack stack = getStackInSlot(slot);
setInventorySlotContents(slot, null);
return stack;
}
}

thanks for your help coolAlias, maybe i understanded something wrong and this is the reason for not saving the items.

EDIT: I added some debug lines and everything works fine, the NBTWriting is successful, but instead of readingNBT when opening the Inventory it writes to NBT, why?

EDIT 2: Fixed ReadingNBT by putting into openInventory but it still writesNBT after opening the Inventory and reading the NBT and this several times 10 times i think.

EDIT 3: writeNBT is called on Client Side when opening the inventory, but Server Side when putting Item in Slot. Reading NBT is only called on Server Side.

When opening the Inventory the writeNBT method is called by markDirty, and how i said before on client side, there is something wrong but i couldn't find it.

EDIT 4: I outcommented the method markDirty to put my Code into onContainerClosed but it doesn't want to work.

Draco18s · February 9, 2016

I still do not understand that mark dirty function.

CoolAlias might have to hop in and help you, because from here it looks like that method is erasing the inventory contents, not saving them.

Similarly, it isn't calling super().

YoungErtu · February 9, 2016

On 2/9/2016 at 9:42 PM, Draco18s said:

I still do not understand that mark dirty function.

CoolAlias might have to hop in and help you, because from here it looks like that method is erasing the inventory contents, not saving them.

Similarly, it isn't calling super().

I looked into a Open Source Mod and it seems that this markDirty method is wrong, he uses onContainerClosed i'll try the same, im currently working on that.

YoungErtu · February 9, 2016

Fixed that by adding this into the Container:

@Override
public void onContainerClosed(EntityPlayer player){
	World world = player.worldObj;

	if (!world.isRemote){
		ItemStack stack = player.getCurrentEquippedItem();
		inventory.writeToNBT(stack.getTagCompound());
	}

	super.onContainerClosed(player);
}

YoungErtu · February 9, 2016

On 2/8/2016 at 3:05 AM, Failender said:

Well you are never saving your data to the itemstacks'nbt.

override onContainerClosed and save your inventory to the itemstacks nbt there

At the end you were right, sorry and thanks ^^

Sign In

[1.8] Custom Item Inventory, don't save the Items. (SOLVED)

Recommended Posts

YoungErtu

Failender

YoungErtu

Failender

YoungErtu

YoungErtu

Draco18s

YoungErtu

YoungErtu

Draco18s

YoungErtu

YoungErtu

YoungErtu

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information