[1.8.9] Crop doesnt work correctly

[SantacreeperLP]

Hey, my custom crop which should grow 2 blocks tall isnt working properly... Can you help me?

It should grow 2 blocks tall but it does nothing after finishing the final state on the first block...

 

Im looking forward to nice persons that can help me

Thank you very much and have a great day,

 

package com.beastle9end.legendconstruction.blocks;

/**
* Created by Le9enD on 10.02.2016.
*/

import java.util.ArrayList;
import java.util.Random;

import com.beastle9end.legendconstruction.LegendConstruction;
import com.sun.javafx.charts.Legend;
import net.minecraft.block.Block;
import net.minecraft.block.BlockAir;
import net.minecraft.block.BlockBush;
import net.minecraft.block.BlockCrops;
import net.minecraft.block.BlockFarmland;
import net.minecraft.block.IGrowable;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.EnumPlantType;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraft.block.BlockPotato;
public class BlockCropAbsorbation extends BlockCrops implements IGrowable{
    public BlockCropAbsorbation(String unlocalName)
    {
        this.setUnlocalizedName(unlocalName);
        this.setHardness(0.0f);
        this.setResistance(0.0f);
        this.setTickRandomly(true);
        this.setBlockBounds(0.0f, 0.0f, 0.0f, 1.0f, 0.25f, 0.0f);
        this.setCreativeTab(LegendConstruction.tabLegendEngineering);
        //this.setCreativeTab((CreativeTabs) null);
        this.setStepSound(soundTypeGrass);
        this.disableStats();
        GameRegistry.registerBlock(this, "cropAbsorbation");
    }

    @Override
    public void setBlockBoundsBasedOnState(IBlockAccess world, BlockPos pos)
    {
        IBlockState state =  world.getBlockState(pos);
        int l = ((Integer)((IBlockState) state).getValue(AGE)).intValue();
        if (l <= 2) {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 0.25F, 1.0F);
        } else if (l <= 4) {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 0.5F, 1.0F);
        } else if (l <= 6) {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 0.75F, 1.0F);
        } else {
            this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
        }
    }

    @Override
    public void onBlockHarvested(World world, BlockPos pos, IBlockState state, EntityPlayer player)
    {
        if(world.getBlockState(pos).getBlock() instanceof BlockCropAbsorbation)
        {
            if(world.getBlockState(pos).getValue(AGE).intValue() == 
            {
                world.setBlockState(new BlockPos(pos.getX(), pos.getY() -1 , pos.getZ()), (IBlockState) AGE, 5);
            }
        }
    }

    public void fertilize(World world, BlockPos pos)
    {
        int meta = world.getBlockState(pos).getValue(AGE).intValue();
        if(world.getBlockState(pos).getBlock() instanceof BlockAir)
        {
            if(meta < 5)
            {
                world.setBlockState(new BlockPos(pos.getX(), pos.getY()-1, pos.getZ()), (IBlockState) AGE, 7);
                world.setBlockState(new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), LegendConstruction.cropAbsorbation.getDefaultState());
                return;
            }
            return;
        }
        else
        {
            if(meta < 5)
            {
                world.setBlockState(pos, (IBlockState) AGE, 5);
            }
        }
    }

    @Override
    protected Item getSeed()
    {
        return LegendConstruction.absorbationSeeds;
    }

    @Override
    protected Item getCrop()
    {
        return Items.string;
    }

    @Override
    public int getRenderType() {

        return 6;
    }

    @Override
    protected boolean canPlaceBlockOn(Block block) {

        return block == Blocks.farmland;
    }

    @Override
    public void updateTick(World world,BlockPos pos, IBlockState state, Random random)
    {
        super.updateTick(world, pos, state, random);
        if(world.getBlockState(pos).getBlock().getLightValue() >= 9)
        {
            int meta = world.getBlockState(pos).getValue(AGE).intValue();
            int x = pos.getX(), y = pos.getY(), z = pos.getZ();
            if ((meta == 4) || (meta == 5)) {
                return;
            }
            if ((world.getBlockState(pos).getBlock() != Blocks.farmland) || (world.getBlockState(pos).getBlock() == LegendConstruction.cropAbsorbation)
                    || (!(world.getBlockState(new BlockPos(pos.getX(), pos.getY()+1, pos.getZ())).getBlock() == Blocks.air)))
            {
                return;
            }
            if (random.nextInt(30) == 0) {
                world.setBlockState(pos, (IBlockState) AGE, meta + 1);
            }
            if ((meta > 6) && (world.getBlockState(getPos(x,y-1,z)) == Blocks.farmland) && (world.getBlockState(getPos(x, y + 1, z)) == Blocks.air)) {
                if (meta == 7) {
                    world.setBlockState(getPos(x,y+1,z), LegendConstruction.cropAbsorbation.getDefaultState());
                }
                world.setBlockState(pos, (IBlockState) AGE, 7);
            }
        }


    }

    @Override
    public void dropBlockAsItemWithChance(World world, BlockPos pos, IBlockState state, float chance, int fortune)
    {
        super.dropBlockAsItemWithChance(world, pos, state, chance, 0);
    }

    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return ((Integer)state.getValue(AGE)).intValue() == 8 ? this.getCrop() : this.getSeed();
    }

    @Override
    public int quantityDropped(Random random) {

        return random.nextInt(2);
    }

    @Override
    public boolean canGrow(World worldIn, BlockPos pos, IBlockState state, boolean isClient)
    {
        return ((Integer)state.getValue(AGE)).intValue() != 7;
    }

    @Override
    public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, IBlockState state)
    {
        return true;
    }

    @Override
    @SideOnly(Side.CLIENT)
    public Item getItem(World worldIn, BlockPos pos)
    {
        return this.getSeed();
    }

    @Override
    public java.util.List<ItemStack> getDrops(net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune)
    {
        ArrayList<ItemStack> ret = (ArrayList<ItemStack>) super.getDrops(world, pos, state, fortune);
        int metadata = this.getMetaFromState(state);
        Random rand = world instanceof World ? ((World)world).rand : new Random();
        if (metadata >=  {
            for (int i = 0; i < 3 + fortune; ++i) {
                if (rand.nextInt(15) <= metadata) {
                    ret.add(new ItemStack(this.getCrop(), 1, 0));
                }
            }
        }
        return ret;

    }

    @Override
    public boolean canPlaceBlockAt(World world, BlockPos pos) {
        return true;
    }

    @Override
    protected void checkAndDropBlock(World world, BlockPos pos, IBlockState state) {

        if (!this.canBlockStay(world, pos, state)) {
            int l = this.getMetaFromState(state);
            this.dropBlockAsItem(world, pos, state, 0);
            world.setBlockState(pos, Blocks.air.getDefaultState());
        }
    }
    @Override
    public boolean canBlockStay(World world, BlockPos pos, IBlockState state)
    {
        if (world.getBlockState(pos).getBlock() != this) return super.canBlockStay(world, pos, state);
        return (world.getBlockState(getPos(pos.getX(), pos.getY()- 1, pos.getZ())).getBlock() instanceof BlockFarmland) || (world.getBlockState(getPos(pos.getX(), pos.getY()- 1, pos.getZ())).getBlock() instanceof BlockCropAbsorbation);
    }

    public BlockPos getPos(int x, int y, int z)
    {
        return new BlockPos(x,y,z);
    }

}

[jabelar]

Well, you need to just do standard debug process. The addition of the next block happens in your updateTick() method so you just need to trace through and see why the condition to place the block isn't happening as expected. I usually trace things using console or logger output, where I put a line to indicate that each code path is executing and also output any key values. Like before you check if the next block should be placed, I would put a System.out.println() statement that outputs the values for meta as well as confirmation that there is farmland below and air above (i.e. the condition you are checking). It should be quickly obvious why the condition isn't being met if you trace it like this.

 

You can also use debug mode and breakpoints in your IDE to do similar sort of tracing of code execution.

[Draco18s]

pos.up(), btw, is much more efficient than new BlockPos(pos.getX(), pos.getY()+1, pos.getZ()

[jeffryfisher]

When you place your crop on top of another crop, it is not on farmland. How do you handle that?

[jabelar]

When you place your crop on top of another crop, it is not on farmland. How do you handle that?

 

You're right that is likely an issue. The canPlaceBlockOn() method he has is:

 

    @Override

    protected boolean canPlaceBlockOn(Block block) {

 

        return block == Blocks.farmland;

    }

 

Instead you need to check for both the case of farmland below, or same crop below with farmland below that.