[1.8.9] [Forge 1722] Custom ore not generating

[blahblahbal]

I've run into another problem, this time with my custom ore. It's not generating, but I don't get any errors in the log.

 

Here's the repo on GitHub:  https://github.com/blahblahbal/Blah-s-Minecraft-Mod

 

I've tried everything I can think of, but nothing works. Some things I tried made it worse.

 

Fortunately, I've fixed the first two problems I ran into (missing textures, no such field 'tadaniteOre').

[Draco18s]

0) use github

1) yoir json is malformed

[blahblahbal]

Well... the json is in the exact same format as the other jsons for my blocks. In fact, I copy-pasted the first one and edited it to match for Tadanite Ore. So why isn't it throwing an error on the other two? Hmm....

 

EDIT: What... I redid the copy-paste... now it's not giving me ANY errors in the log...

 

Also I should probably edit the first post to say I'm using Forge 1722 and MC 1.8.9.

[Major Squirrel]

Well... the json is in the exact same format as the other jsons for my blocks. In fact, I copy-pasted the first one and edited it to match for Tadanite Ore. So why isn't it throwing an error on the other two? Hmm....

 

EDIT: What... I redid the copy-paste... now it's not giving me ANY errors in the log...

 

Also I should probably edit the first post to say I'm using Forge 1722 and MC 1.8.9.

 

Hi blahblahbal,

 

Using sublimetext, it gives me this :

 

 

I'm not sure it was encoded well, try to write it by yourself and make a test again !

[blahblahbal]

Yeah, I fixed that... It now gives me no errors, but still doesn't show the textures. I'm convinced it must be something in the code, not the jsons. I just don't know where it is.

[blahblahbal]

Hate to double-post, but I'm not sure if the forum software updates alerts/whatever if you edit and quote.

 

0) use github

1) yoir json is malformed

 

Uploaded to github, https://github.com/blahblahbal/Blah-s-Minecraft-Mod

[jeffryfisher]

...still doesn't show the textures. I'm convinced it must be something in the code, not the jsons.

Don't forgive your jsons just because you fixed one error in one of them. There are others to create headaches as well. And then there are their file names and directory structure... The code is the tail wagging the dog (while the json paradigm is a dog with fleas).

 

However, it may be worth the trouble of checking code for exact spelling and capitalization. Remember to keep reading your log.

 

Sadly the json paradigm is both fragile and (to Eclipse) opaque. Tools like JSONlint can check json syntax, but I don't know anything outside the log errors that can tell you about json semantics.

 

[Major Squirrel]

Did you also change the file name to the specified unlocalized name ?

[blahblahbal]

That's not very specific... Which file? Again, the log now shows no errors whatsoever, yet the textures still show up missing.

 

(I think I know which file you mean, though, and yeah, I changed it. It actually was already the correct name (I think))

[blahblahbal]

Woo, it shows the textures now. But... now there's another problem... My world generator errors on load, java.lang.NoSuchFieldError: tadaniteOre. Guess I should take this to another topic though. Unless, of course, it's better I just redo this topic.

[TrashCaster]

Clearly the world generator can't find that field. So go look and make sure you do have that field.

[blahblahbal]

Yeah, got that much =P. I think it might have something to do with how tadaniteOre is of type ModBlockOre, and that isn't BasicBlock. Hang on... is it possible to make ModBlockOre extend BasicBlock and still be inheriting everything Block has? If so, then there's the solution. Then again... hmm. I don't have the code in front of me at the moment; I'll experiment tomorrow.

[blahblahbal]

Fixed the above, now I've got a custom ore gen problem . I'm (obviously) new to Minecraft modding, but I'd like to learn. Most of the tutorials (that I've found, that is) out there either don't cover ore gen or are outdated.

[jeffryfisher]

I've seen at least one other "Ore not Generating" thread in the last month. Use Google to find it and others. Make sure you've handled all of the issues in them, and then post more specifics here (what you've done, your generator code and registrations, steps through debugger, and what you see versus what you expect.

 

Ore generators can be tricky. I think the last guy was mis-handling his random number seed so he was starting every ore body with the same seed (and each successive ore body failed to replace the 1st one generated).

[blahblahbal]

Yeah, I think I found that thread. Unfortunately it wasn't helpful because the person never posted their solution.

 

Anyway, I think what's happening is it's trying to replace stone, which doesn't work in the nether. I came to this conclusion because I added another ore; one that generates in the overworld, and it generates just fine.

 

Also (on a completely unrelated note) where would one find the default armor model json files?

[Choonster]

Stick to one question per topic, don't replace the OP with a new question once you have the solution. This makes it harder for other people having the same problem to find the solution.

 

To generate ore in non-stone blocks, use the

WorldGenMinable(IBlockState, int, Predicate<IBlockState>)

constructor. The

Predicate

determines whether the ore can replace a given

IBlockState

. Use

BlockHelper.forBlock

to create a

Predicate

that matches any state of the specified

Block

.

 

The armour item models are in assets/minecraft/models/item with the other item models. Rendering armour on entity models is handled by

LayerArmorBase

and its subclasses, JSON models aren't used.

[blahblahbal]

Yay, that worked. Thanks.

 

And I hadn't thought about the topic change thing... I'll remember that.

 

I guess I'm off to make a thread about armor model code. Man, the tutorials out the are really outdated/incomplete...