[1.8.9]How to tell when an item is removed from the players inventory?

[Looke81]

You can use the OnUpdate method in Item to tell if the item is in the players inventory but how do you tell when an item is removed from the players inventory?

[Draco18s]

You can't.

 

No.

 

No, not even then.

 

No, you can't.  Its impossible.  There are so many ways an item can leave the player's inventory that you cannot know that it even has as some of them don't fire any sort of event or notification to any other system that it has removed the item.

[Looke81]

Ok. Can I tell if the item is removed by dropping it or if it is removed by picking up out the inventory?

[Draco18s]

ItemDropEvent

and no.

[Looke81]

Hmm I'm not sure if you understand what I meant because I just used ItemTossEvent and that:

 

* Event that is fired whenever a player tosses (Q) an item or drag-n-drops a

* stack of items outside the inventory GUI screens. Canceling the event will

* stop the items from entering the world, but will not prevent them being

* removed from the inventory - and thus removed from the system.

 

However the throwing outside the player gui works but the dropping on the ground only works on one side and i need it on both client and server.

[Looke81]

I have a custom inventory item that when particular items are in it it does something to the player but i need to stop that thing from happening when the item is removed from the player inventory.

[Looke81]

If you are familiar with the mod baubles it is an api that allows you to add "rings" and "amulets". I am calling the methods that these items use when they need to be activated if they are in my custom inventory. But i need to turn these attributes off if the item inventory is removed from the players inventory.

TickHandler

public class TatEventHandler {

@SubscribeEvent
public void PlayerEvent(PlayerEvent event) {

	EntityPlayer player = event.entityPlayer;

	if (player instanceof EntityPlayer) {
		if (player.isDead) {
			for (int a = 0; a < player.inventory.mainInventory.length; a++) {
				if (player.inventory.getStackInSlot(a) == new ItemStack(TatItems.itemBaublesBag)) {
					ItemStack baublesbag = player.inventory.getStackInSlot(a);
					InventoryBaublesBag inventorybaublesbag = (InventoryBaublesBag) BaublesBag.getInventory(baublesbag, player);
					for (int b = 0; b < inventorybaublesbag.inventory.length; b++) {
						if (inventorybaublesbag.getStackInSlot(b) != null && inventorybaublesbag.getStackInSlot(b).getItem() instanceof IBauble) {
							((IBauble) inventorybaublesbag.getStackInSlot(b).getItem()).onUnequipped(inventorybaublesbag.getStackInSlot(b), player);

						}
					}

				}
			}

		}
	}
}

@SubscribeEvent
public void ItemTossEvent(ItemTossEvent event) {
	EntityPlayer player = event.player;
	if (event.entityItem.getEntityItem().getItem() == TatItems.itemBaublesBag) {
		ItemStack baublesbag = event.entityItem.getEntityItem();
		InventoryBaublesBag inventorybaublesbag = (InventoryBaublesBag) BaublesBag.getInventory(baublesbag, player);
		for (int a = 0; a < inventorybaublesbag.inventory.length; a++) {
			if (inventorybaublesbag.getStackInSlot(a) != null && inventorybaublesbag.getStackInSlot(a).getItem() instanceof IBauble) {
				((IBauble) inventorybaublesbag.getStackInSlot(a).getItem()).onUnequipped(inventorybaublesbag.getStackInSlot(a), player);


			}
		}
	}
}

}

[Looke81]

Changed to PlayerTickEvent. Changed to .equals . onUnequiped is the method that is called when the bauble item is removed from the baubles inventory. I need to call is because I am basically making my own version of their inventory. If you haven't already: https://github.com/Azanor/Baubles

[Looke81]

Yes I do that but their inventory is not an item inventory and so I need to make sure when the player dies (which ive done) or when the player tosses the item that the unequipped method is called.Becasue decrStackSize does not get called when this happens.

[Looke81]

Cant I tell when the player presses the "toss key"?

[Looke81]

So why doesn't it work?(it works for the throwing out of inventory but not for pressing Q)

[Looke81]

[Draco18s]

When you're done, try shoving your item into an Item Frame.

 

Good luck solving that.

[Looke81]

When you're done, try shoving your item into an Item Frame.

 

Good luck solving that.

Very good point. Not to mention every other mod that takes the item out of the players inventory. Is there anyway to tell when the items stacksize has been decreased?Otherwise I may have to use a different approach with this whole thing but for now il continue on.

 

Use a debugger to find out what is happening. From what I can see the code paths for "press q" and "drop item outside inventory" are the same thing.

 

Well I thought it was a server client issue because throwing the item didn't stop my flight but i still took damage and so with this:

@SubscribeEvent
public void ItemTossEvent(ItemTossEvent event) {
	EntityPlayer player = event.player;
	if (event.entityItem.getEntityItem().getItem() == TatItems.itemBaublesBag) {
		ItemStack baublesbag = event.entityItem.getEntityItem();
		InventoryBaublesBag inventorybaublesbag = (InventoryBaublesBag) BaublesBag.getInventory(baublesbag, player);
		for (int a = 0; a < inventorybaublesbag.inventory.length; a++) {
			if (inventorybaublesbag.getStackInSlot(a) != null && inventorybaublesbag.getStackInSlot(a).getItem() instanceof IBauble) {
				if(player.worldObj.isRemote){
					System.out.println("client");
				}
				if(!player.worldObj.isRemote){
					System.out.println("server");
				}
				((IBauble) inventorybaublesbag.getStackInSlot(a).getItem()).onUnequipped(inventorybaublesbag.getStackInSlot(a), player);


			}
		}
	}
}

Putting the item outside the inventory prints both client and server whereas pressing "q" only prints server. So I think I am right in saying I need to send a packet from the server to the client then? Not an expert.

[Draco18s]

When you're done, try shoving your item into an Item Frame.

 

Good luck solving that.

Very good point. Not to mention every other mod that takes the item out of the players inventory. Is there anyway to tell when the items stacksize has been decreased?Otherwise I may have to use a different approach with this whole thing but for now il continue on.

 

As I said, there is NO event, NO notification, NO function that is called when this occurs.  The item stack's direct property object

stacksize

is decremented.  You can't even ASM that.

[Ernio]

I am here just to reassure (second others) you that tracking items (itemstacks) in: inventories (mobs, players, blocks) and world itself - while possible for some of those parties - will NEVER be fully safe/working. It is simply impossible to do that using any standard approach.

 

As to non-standard apporach - it won't end well (been there, done that), and again will never be "exact" and safe.

 

You can only track few things about items, but not all.

[UberAffe]

I'm confused as to why you are going about things the way your are ...

 

It sounds like you have a bauble that gives the user some buff as long as they have some other "fuel" item in their inventory.

Can't you achieve what you want by using the baubles ontick event. Every x ticks look at the players inventory and if they have the item, give the buff for x ticks. If they don't have the item then the buff won't get refreshed.

[Looke81]

Ok looks like I will have to take a different approach to this. Sorry I should have listened to you in the first place but I'm stubborn.