[1.9] Corner upside stairs rendering problem

[JimiIT92]

This happened in Forge 1.9 - 12.16.0.1854

I have some stairs placed upside-down, like this

 

But when i place a stair in the corner than this happen

[LexManos]

No it doesn't, You're using the wrong model for your blockstate. If you notice your 'corner' is in the wrong spot.

The engine THINKS it is where it supposed to be so it culls some of the faces in the neighbors block.

This is how the engine works, if you use a invalidly shaped model for any other block this will be the same result.

 

Fix your model.

[JimiIT92]

Strange, it works in a previous 1.9 version of Forge I'll check this out, thanks for the answer

[krisCrash]

Stair rendering does have some problems. I get this as well:

 

Left: Forge 1.9-12.16.0.1863, Right: Vanilla 1.9

 

These are custom stair models so they are revealing the problem a bit differently. In 1.8.9 stairs would cull adjacent blocks to some sides. In 1.9 stairs do not cause any render culling (maybe of slabs, slabs have their own thing here), they are treated like a true transparent block. But, with Forge, stairs are culling adjacent blocks.

 

I checked the 1.8.9 stairs blockstates and they aren't really different from 1.9 (like fences are because of multiparts).

 

JimiIT92, if you'd like me to go over your blockstates or model code I can do that for ya. If in doubt, I generally recommend pasting in the original vanilla code first, especially for blockstates.

 

I wasn't sure if I should make my own thread, if there's a set of stair problems

[LexManos]

Yes those stairs are abusing a bug in vanillas culling system that forge fixes.

Blocks need to be the basic shapes that vanilla blocks are. Solid sides need to be solid, simple as that.

[Roxane]

I had the same problem as shown in the first post. I'm using the latest recommended Forge: forge-1.9-12.16.1.1887-mdk

 

Vanilla Blocks just work fine in 1.8 and 1.9, my stais worked fine in 1.8, but in 1.9 my upper corner (inner and outer) stairs didn't rotate properly. The lower stairs were ok. Im using the vanilla models.

 

 

The solution for me was to change the blockstates and rotate the blocks there. I changed the "y"-Value in the lower half by either adding or substracting 90 degrees (outer_right +90, outer_left -90, inner_right +90, inner_left -90)

 

Code:

assets/roxastonestairs/blockstates/stoneStair.json for 1.8

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true }
    }
}

 

assets/roxastonestairs/blockstates/stoneStair.json for 1.9

{
    "variants": {
        "facing=east,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair" },
        "facing=west,half=bottom,shape=straight":    { "model": "RoxaStoneStairs:stoneStair", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight":   { "model": "RoxaStoneStairs:stoneStair", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right":{ "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right":{ "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":       { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight":      { "model": "RoxaStoneStairs:stoneStair", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right":   { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=outer_left":     { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=outer_left":    { "model": "RoxaStoneStairs:stoneStair_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right":   { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=east,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":   0, "uvlock": true },
        "facing=west,half=top,shape=inner_left":     { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y":  90, "uvlock": true },
        "facing=north,half=top,shape=inner_left":    { "model": "RoxaStoneStairs:stoneStair_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

[JimiIT92]

I don't know if this will help, but this are all my json files

 

blockstate

{
    "variants": {
        "facing=east,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs" },
        "facing=west,half=bottom,shape=straight":  { "model": "mw:aluminium_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight": { "model": "mw:aluminium_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":  { "model": "mw:aluminium_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight": { "model": "mw:aluminium_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=outer_right":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_right": { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=outer_left":  { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=outer_left": { "model": "mw:aluminium_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=inner_right":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_right": { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=inner_left":  { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=inner_left": { "model": "mw:aluminium_inner_stairs", "x": 180, "y": 270, "uvlock": true }
    }
}

 

Item

{
    "parent": "mw:block/aluminium_stairs"
}

 

Block models

normal

{
    "parent": "block/stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

inner

{
    "parent": "block/inner_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}

 

outer

{
    "parent": "block/outer_stairs",
    "textures": {
        "bottom": "mw:blocks/aluminium_block",
        "top": "mw:blocks/aluminium_block",
        "side": "mw:blocks/aluminium_block"
    }
}