Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.8.9][SOLVED] Custom colorable armor render with color like leather armor?

Featured Replies

Posted

I'm working on making some armor similar to leather in that it can be colored with dyes.
So far, I have the Item side of things working, and the sprite gets colored properly.
How would I go about getting the armor to be colored as well? I don't know where to start even after looking at the vanilla code.
Also, would this change if I'm using a custom model for the armor?
Item Class:
public class ItemMask extends ItemArmor {
public static final int DEFAULT_COLOR = 11324652;

public ItemMask(){
	super(ArmorMaterial.LEATHER, 0, 0);
	//this.hasSubtypes = true;
	this.setMaxDamage(0);
	this.setCreativeTab(Bionicle.bioMaskTab);
}

@Override
public String getArmorTexture(ItemStack stack, Entity entity, int slot, String layer){
	return Bionicle.MODID + ":textures/models/masks/" + this.getUnlocalizedName().substring(13) + "_5.png";
}

/*@SideOnly(Side.CLIENT)
@Override
public ModelBiped getArmorModel(EntityLivingBase entityLiving, ItemStack itemStack, int armorSlot, ModelBiped _default){
	ModelBiped armorModel = null;
	if(itemStack != null){
		if(itemStack.getItem() instanceof ItemMataMask){
			if(this == Bionicle.maskMataAkaku){
				armorModel = Bionicle.proxy.getArmorModel(0);//Akaku Model
			}else armorModel = Bionicle.proxy.getArmorModel(-1);//Generic Model
		}
	}
	if(armorModel != null){
		armorModel.bipedHead.showModel = false;
		armorModel.bipedHeadwear.showModel = armorSlot == 0;
		armorModel.bipedBody.showModel  = false;
		armorModel.bipedRightArm.showModel  = false;
		armorModel.bipedLeftArm.showModel  = false;
		armorModel.bipedRightLeg.showModel  = false;
		armorModel.bipedLeftLeg.showModel  = false;

		armorModel.isSneak = entityLiving.isSneaking();
		armorModel.isRiding = entityLiving.isRiding();
		armorModel.isChild = entityLiving.isChild();
		armorModel.heldItemRight = entityLiving.getEquipmentInSlot(0) != null ? 1 :0;
		if(entityLiving instanceof EntityPlayer){
			armorModel.aimedBow =((EntityPlayer)entityLiving).getItemInUseDuration() > 2;
		}
		return armorModel;
	}
	return null;
}*/

@Override
public boolean hasColor(ItemStack stack){
	return !stack.hasTagCompound() ? false : (!stack.getTagCompound().hasKey("display", 10) ? false : stack.getTagCompound().getCompoundTag("display").hasKey("color", 3));
}

@Override
public int getColor(ItemStack stack){
	NBTTagCompound nbttagcompound = stack.getTagCompound();
	if (nbttagcompound != null){
		NBTTagCompound nbttagcompound1 = nbttagcompound.getCompoundTag("display");
		if (nbttagcompound1 != null && nbttagcompound1.hasKey("color", 3)){
			return nbttagcompound1.getInteger("color");
		}
	}
	return DEFAULT_COLOR;
}

public void removeColor(ItemStack stack){
	NBTTagCompound nbttagcompound = stack.getTagCompound();
	if (nbttagcompound != null){
		NBTTagCompound nbttagcompound1 = nbttagcompound.getCompoundTag("display");
		if (nbttagcompound1.hasKey("color")){
			nbttagcompound1.removeTag("color");
		}
	}
}

public void setColor(ItemStack stack, int color){
	NBTTagCompound nbttagcompound = stack.getTagCompound();
	if (nbttagcompound == null){
		nbttagcompound = new NBTTagCompound();
		stack.setTagCompound(nbttagcompound);
	}
	NBTTagCompound nbttagcompound1 = nbttagcompound.getCompoundTag("display");
	if (!nbttagcompound.hasKey("display", 10)){
		nbttagcompound.setTag("display", nbttagcompound1);
	}
	nbttagcompound1.setInteger("color", color);
}
}

 

Any *useful* help would be appreciated!

 

 

EDIT: Finally Figured it out!

After finding some very useful information from Draco18s on other threads, I found my problem. (Thanks indirectly)

I initially tried creating a texture that was completely transparent with "_overlay" in the name like leather armor has, but that didn't work.

HERES THE KEY TO GET THIS TO WORK EVERYBODY:

In your getArmorTexture() function if you always return the texture you're wanting to have colored, then it will also use that for the overlay texture, which doesn't get colored.

The way to avoid that is to add a null check on the String argument for the function. When rendering normally it passes in null, but for overlay it passes the string "overlay".

So don't do this:

@Override
public String getArmorTexture(ItemStack stack, Entity entity, int slot, String layer){
	return "MODID:some/path/to/your/colorized/texture.png";
}

DO THIS:

@Override
public String getArmorTexture(ItemStack stack, Entity entity, int slot, String layer){
	if(layer == null){
		return "MODID:some/path/to/your/colorized/texture.png";
	}else return "MODID:some/path/to/a/blank/texture.png";
}

 

I hope people find this and use it!!

I think this is the method you are looking for.

https://github.com/Draco18s/Artifacts/blob/master/main/java/com/draco18s/artifacts/item/ItemArtifactArmor.java#L549-L553

It apparently wasn't deobfed in 1.7.10, but it might give you a lead.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Hmm, darn.  I remember having to struggle with that back in 1.7 when I originally added the armors.  I've forgotten what made it finally work, though.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

I ended up solving it, you can see my solution on my original post. I had to tell it to use my blank texture for the overlay in getArmorTexture()

Ah, yes.  That bit :)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 8 years later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.