Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.9] TileEntity empty packets


Notunknown
 Share

Recommended Posts

So I am trying to make a TileEntity send data from the server to the client but when the packets arrive they are empty. I have registered the TileEntity, do I need to register anything to do with the network?

 

The packets do, however, work when the TileEntity loads initially, it just doesn't work when updated.

 

@Override
public Packet<?> getDescriptionPacket()
{
NBTTagCompound tag = new NBTTagCompound();
if (this.hasStoredBlock())
{
	NBTTagCompound stored = new NBTTagCompound();
	stored.setString("name", storedBlock.getItem().getRegistryName().toString());
	stored.setInteger("meta", storedBlock.getItemDamage());
	stored.setInteger("amount", storeAmount);
	tag.setTag("storedBlock", stored);
}
return new SPacketUpdateTileEntity(this.getPos(), this.getBlockMetadata(), tag);
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt)
{
System.out.println(pkt.getNbtCompound().toString());
}

Link to comment
Share on other sites

markDirty only indicates that the data has changed and will need to be saved to disk when the next save() cycle runs.  It does not indicate that the data needs to be synced to the client.  IIRC, you want World#markBlockForUpdate()

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

markDirty only indicates that the data has changed and will need to be saved to disk when the next save() cycle runs.  It does not indicate that the data needs to be synced to the client.  IIRC, you want World#markBlockForUpdate()

 

Do you mean

World#markAndNotifyBlock

? That requires a lot of stuff like a Chunk, two IBlockStates and integer flags, in addition to a BlockPos.

Link to comment
Share on other sites

Apparently

World#markAndNotifyBlock

is what I wanted - I have no idea how to use it though. Why do I want to pass in the old IBlockState - or is that a supposed to be a blank object which will have its values copied onto by the IBlockState? Same goes for why I need to pass in a chunk object - is that the chunk the block is in? If so, why is that not calculated by the BlockPos I passed in?

 

And as for the flags, no idea what to pass there. Checking the code just reveals a load of magic numbers - I just passed in Integer.MAX_VALUE to be safe.

 

The one line comment is no help, either.

Link to comment
Share on other sites

Here we go again... xD

 

getDescriptionPacket() and onDataPacket() is used by internals only in one case (generally speaking) - when block is loaded by given client and server sends data about it, it (obviously) knows that this block has TileEntity and sends it too using those methods.

 

This update happens only when block is loaded (first packet) or when you tell it (block) to update.

This is why it requires few of mentioned fields.

 

Generally speaking - if you don't need to send something, you don't do it. And what I mean by that is that if you need to update NOT ALL of values held by TileEntity, you don't send ALL. You use SNW and IMessage and send: x/y/z and data (not even NBT). On client you get TE in x/y/z and update it.

End. Of. Story.

 

Anything that you do that is not needed is sign of poor or bad design.

 

SNW: www.minecraftforge.net/forum/index.php/topic,20135.0.html

 

As to how use markAndNotifyBlock - in this case it is quite bad in my opinion, but as to params - just look at callbacks :o

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Here we go again... xD

 

getDescriptionPacket() and onDataPacket() is used by internals only in one case (generally speaking) - when block is loaded by given client and server sends data about it, it (obviously) knows that this block has TileEntity and sends it too using those methods.

 

This update happens only when block is loaded (first packet) or when you tell it (block) to update.

This is why it requires few of mentioned fields.

 

Generally speaking - if you don't need to send something, you don't do it. And what I mean by that is that if you need to update NOT ALL of values held by TileEntity, you don't send ALL. You use SNW and IMessage and send: x/y/z and data (not even NBT). On client you get TE in x/y/z and update it.

End. Of. Story.

 

Anything that you do that is not needed is sign of poor or bad design.

 

SNW: www.minecraftforge.net/forum/index.php/topic,20135.0.html

 

As to how use markAndNotifyBlock - in this case it is quite bad in my opinion, but as to params - just look at callbacks :o

 

I know - I am now going to get it to only send the data which it needs to send - the entire point of this was GETTING it to send, which I have now achieved. Not quite sure how I did it, but I did it.

Link to comment
Share on other sites

However - that does present a question: What methods are employed to prevent the resending of redundant information? Currently I have two boolean values which are set prior to marking it for an update and are true by default (and reset to true after sending it). I believe this should send the appropriate information.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.