Removing the exact amount of an item from the inventory of the player

[madcrazydrumma]

Hey guys!

 

So I basically have an itemstack of say size 4 input into this method..

 

Now I want to remove this from the player's inventory, even if he/she doesn't have the exact amount in one itemstack. So there could be two itemstacks of size 2 that make up my input itemstack.

 

I've got this previously (but it doesn't work for obvious reasons):

 

public static void removeItem(EntityPlayer player, ItemStack is, int amount) {
	if(is == null)
		return;

	int removed = 0;

	for(ItemStack stack : player.inventory.mainInventory) {
		if(stack != null && removed <= amount) {
			if(areItemStacksEqual(stack, is)) {
				stack.stackSize--;
				removed++;
			}
		}
	}
}

 

This is my areItemStacksEqual implementation

 

public static boolean areItemStacksEqual(ItemStack stack1, ItemStack stack2) {
	if(stack1 == null || stack2 == null)
		return stack1 == stack2;

	return stack1.isItemEqual(stack2) && ItemStack.areItemStackTagsEqual(stack1, stack2);
}

 

I think I have to, instead of incrementing removed by one, I have to increment it by the amount of the stack?

 

Help is much appreciated! Thanks

[BusyBeever]

areItemStacksEqual checks if the stacks have the same stacksize, which is not what you want.

 

change ur method to take an Item as param instead of an ItemStack, and then check stack.getItem()==myPassedItem

[Draco18s]

Don't forget to check metadata.

[madcrazydrumma]

areItemStacksEqual checks if the stacks have the same stacksize, which is not what you want.

 

change ur method to take an Item as param instead of an ItemStack, and then check stack.getItem()==myPassedItem

 

Don't forget to check metadata.

 

I've got the implementation already myself. Check the updated OP.

[Notunknown]

Don't forget to check metadata.

 

And NBT?

[Draco18s]

[me=Draco18s]facepalm.[/me]

 

		if(stack1 == null || stack2 == null)
		return stack1 == stack2;

 

You should just return false here.  Passing two null stacks and getting a true is misleading (would you EVER want to do anything with two null stacks?), where as a single null stack and a not-null stack will always return false.

[Draco18s]

Passing two null stacks and getting a true is misleading

I think having equals(null, null) return false is even more misleading.

 

...Fair. I was probably tired and not thinking.