Hello,

 

I have a problem with my Worldgen class. I decided to update my mod to 1.9 but the generation don't work.

I'm not a professional of coding but I have just some basics of Java, Can you help me to correct and explain to me why my worldgen class don't work?

 

My Class:

package fr.jules552.mod.WorldGeneration;

import java.util.Random;

import fr.jules552.mod.Structures.Structure1;
import fr.jules552.mod.init.BlocksMod;
import net.minecraft.block.Block;
import net.minecraft.block.BlockDirt;
import net.minecraft.block.BlockStone;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;

public class WorldGenAd implements IWorldGenerator
{

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) 
{
	switch(world.provider.getDimension())
	{
	case -1: 
		GenerateNether(world, chunkX * 16, chunkZ * 16, random);
		break;

	case 0:
		GenerateOverworld(world, chunkX * 16, chunkZ * 16, random);

	case 1:
		GenerateEnd(world, chunkX * 16, chunkZ * 16, random);


	}


}

private void addOre(Block block, Block blockSpawn, Random random, World world, int posX, int posZ, int minY, int maxY, int minV, int maxV, int spawnChance)
{
	for(int i = 0; i < spawnChance; i++)
	{
		int defaultChunkSize = 16;
		int Xpos = posX + random.nextInt(defaultChunkSize);
		int Ypos = minY + random.nextInt(maxY - minY);
		int Zpos = posZ + random.nextInt(defaultChunkSize);

		IBlockState state = block.getDefaultState();
		BlockPos blockPos = new BlockPos(Xpos, Ypos, Zpos);

		new WorldGenMinable(state, maxV).generate(world, random, blockPos);

	}
}





private void GenerateNether(World world, int i, int j, Random random) 
{


}

private void GenerateOverworld(World world, int i, int j, Random random) 
{
	//Minerais
	addOre(BlocksMod.AdamantiumOre, Blocks.stone, random, world, i, j, 4, 16, 1, 3, 10);
	addOre(BlocksMod.SilverOre, Blocks.stone, random, world, i, j, 4, 48, 3, 4, 18);
	addOre(BlocksMod.AluminiumOre, Blocks.stone, random, world, i, j, 4, 48, 3, 6, 18);

	//Structures
	int Xpos = i+random.nextInt(16);
	int Ypos = random.nextInt(128);
	int Zpos = j+random.nextInt(16);

	for (int x = 0; x<500; x++)
	{
		new Structure1().genrate(world, random,new BlockPos (Xpos,Ypos,Zpos));	
	}

}

private void GenerateEnd(World world, int i, int j, Random random) 
{


}

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator,
		IChunkProvider chunkProvider) {

}

}

 

And my WorldRegister class :

 

package fr.jules552.mod.WorldGeneration;

import net.minecraftforge.fml.common.IWorldGenerator;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class WorldRegisterAd 
{
public static void MainRegistry()
{
	regsiterWorldGen(new WorldGenAd(), -1);
	regsiterWorldGen(new WorldGenAd(), 0);
	regsiterWorldGen(new WorldGenAd(), 1);
}

private static void regsiterWorldGen(IWorldGenerator iGenerator, int weightProbability )
{
	GameRegistry.registerWorldGenerator(iGenerator, weightProbability);

}

}

 

 

Thank you for your answer,

 

For the 3 register i don't really know, I was following a tutorial in Internet and the guy who do the tutorial used this method of registering , How can I fix that?

 

Where I missing a break?

 

Sorry for this basics questions but it's my first mod and my first update of course.

Thank you for giving of your time to answer me, It's very kind. 

Switch is using to prevent to using many "else if"? and break to go out the Switch?

I understand now for the switch, I fix the problem thank you  but for the register, It can work with the 3 registers ? or I must to change to only 1 register?

After a test with the fix, the generation don't work ;(