Jump to content

PlayerEvent.HarvestCheck is not BlockPos-aware


anti344

Recommended Posts

Soo, the only thing which calls ForgeEventFactory#doPlayerHarvestCheck (which sends the event) is EntityPlayer#canHarvesBlock and the only thing which calls that is ForgeHooks#canHarvestBlock which has a BlockPos, but does not pass it to the event.

 

Also, notice this forge->mc->forge jump :P

Link to comment
Share on other sites

Yes, it does a Forge->mc->Forge->mc->Forge->*** jump a lot in Forge, that's how programming works.

The position isnt there to keep compatibility with vanilla and OTHER MODs that call this function without location information.

We're not the only loader out there we still have to maintain compatibility with people who do dumb things.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.