Posted July 2, 20169 yr im making a client mod and i just need to get the string of the vanilla current title and the subtitle EDIT: hey guys i solved it with the help of diesieben07 diesieben again thank you so much for all the help! for people from the future that want to know what i did, this for Title: String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI); and this for subtitle: String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI); also if anyone wants a super easy method to get them i just made this: public static String getCurrentTitle(){ try { return (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI); } catch (IllegalAccessException e) {} return ""; } public static String getCurrentSubTitle(){ try { return (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI); } catch (IllegalAccessException e) {} return ""; } it should actually be safe to copypaste, i'v put it in my reference class and i can just call it whenever.. Doing stuff n' things
July 2, 20169 yr Author Title of what? title that was made by the vanilla title command Doing stuff n' things
July 2, 20169 yr Look at the CommandTitle class to see how it sends the title to the client, then look at how that packet's handler method sets the current title. Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.
July 2, 20169 yr Author Look at the CommandTitle class to see how it sends the title to the client, then look at how that packet's handler method sets the current title. that does not help me... i looked and i think im not qualafied to search stuff because i got nowhere could someone give me the piece of code that get the title and another that gets the subtitle please? Doing stuff n' things
July 2, 20169 yr Author someone? i really have no clue how to look up things inside existing code... i looked at the SPacketTitle and i looked at GuiIngame.. i dont seem to find a way to extract the 2 strings... please someone help i cant do anything until i get this working... Doing stuff n' things
July 2, 20169 yr Author Not sure what is so hard about this. Takes . i tried that the second i saw it and it didnt work... Doing stuff n' things
July 3, 20169 yr Author What "didn't work"? Show your attempt and any errors. listen, i am an idiot... im starting to learn java now and im too stupid to understand the way i just look at code.... from what i understood, i cannot take protected arguments and plain ol' nonstatic arguments from the GuiIngame class.... so please for the love of god just explain to me how im supposed to take this out of there into a class of mine. Doing stuff n' things
July 3, 20169 yr Author Well, see, now we have an actual question (at least somewhat). You can use Reflection to access fields that were otherwise inaccessible to you. And yes, since the fields are not static you need an instance of GuiIngame to access them, this is Minecraft#guiIngame . How to get the Minecraft instance? Minecraft.getMinecraft . And now, let me show you the process of how to find this information on your own so you can learn and do it yourself in the future: now i understand what i need to get.. but again i have no idea about Reflection because i never used it and online really cant explain it... i would really love to know how do i use it to extract these protected Strings: /** The current title displayed */ protected String displayedTitle = ""; /** The current sub-title displayed */ protected String displayedSubTitle = ""; i understand that i am calling for "Minecraft.getMinecraft().ingameGui.[protected unaccessable] but still i cant figure it out... Doing stuff n' things
July 3, 20169 yr Author online really cant explain it... Sure it can. What have you tried so far? so i tried this on a chat event: the event also has throws Exception cuz i had to GuiIngame newgui = new GuiIngame(Minecraft.getMinecraft()); Field field = Reference.getField(newgui.getClass(), "displayedTitle"); Reference.makeAccessible(field); System.out.println(field.get(newgui)); and my reference class has: public static Field getField(Class clazz, String fieldName) throws NoSuchFieldException { try { return clazz.getDeclaredField(fieldName); } catch (NoSuchFieldException e) { Class superClass = clazz.getSuperclass(); if (superClass == null) { throw e; } else { return getField(superClass, fieldName); } } } public static void makeAccessible(Field field) { if (!Modifier.isPublic(field.getModifiers()) || !Modifier.isPublic(field.getDeclaringClass().getModifiers())) { field.setAccessible(true); } } and it just outputs to log empty lines(well not empty, they have the [15:55:35] [Client thread/INFO]: [com.SHsuperCM.ElytraMCMod.MapInfo.MapChatHandler:getChatEvent:69]: ) Doing stuff n' things
July 3, 20169 yr Author Where did you get that code from? Did you write it yourself? Because it is pretty advanced for someone who 2 hours ago didn't know what reflection was. http://stackoverflow.com/questions/735230/java-reflection-access-protected-field Doing stuff n' things
July 3, 20169 yr Author Ok, that's way too much crap. private static final titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x"); private static final subtitleField = ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y"); soooo sorry for bothering the modder support so much but how do i use it? i have no idea what is the field object.. Doing stuff n' things
July 3, 20169 yr Author The Field object is a representation of, well, the field in code. You can get it's name ( getName ) and other metadata or you can read it's current value using the get method. what do i do in the get method? i tried that with Minecraft.getMinecraft() and i cant think of anything else that should be there? Doing stuff n' things
July 3, 20169 yr Author Read the documentation for it, it is worded pretty clearly: Returns the value of the field represented by this Field, on the specified object. [...]The underlying field's value is obtained as follows: If the underlying field is a static field, the obj argument is ignored; it may be null. Otherwise, the underlying field is an instance field. If the specified obj argument is null, the method throws a NullPointerException. If the specified object is not an instance of the class or interface declaring the underlying field, the method throws an IllegalArgumentException. [...] so i ended up with this: if(msg.contains("what's the title?")){ Field titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x"); System.out.println(titleField.get(null)); } and it didnt work... Doing stuff n' things
July 3, 20169 yr Author it dumps this in the console: [22:01:07] [Client thread/FATAL]: Error executing task java.util.concurrent.ExecutionException: java.lang.NullPointerException at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_92] at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_92] at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?] at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1107) [Minecraft.class:?] at net.minecraft.client.Minecraft.run(Minecraft.java:404) [Minecraft.class:?] at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92] at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?] at GradleStart.main(GradleStart.java:26) [start/:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92] at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134) [idea_rt.jar:?] Caused by: java.lang.NullPointerException at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) ~[?:1.8.0_92] at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36) ~[?:1.8.0_92] at java.lang.reflect.Field.get(Field.java:393) ~[?:1.8.0_92] at com.SHsuperCM.ElytraMCMod.MapInfo.MapChatHandler.getChatEvent(MapChatHandler.java:80) ~[MapChatHandler.class:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_MapChatHandler_getChatEvent_ClientChatReceivedEvent.invoke(.dynamic) ~[?:?] at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49) ~[ASMEventHandler.class:?] at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?] at net.minecraftforge.event.ForgeEventFactory.onClientChat(ForgeEventFactory.java:269) ~[ForgeEventFactory.class:?] at net.minecraft.client.network.NetHandlerPlayClient.handleChat(NetHandlerPlayClient.java:887) ~[NetHandlerPlayClient.class:?] at net.minecraft.network.play.server.SPacketChat.processPacket(SPacketChat.java:54) ~[sPacketChat.class:?] at net.minecraft.network.play.server.SPacketChat.processPacket(SPacketChat.java:11) ~[sPacketChat.class:?] at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_92] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_92] at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?] ... 20 more Doing stuff n' things
July 3, 20169 yr Author You disregarded everything I previously said in this thread AND you disregarded the documentation I quoted. Good job. it seems that whatever i try with private static final titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x"); private static final subtitleField = ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y"); just doesnt work... first from my knowledge of java you cant just do public static final titlefield = it says no identifier... and if i fix it from what it returns to get it into an actuall object it just thows errors whatever i do with it.. im currently laughing on how i cant understand anything in lyfe but i really need this to work so i can keep on moddin' Doing stuff n' things
July 3, 20169 yr Author you know of any working code of this that i can break down to some thing i understand? Doing stuff n' things
July 4, 20169 yr Author first from my knowledge of java you cant just do public static final titlefield =What. Of course you can. That's how you declare fields. You call get() on these things with Minecraft.getMinecraft().ingameGui as the argument. Seriously, this is simple. diesieben again thank you so much for all the help! i finally figured it out! for people from the future that want to know what i did, this for Title: String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI); and this for subtitle: String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI); Doing stuff n' things
July 4, 20169 yr Author Don't look up the field every single time... Store them! Like I already showed you. its not letting me do that... but what does looking each time hurt it? its working fine for what im doing... Doing stuff n' things
July 4, 20169 yr Author its not letting me do that...Show what you tried.but what does looking each time hurt it?Because looking up the field is slower than dial-up. just putting what you said throws a bunch of errors identifier required... i dont need to work on this part currently because its not slowing down anything for me... if it becomes a giant issue than ill go again to it but now im working on other parts of my mod... its working now and that's what matters..... Doing stuff n' things
December 18, 20222 yr On 7/4/2016 at 3:13 AM, SHsuperCM said: it seems that whatever i try with just doesnt work... first from my knowledge of java you cant just do public static final titlefield = it says no identifier... and if i fix it from what it returns to get it into an actuall object it just thows errors whatever i do with it.. im currently laughing on how i cant understand anything in lyfe but i really need this to work so i can keep on moddin' judge the NullUnexpection plsss :)
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.