Jump to content

[1.9.4] Checking if EntityItem has a certain ItemStack


Recommended Posts

I have an item, which when interacted with a Block, checks if there are EntityItems around the block using World.getEntitiesWithinAABB(EntityItem.class, aabb). If the EntityItems contain a certain type of ItemStack (checked with EntityItem.getEntityItem()) then it sets a flag which will be later used. However, when compared to an ItemStack, it always returns false. I am dropping the correct items near the block, and have verified that it knows the items are there by checking the ItemStacks around using println. This leads me to believe that there is a problem with the check.


Amalgamite.java (snippet, item)

    public EnumActionResult onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
    	if (worldIn.getBlockState(pos).getBlock() instanceof Amalgamator) {
    		EntityItem ironIngots = null;
    		EntityItem wool = null;
    		if (AncepsUtil.itemsNearby(worldIn, pos, Amalgamator.detectRange)) { // function which checks if items are nearby (self-explanatory)
    			AxisAlignedBB bb = new AxisAlignedBB(pos.getX() - 4, pos.getY() - 4, pos.getZ() - 4, pos.getX() + 4, pos.getY() + 4, pos.getZ() + 4);
    			List<? extends EntityItem> items = worldIn.getEntitiesWithinAABB(EntityItem.class, bb);
    			for (EntityItem i : items) { // start of problem
    				if (!worldIn.isRemote) {
    					if (i.getEntityItem().equals(new ItemStack(Items.iron_ingot, )) {
    						System.out.println("iron success");
    						ironIngots = i;
    					} else if (i.getEntityItem().equals(new ItemStack(Blocks.wool, 1, OreDictionary.WILDCARD_VALUE))) {
    						System.out.println("wool success");
    						wool = i;
    			if (ironIngots != null && wool != null) {
                                if (!worldIn.isRemote) {
    				       worldIn.spawnEntityInWorld(new EntityItem(worldIn, pos.getX(), pos.getY() + 1, pos.getZ(), new ItemStack(AncepsMain.woolyironingot))); // result
    				return EnumActionResult.SUCCESS;
        return EnumActionResult.PASS;



public static boolean itemsNearby(World worldObj, BlockPos posAt, int detectRange) {
	AxisAlignedBB bb = new AxisAlignedBB(posAt.getX() - detectRange, posAt.getY(), posAt.getZ() - detectRange, posAt.getX() + detectRange, posAt.getY() + detectRange, posAt.getZ() + detectRange);
	return worldObj.getEntitiesWithinAABB(EntityItem.class, bb) != null;

Link to comment
Share on other sites

ItemStack does not override equals(). You must use stack.getItem() and compare Item instances

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.


Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.


DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.