Jump to content

[1.9.4] Making a weapon apply a potion effect randomly?


Recommended Posts


After making a new custom item apply slowness when I hit an enemy, how would I make it so it randomly applies the effect?

For example, when the player hits another entity with this item, it has a 1 in 4 chance to apply Slowness on hit to the target.

If I'm asking a whole bunch of questions, please don't get angry. I'm trying to learn.

Link to comment
Share on other sites

Yes, I have been able to make it apply on hit. I'm just not sure how to implement a random number generator in Java code, as all the online examples seem fairly complex.

If I'm asking a whole bunch of questions, please don't get angry. I'm trying to learn.

Link to comment
Share on other sites

I'm just not sure how to use that to create a random number generator. I'm also not familiar with making random number generators in Java either.

(I know this forum isn't a Java school. I do know basic Java programming.)


Screw it, had a shot at making one. Didn't quite turn out well, went from applying all the time to never.

Here's the code:



package com.t10a.minedran.item.weapons;

import java.util.List;
import java.util.Random;
import java.util.Set;

import com.google.common.collect.Sets;
import com.t10a.minedran.reference.Reference;

import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.MobEffects;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemTool;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

import com.t10a.minedran.reference.EventHandler;

public class ItemMace extends ItemTool 
//Dummy set to get the tool class to shut up. Also, stops the crashing. 
private static final Set<Block> MaceBlocks = Sets.newHashSet(new Block[] {Blocks.BEDROCK});

public ItemMace(ToolMaterial material) {
	super(1.0F, -2.8F, material, MaceBlocks);
	this.efficiencyOnProperMaterial = 0.0F;

	setUnlocalizedName(Reference.ItemBase.MACE.getUnlocalizedName() + "_" + getToolMaterialName().toLowerCase());
	setRegistryName(Reference.ItemBase.MACE.getRegistryName()  + "_" + getToolMaterialName().toLowerCase());

public void addInformation(ItemStack stack, EntityPlayer player, List<String> list, boolean par4)
list.add("Hit enemies to stun them w/ Slowness!");

public boolean hitEntity(ItemStack stack, EntityLivingBase target, EntityLivingBase attacker) 
	int pow=(int)(Math.random()*4+1);
	if ( pow==0 )
		target.addPotionEffect(new PotionEffect(MobEffects.SLOWNESS, 80));
	stack.damageItem(1, attacker);
	return super.hitEntity(stack, target, attacker);

    public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
        if ((double)state.getBlockHardness(worldIn, pos) != 0.0D)
            stack.damageItem(2, entityLiving);

        return true;


How can I fix this?

If I'm asking a whole bunch of questions, please don't get angry. I'm trying to learn.

Link to comment
Share on other sites


is a (pseudo-)random number generator. Call


to get a random integer in the specified range.



returns a random number in the range

[0, 1)

(i.e. greater than or equal to 0, less than 1). If you multiply by 4 and add 1, the new range is

[1, 5)

; which means that it will never be 0 and your potion effect will never be applied.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.