Search the Forums BEFORE making a new post.

Currently supported: All versions

Custom Bow

Posted July 12, 20169 yr

Hey, It's me again

As the title says, I am making a custom bow. With some help from some users I already made the bow work partially.

2 things don't work:

- The bow does not get a zoom (I mean the zoom you get by pulling the normal bow)

- When the player collects the arrow, an arrow will be added to the creative inventory

Can you help me? Thanks in advance :'(

*Hug*

Quote

July 12, 20169 yr

- The bow does not get a zoom (I mean the zoom you get by pulling the normal bow)

You need to handle

FOVUpdate

and imitate the vanilla bow's FOV modification if the player is currently using your bow. You can see how I do this here.

- When the player collects the arrow, an arrow will be added to the creative inventory

This is vanilla behaviour.

When a player shoots an arrow in creative mode or with a bow that has the Infinity enchantment, the pickup status is set to

CREATIVE_ONLY

; i.e. only players in creative mode can pick it up.

When a player shoots an arrow normally, the pickup status is set to

ALLOWED

; i.e. any player can pick it up.

When a mob shoots an arrow, the pickup status is set to

DISALLOWED

; i.e. no players can pick it up.

If you don't want the arrow to be picked up by anyone, set its pickup status to

DISALLOWED

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

July 13, 20169 yr

Author

This is vanilla behaviour.

- I know but the arrow gets collected by the player and gets actually added to the inventory...

[Example: You got an empty slot in your hotbar. When you collect an arrow from the ground which got shot with my custom bow, you will habe an arrow in your horbar]

With the normal bow you shot, collect the arrow and it won't be added to the inventory.

[Example: The collected arrow won't be in your hotbar]

*Hug*

Quote

July 13, 20169 yr

EntityArrow#onCollideWithPlayer

, the item is only added to the player's inventory if the pickup status is

ALLOWED

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

July 13, 20169 yr

Author

But the pickup-status is PickupStatus#CREATIVE_ONLY

	@Override
    public void onPlayerStoppedUsing ( ItemStack stack , World world , EntityLivingBase entity , int charge ) {

        if ( entity instanceof EntityPlayer ) {
        	
            EntityPlayer player = ( EntityPlayer ) entity;
            boolean ammoRequired = this.isAmmoRequired( stack , player );
            ItemStack ammo = this.getAmmo( player );

            int duration = this.getMaxItemUseDuration( stack ) - charge;
            duration = ForgeEventFactory.onArrowLoose( stack , world , ( EntityPlayer ) entity , duration , stack != null || ammoRequired );
            if ( duration < 0 ) { return; }

            if ( stack != null || ammoRequired ) {
            	
                if ( stack == null ) {
                	
                    stack = new ItemStack ( Items.arrow );
                    
                }

                float velocity = this.func_185059_b( duration );

                if ( ( double ) velocity >= 0.1D ) {
                	
                    boolean unpickable = ammoRequired && stack.getItem() instanceof ItemArrow; //Forge: Fix consuming custom arrows.

                    if ( !world.isRemote ) {
                    	
                        ItemArrow arrowItem = ( ItemArrow ) ( ( ItemArrow ) ( stack.getItem() instanceof ItemArrow ? stack.getItem() : Items.arrow ) );
                        EntityArrow arrow = arrowItem.makeTippedArrow( world , stack, player );
                        arrow.func_184547_a( player , player.rotationPitch , player.rotationYaw , 0.0F , velocity * 3.0F , 1.0F );

                        if ( velocity == 1.0F ) {
                        	
                            arrow.setIsCritical( true );
                            
                        }

                        int levelPower = EnchantmentHelper.getEnchantmentLevel(Enchantments.power, stack);

                        if ( levelPower > 0 ) {
                        	
                            arrow.setDamage( this.baseDamage + arrow.getDamage() + ( double ) levelPower  * 0.5D + 0.5D );
                            System.out.println( this.baseDamage + arrow.getDamage() + ( double ) levelPower  * 0.5D + 0.5D );
                            
                        } else { arrow.setDamage( this.baseDamage + arrow.getDamage() + 0.5D ); System.out.println( this.baseDamage + arrow.getDamage() + 0.5D ); }

                        int levelPunch = EnchantmentHelper.getEnchantmentLevel(Enchantments.punch, stack);

                        if ( levelPunch > 0 ) {
                        	
                            arrow.setKnockbackStrength( levelPunch );
                            
                        }

                        if ( EnchantmentHelper.getEnchantmentLevel( Enchantments.flame , stack ) > 0 ) {
                        	
                            arrow.setFire( 100 );
                            
                        }

                        stack.damageItem( 1 , player );

                        if ( unpickable ) {
                        	
                            arrow.canBePickedUp = EntityArrow.PickupStatus.CREATIVE_ONLY;
                            
                        }

                        world.spawnEntityInWorld( arrow );
                        
                    }

                    world.playSound( ( EntityPlayer ) null , player.posX , player.posY , player.posZ , SoundEvents.entity_arrow_shoot , SoundCategory.NEUTRAL , 1.0F , 1.0F / ( itemRand.nextFloat() * 0.4F + 1.2F ) + velocity * 0.5F );

                    if ( !unpickable && !player.capabilities.isCreativeMode ) {
                    	
                        --ammo.stackSize;

                        if ( ammo .stackSize == 0 ) {
                        	
                            player.inventory.deleteStack( ammo );
                            
                        }
                        
                    }

                    player.addStat( StatList.func_188057_b( this ) );
                    
                }
            }
        }
    }

*Hug*

Quote

July 13, 20169 yr

I have this and this works for me:

public void onPlayerStoppedUsing(ItemStack stack, World worldIn, EntityLivingBase entityLiving, int timeLeft) {
	if (entityLiving instanceof EntityPlayer) {
		EntityPlayer entityplayer = (EntityPlayer) entityLiving;
		boolean flag = entityplayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantments.INFINITY, stack) > 0;
		ItemStack itemstack = this.findAmmo(entityplayer);
		int i = this.getMaxItemUseDuration(stack) - timeLeft;
		i = net.minecraftforge.event.ForgeEventFactory.onArrowLoose(stack, worldIn, (EntityPlayer) entityLiving, i, itemstack != null || flag);
		if (i < 0) return;
		if (itemstack != null || flag) {
			if (itemstack == null) {
				itemstack = new ItemStack(Items.ARROW);
			}
			float f = getArrowVelocity(i);
			if ((double) f >= 0.1D) {
				boolean flag1 = entityplayer.capabilities.isCreativeMode || (itemstack.getItem() instanceof ItemArrow ? ((ItemArrow) itemstack.getItem()).isInfinite(itemstack, stack, entityplayer) : false);
				if (!worldIn.isRemote) {
					ItemArrow itemarrow = (ItemArrow) ((ItemArrow) (itemstack.getItem() instanceof ItemArrow ? itemstack.getItem() : Items.ARROW));
					EntityArrow entityarrow = itemarrow.createArrow(worldIn, itemstack, entityplayer);
					entityarrow.setAim(entityplayer, entityplayer.rotationPitch, entityplayer.rotationYaw, 0.0F, f * 3.0F, 1.0F);
					if (f == 1.0F) {
						entityarrow.setIsCritical(true);
					}
					int j = EnchantmentHelper.getEnchantmentLevel(Enchantments.POWER, stack);
					entityarrow.setDamage(10.0F);
					if (j > 0) {
						entityarrow.setDamage(entityarrow.getDamage() + (double) j * 0.5D + 0.5D);
					}
					int k = EnchantmentHelper.getEnchantmentLevel(Enchantments.PUNCH, stack);
					if (k > 0) {
						entityarrow.setKnockbackStrength(k);
					}
					if (EnchantmentHelper.getEnchantmentLevel(Enchantments.FLAME, stack) > 0) {
						entityarrow.setFire(100);
					}
					stack.damageItem(1, entityplayer);
					if (flag1) {
						entityarrow.pickupStatus = EntityArrow.PickupStatus.CREATIVE_ONLY;
					}
					worldIn.spawnEntityInWorld(entityarrow);
				}
				worldIn.playSound((EntityPlayer) null, entityplayer.posX, entityplayer.posY, entityplayer.posZ,
						SoundEvents.ENTITY_ARROW_SHOOT, SoundCategory.NEUTRAL, 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);
				if (!flag1) {
					--itemstack.stackSize;
					if (itemstack.stackSize == 0) {
						entityplayer.inventory.deleteStack(itemstack);
					}
				}
			}
		}
	}
}

http://i.imgur.com/J4rrGt6.png[/img]

Quote

July 13, 20169 yr

But the pickup-status is PickupStatus#CREATIVE_ONLY

boolean unpickable = ammoRequired && stack.getItem() instanceof ItemArrow; //Forge: Fix consuming custom arrows.

if ( unpickable ) {                        	
    arrow.canBePickedUp = EntityArrow.PickupStatus.CREATIVE_ONLY;                            
}

You're setting the pickup status to

CREATIVE_ONLY

when ammo is required (i.e. no Infinity enchantment or creative mode). This is the opposite of what you want.

I suggest looking at

ItemBow#onPlayerStoppedUsing

again.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

July 14, 20169 yr

Author

That was my fault. I fixed it but it didn't help me.

This is my problem in a collage:

I suggest looking at ItemBow#onPlayerStoppedUsing again.

I already done that. I looked at your code for your [glow=red,2,300]TestBow[/glow] and at ItemBow#onPlayerStoppedUsing but I don't know my mistake D:

EDIT: Fixed it. But when the shot arrow was something like an "Arrow Of Leaping" it will get turned into a normal arrow and I don't know how to change the FOV properly. I want it to change it like with the normal bow

*Hug*

Quote

July 14, 20169 yr

I explained how to handle the FOV in my first post.

Post your new code.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

July 14, 20169 yr

Author

I don't know how to change the FOV properly

Chose wrong words. I just don't know which values I have to take or where I can find them. I already looked up in the API and different mods.

Code:

	@Override
    public void onPlayerStoppedUsing ( ItemStack stack , World world , EntityLivingBase entity , int charge ) {

        if ( entity instanceof EntityPlayer ) {
        	
            EntityPlayer player = ( EntityPlayer ) entity;
            boolean ammoRequired = this.isAmmoRequired( stack , player );
            ItemStack ammo = this.findAmmo( player );

            int duration = this.getMaxItemUseDuration( stack ) - charge;
            duration = net.minecraftforge.event.ForgeEventFactory.onArrowLoose( stack , world , ( EntityPlayer ) entity , duration , stack != null || ammoRequired );
            if ( duration < 0 ) { return; }

            if ( stack != null || ammoRequired ) {
            	
                if ( stack == null ) {
                	
                    stack = new ItemStack ( Items.arrow );
                    
                }

                float velocity = this.func_185059_b( duration );

                if ( ( double ) velocity >= 0.1D ) {
                	
                    boolean unpickable = player.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel( Enchantments.infinity , stack ) > 0;

                    if ( !world.isRemote ) {
                    	
                        ItemArrow arrowItem = ( ItemArrow ) ( ( ItemArrow ) ( stack.getItem() instanceof ItemArrow ? stack.getItem() : Items.arrow ) );
                        EntityArrow arrow = arrowItem.makeTippedArrow( world , stack , player );
                        arrow.func_184547_a( player , player.rotationPitch , player.rotationYaw , 0.0F , velocity * 3.0F , 1.0F );

                        if ( velocity == 1.0F ) {
                        	
                            arrow.setIsCritical( true );
                            
                        }

                        int levelPower = EnchantmentHelper.getEnchantmentLevel( Enchantments.power , stack );

                        if ( levelPower > 0 ) {
                        	
                            arrow.setDamage( this.baseDamage + arrow.getDamage() + ( double ) levelPower  * 0.5D + 0.5D );
                            
                        } else { arrow.setDamage( this.baseDamage + arrow.getDamage() + 0.5D ); System.out.println( this.baseDamage + arrow.getDamage() + 0.5D ); }

                        int levelPunch = EnchantmentHelper.getEnchantmentLevel( Enchantments.punch , stack );

                        if ( levelPunch > 0 ) {
                        	
                            arrow.setKnockbackStrength( levelPunch );
                            
                        }

                        if ( EnchantmentHelper.getEnchantmentLevel( Enchantments.flame , stack ) > 0 ) {
                        	
                            arrow.setFire( 100 );
                            
                        }

                        stack.damageItem( 1 , player );

                        if ( unpickable ) {
                        	
                            arrow.canBePickedUp = EntityArrow.PickupStatus.CREATIVE_ONLY;
                            
                        }

                        world.spawnEntityInWorld( arrow );
                        
                    }

                    world.playSound( ( EntityPlayer ) null , player.posX , player.posY , player.posZ , SoundEvents.entity_arrow_shoot , SoundCategory.NEUTRAL , 1.0F , 1.0F / ( itemRand.nextFloat() * 0.4F + 1.2F ) + velocity * 0.5F );

                    if ( !unpickable && !player.capabilities.isCreativeMode ) {
                    	
                        --ammo.stackSize;

                        if ( ammo .stackSize == 0 ) {
                        	
                            player.inventory.deleteStack( ammo );
                            
                        }
                        
                    }

                    player.addStat( StatList.func_188057_b( this ) );
                    
                }
                
            }
            
        }
        
    }

*Hug*

Quote

July 14, 20169 yr

I can't see any obvious problems with your code, I suggest stepping through it in a debugger to see where things go wrong.

For the FOV values, look at

AbstractClientPlayer#getFovModifier

(where

FOVUpdateEvent

is fired) or the code from my mod that I linked in my first post.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/40288-custom-bow/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 16 hours ago16 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Yesterday at 04:08 PM1 day
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Yesterday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Tuesday at 08:42 PM1 day

Sign In

Custom Bow

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)