[1.8.9] Mana bar reset

[JimiIT92]

So sorry to reopen this thread, but i've noticed that when the player comes back from the End the bar glitches out (it's shown fully charge when instead the player has a different value). I've already checked if the value is passed correctly, and it is, so i don't know why it is shown full. I've added this function in the event handler to catch the "player return from End event"

@SubscribeEvent
public void onClonePlayer(PlayerEvent.Clone event) {
	ExtendedPlayer props = ExtendedPlayer.get(event.original);
	ExtendedPlayer.get(event.entityPlayer).copy(props);
	RPG.INSTANCE.sendTo(new ManaValue(props.getCurrentMana()), (EntityPlayerMP) event.entityPlayer);
}

 

I've tried sending a specific amount of mana in the message, but the bar is still full

[JimiIT92]

Got this now

@SubscribeEvent
public void onClonePlayer(PlayerEvent.Clone event) {
	ExtendedPlayer props = ExtendedPlayer.get(event.original);
	ExtendedPlayer.get(event.entityPlayer).copy(props);
}

 

but still full bar until a new spell is casted

[JimiIT92]

Didn't saw that edit Thanks, this works now

PS: if i want to do some sort of regen (like every 5 seconds add 1 mana point) how could i do? I've tried the playerTickEvent but it lags of course)

[JimiIT92]

I think i'm going somewhere. Right now i got this tick handler

@SubscribeEvent
public void onTick(PlayerTickEvent event) {
	ExtendedPlayer props = ExtendedPlayer.get(event.player);
	props.elapseTick();
	if(props.shouldSend()) {
		RPG.INSTANCE.sendTo(new ManaValue(props.getCurrentMana()), (EntityPlayerMP) event.player);
	}
}

 

That every 5 seconds should update the mana value by one. However the game crashes when should send the packet, giving a cast Exception

[03:16:42] [Client thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.fml.common.gameevent.TickEvent$PlayerTickEvent@1b8354aa:
java.lang.ClassCastException: net.minecraft.client.entity.EntityPlayerSP cannot be cast to net.minecraft.entity.player.EntityPlayerMP
at com.rpg.events.EventHandler.onTick(EventHandler.java:60) ~[EventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_EventHandler_onTick_PlayerTickEvent.invoke(.dynamic) ~[?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49) ~[ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140) [EventBus.class:?]
at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPostTick(FMLCommonHandler.java:357) [FMLCommonHandler.class:?]
at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:402) [EntityPlayer.class:?]
at net.minecraft.client.entity.EntityPlayerSP.onUpdate(EntityPlayerSP.java:163) [EntityPlayerSP.class:?]
at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:2011) [World.class:?]
at net.minecraft.world.World.updateEntity(World.java:1976) [World.class:?]
at net.minecraft.world.World.updateEntities(World.java:1805) [World.class:?]
at net.minecraft.client.Minecraft.runTick(Minecraft.java:2176) [Minecraft.class:?]
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1080) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:380) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:116) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_92]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
at GradleStart.main(GradleStart.java:26) [start/:?]

 

[JimiIT92]

I've never worked with packets so i know that are not handled as well So basically the calls i do in the handlers i shoul do in some methods ins the IEEP?

[JimiIT92]

Mmmm, so i could just use one single method in the IEEP class that send the packet with the amount of mana and then call that or send the packet when i change the mana value directly into IEEP functions? For example the setCurrentMana

[Draco18s]

You effectively need two methods in your IEEP (possibly more, but these two are key):

 

addMana(amount)

subtractMana(amount)

 

You could even make them one method, but we'll assume that they perform different checks and might have to be separate.  However the general structure is the same:

 

addSubMana(int amount) {
    /* check if able, floor/ceiling to min/max if needed */
    theManaAmount += amount;
    sendPacketToClient(....);
}

 

Then in

private sendPacketToClient

you...send an update packet to the client informing them of their new mana amount.

[JimiIT92]

Just as i was suspecting, centralized the functions to change mana (basically add or subtract) and then send packets inside them Allright, thanks for the tip on optimization