[Solved] On kill of zombie

[Betterjakers]

Hello! Does anyone know how to test for when a players kills a zombie? You're gonna hate me, I'm sorry, but I am on 1.6.4  :'(

[coolAlias]

LivingDeathEvent, check if entity killed is instanceof EntityZombie and if the source of damage was caused by a player. This works in pretty much every version of Minecraft/Forge since at least 1.6.4.

[Betterjakers]

Alright, thanks! Would this work?

 

@ForgeSubscribe

public void onEntityDeath(LivingDeathEvent event) {

if(event.entityLiving instanceof EntityZombie) {

 

    System.out.println("Hello!");

   

}

   

    }

[coolAlias]

If you registered the class containing that method to the Forge event bus, yeah, that's the basic premise and should be printing 'Hello!' every time a zombie dies.

[Betterjakers]

I did not register it to the forge event bus. How can I do that?

[coolAlias]

// during pretty much any of the mod init phases:
MinecraftForge.EVENT_BUS.register(new YourEventClass());

A quick Google search will bring up a lot of information on using Forge events that would be cumbersome to reproduce in forum posts.

[Betterjakers]

I did this, and it does not seem to work. I registered it to the event bus, so it should be working. Here is my class:

 

package mymod.quests;

 

import net.minecraft.entity.player.EntityPlayer;

import net.minecraftforge.event.ForgeSubscribe;

import net.minecraftforge.event.entity.living.LivingDeathEvent;

 

public class Test {

 

@ForgeSubscribe

public void onEntityDeath(LivingDeathEvent event) {

if(event.entityLiving instanceof EntityPlayer) {

 

    System.out.println("Hello!");

   

}

   

    }

 

}

[Animefan8888]

In your initialization method you need to call MinecraftForge.EVENT_BUS.register(new EventHandlerClass());

[Betterjakers]

What? In my main mod class, this is where I have it:

 

public static void init1( FMLInitializationEvent event )

{

MinecraftForge.EVENT_BUS.register(new SoundHandler());

MinecraftForge.EVENT_BUS.register(new Test());

}

[Animefan8888]

Now that I look at your code you are checking to see if the entity that died is an instance of EntityPlayer not entity Zombie. Sorry I read that post wrong. ANd to check if it was the player that killed it, use the damagesource object.

[Betterjakers]

I changed it to EntityZombie but when a zombie dies, it does not say "Hello!" in console.

[Animefan8888]

What Minecraft version are you using.

[Betterjakers]

1.6.4

[Animefan8888]

Why are you still using 1.6.4? And Instead of MinecraftForge.EVENT_BUS.register(new EventHandlerClass) use FMLCommonHandler.instance().bus().register(new EventHandlerClass);

[coolAlias]

The first version you posted should be printing to the console each time a zombie dies. To test if your event handler is working at all, you can put a println at the very beginning of it:

@ForgeSubscribe
public void onEntityDeath(LivingDeathEvent event) {
  System.out.println("Entity died: " + event.entity);
}

If you're not getting any output at all, make sure you actually call that random static init1 method you posted... it'd be simpler just to register directly during one of the FML events.

 

Edit: No, don't use FMLCommonHandler event bus - that's the wrong bus for this event. Here's a tutorial  - please read it so we don't have to repeat the same information over and over again.

[Betterjakers]

Thanks! I did have the event bus in the wrong place. It now works. Now, how can I send a message to the killer?

[Animefan8888]

Oh thank you Cool Alias I completely forgot what goes where when dealing with Events thanks for the refresher, now if you'll excuse me I've got some reading to refresh on.

[coolAlias]

No worries - that's the reason they finally consolidated the event buses, it was a mess keeping track of them.

 

@OP As we've said, you have to check if the DamageSource#getEntity is an EntityPlayer, then cast that entity to EntityPlayer so you can call I believe #addChatMessage to send them a chat - it's been a long time since I've looked at 1.6.4 and the chat methods have changed a lot since then, so you may have to look for it yourself.

[Betterjakers]

Thanks you so much everyone, I got everything I wanted to done!