[Solved] [1.10.2] Item NBT issues

[Zerahi]

Having a problem with item nbt. i setup the item with onCreated, then when i go to get something from the nbt with onItemRightClick it null points

 

any ideas?

 

Crash at item.getTagCompound().getInteger("power") <= 1900;

 

public void onCreated(ItemStack item, World worldIn, EntityPlayer playerIn)
    {
	    item.setTagCompound(new NBTTagCompound());
	    this.setDamage(item, 2000);
	    item.getTagCompound().setInteger("power", 2000);
	    item.getTagCompound().setBoolean("active", false);
    }

 

public ActionResult<ItemStack> onItemRightClick(ItemStack item, World world, EntityPlayer player, EnumHand hand)
{

	if (item.getTagCompound().getInteger("power") <= 1900 && !item.getTagCompound().getBoolean("active")) {


		item.getTagCompound().setBoolean("active", false);
		this.setDamage(item, (int) (this.getDamage(item) +(100)));
		item.getTagCompound().setShort("power", (short) this.getDamage(item));
		player.addPotionEffect(new PotionEffect(MobEffects.NIGHT_VISION, 100));
		return new ActionResult(EnumActionResult.SUCCESS, item);
	} else if (!item.getTagCompound().getBoolean("active")) {
		item.getTagCompound().setBoolean("active", false);
		player.removePotionEffect(MobEffects.NIGHT_VISION);
		return new ActionResult(EnumActionResult.SUCCESS, item);
	}
	return new ActionResult(EnumActionResult.FAIL, item);
}

 

https://github.com/Zerahi/RavenousVoid/blob/master/src/main/java/com/ravvoid/items/AwakenedVoidOrb.java

 

[Animefan8888]

Are you crafting it or spawning it in?

[Zerahi]

just staring at the same code too long, that makes sense added a !item.hasTagCompound() check to the update tick and did the setup in their works great now

[Animefan8888]

You mean you moved the stuff in your onCreated to onUpdate?

[Zerahi]

yeah but it will only fire once cause any item of that type that doesn't have a tag will get one on the first tick public void onUpdate(ItemStack item, World

 

world, Entity player, int itemSlot, boolean isSelected) {
	if (!item.hasTagCompound()) {
		item.setTagCompound(new NBTTagCompound());
		    this.setDamage(item, 2000);
		    item.getTagCompound().setInteger("power", 2000);
		    item.getTagCompound().setBoolean("active", false);
	}

 

and i use on update for other things so not like its not ticking anway

[Animefan8888]

Yup that is the way to do it :3 have fun modding.