[1.7.10] Custom dimension crashing on loading WorldProvider

[crafter6789]

First modding troubles, but am not total coding newbie.

 

When I start up the game in eclipse, I keep crashing when it tries to load my custom dimension stuff.

I have looked up tutorials on making custom dimensions, but could not find anything relevant to this situation.

 

Here's the link to source code and full crash logs:https://github.com/crafter6789/loztwiprincess

 

From what I gather, something isn't going right with the WorldProvider and/or WorldProvider ID and/or Dimension ID being registered, but I can't understand what.

 

Crash report:

[17:54:59] [Client thread/INFO] [sTDOUT]: ---- Minecraft Crash Report ----
// But it works on my machine.

Time: 8/9/16 5:54 PM
Description: Initializing game

java.lang.IllegalArgumentException: Failed to register dimension for id 128, provider type 128 does not exist
at net.minecraftforge.common.DimensionManager.registerDimension(DimensionManager.java:114)
at com.crafter6789.loztwiprincess.world.dimension.DimensionRegistry.registerDimensions(DimensionRegistry.java:16)
at com.crafter6789.loztwiprincess.main.MainRegistry.load(MainRegistry.java:55)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)
at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)
at cpw.mods.fml.common.Loader.initializeMods(Loader.java:737)
at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311)
at net.minecraft.client.Minecraft.startGame(Minecraft.java:597)
at net.minecraft.client.Minecraft.run(Minecraft.java:942)
at net.minecraft.client.main.Main.main(Main.java:164)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
at net.minecraftforge.common.DimensionManager.registerDimension(DimensionManager.java:114)
at com.crafter6789.loztwiprincess.world.dimension.DimensionRegistry.registerDimensions(DimensionRegistry.java:16)
at com.crafter6789.loztwiprincess.main.MainRegistry.load(MainRegistry.java:55)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)
at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)
at cpw.mods.fml.common.Loader.initializeMods(Loader.java:737)
at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311)
at net.minecraft.client.Minecraft.startGame(Minecraft.java:597)

-- Initialization --
Details:
Stacktrace:
at net.minecraft.client.Minecraft.run(Minecraft.java:942)
at net.minecraft.client.main.Main.main(Main.java:164)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)

-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_101, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 689148912 bytes (657 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1558 4 mods loaded, 4 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHI	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) 
UCHI	FML{7.10.99.99} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.4.1558-1.7.10.jar) 
UCHI	Forge{10.13.4.1558} [Minecraft Forge] (forgeSrc-1.7.10-10.13.4.1558-1.7.10.jar) 
UCHE	loztwiprincess{0.1.3-pre} [Legend of Zelda Twilight Princess Mod] (bin) 
GL info: ' Vendor: 'ATI Technologies Inc.' Version: '4.5.13399 Compatibility Profile Context 15.200.1060.0' Renderer: 'AMD Radeon R6'
Launched Version: 1.7.10
LWJGL: 2.9.1
OpenGL: AMD Radeon R6 GL version 4.5.13399 Compatibility Profile Context 15.200.1060.0, ATI Technologies Inc.
GL Caps: Using GL 1.3 multitexturing.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Anisotropic filtering is supported and maximum anisotropy is 16.
Shaders are available because OpenGL 2.1 is supported.

Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: []
Current Language: English (US)
Profiler Position: N/A (disabled)
Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Anisotropic Filtering: Off (1)

 

Thanks for any help whatsoever, and suggestions are much appreciated!

[Animefan8888]

You also need to register the WorldProvider.

[crafter6789]

I had thought I had done that, in the MainRegistry:

 

@EventHandler
public static void load(FMLInitializationEvent event){
	//DimensionRegistry.mainRegistry();
	DimensionRegistry.registerDimensions();
	DimensionRegistry.registerWorldProvider();

}

 

The mainRegistry (currently not called implicitly) calls registerDimensions and registerWorldProvider in the reverse order, and I've still crashed that way.

[Animefan8888]

Did the crash change?

[crafter6789]

No, no change at all.

Which means that loading order didn't affect the crash reason.

[Animefan8888]

Post all of the registry code.

[crafter6789]

I think this is what you mean, correct me if I am wrong:

package com.crafter6789.loztwiprincess.world.dimension;

import com.crafter6789.loztwiprincess.lib.RefStrings;

import net.minecraft.world.WorldProvider;
import net.minecraftforge.common.DimensionManager;

public class DimensionRegistry {

public static void mainRegistry(){
	registerWorldProvider();
	registerDimensions();
}

public static void registerDimensions(){
	DimensionManager.registerDimension(RefStrings.dimensionId, RefStrings.dimensionId);
}

public static void registerWorldProvider(){
	//DimensionManager.registerProviderType(RefStrings.dimensionId, WorldProviderTwilightPrincess.class, false);
	DimensionManager.registerProviderType(RefStrings.dimensionId, WorldProviderTwilightPrincess.class, true);
}

}

As said in the initial post, source is publicly available on github.

(For after thread is resolved: source will be updated to a working build.)

[Animefan8888]

World provider needs to be registered first. Do you ever call DimensionRegistry.mainRegistry();

[crafter6789]

Yes, I do, but switched the order in an attempt to debug. Both ways crash the same.

[Animefan8888]

Try doing the registry in the PreLoad method.

[crafter6789]

Done that, same crash, but tinkering with the order of pre-load events.

[Animefan8888]

Could you push to github so I can see every new thing.

[crafter6789]

Actually, I just fixed the problem, but now it crashes when I load a world (singleplayer).

This report is under loztwiprincess/crash logs/crash 2.txt (on GitHub)

(more reference: source and crash reports are here:https://github.com/crafter6789/loztwiprincess)

[Animefan8888]

You commented out your constuctor in your WorldProvider.

 

*Edit your WorldProvider class is abstract therefore it can't be instantiated.

[crafter6789]

Oh, I must have done that because eclipse gives me an error "Cannot override the final method from WorldProvider" when I try to use it.

 

On removing the comment-encloser thingies, I get crash 3.txt

[Animefan8888]

You don't even have a constructor class is abstract if you didn't see my  last post.

[crafter6789]

Sorry, musta' missed it by a few seconds.

So, if you don't mind my asking, how would I fix that? Would I have to make it a "regular" method and call it somehow else?

[Animefan8888]

Never mind about the constructor WorldProvider doesn't require one lol.

But just remove the abstract modifier when you declare the class.

[crafter6789]

Oh, didn't see that

But..............another crash...

saved as "crash 4.txt"

[Animefan8888]

Something is null in your chunk manager

[crafter6789]

I found something that was referenced in the chunk manager itself,

 

public WorldChunkManagerTwilightPrincess(long seed, WorldType worldType)
{
	this();
	GenLayer[] agenlayer = HyruleFieldGenLayerBiome.makeTheWorld(seed, worldType);
	agenlayer = getModdedBiomeGenerators(worldType, seed, agenlayer);
	this.genBiomes = agenlayer[0];
	this.biomeIndexLayer = agenlayer[1];
}

which calls HyruleFieldGenLayerBiome.makeTheWorld

public static GenLayer[] makeTheWorld(long seed, WorldType worldType) {
	// TODO Auto-generated method stub
	return null;
}

and that returns null, but I couldn't see anything in the ChunkManager itself

[Animefan8888]

In the log it says line 85

[MCrafterzz]

1.7.10!!! Update to 1.10.2

[crafter6789]

I have a reason for this mod to be in 1.7.10: other mods haven't updated.

 

I tried this and changed lines 38 and 85 specifically, no luck.

previously, they read

38        public WorldChunkManager worldChunkMgr;
.
.
.
85        this.worldChunkMgr = terrainType.getChunkManager(worldObj);

[Animefan8888]

Is terrainType ever initialized?