Jump to content

Recommended Posts

Posted

I'm still new to modding, so sorry if this is a stupid question.

I want to drop a new item when I right click with a tool. I think you do that with spawnEntityInWorld if I figured that out correctly.

But if I do that I get the item, but it has no texture. Apparently it doesn't get initialized correctly. What do I have to do instead?

 

@Override
    public ActionResult<ItemStack> onItemRightClick(ItemStack stack, World world, EntityPlayer playerIn, EnumHand hand) {
        world.spawnEntityInWorld( new EntityItem( world, playerIn.posX, playerIn.posY, playerIn.posZ, new ItemStack( new ItemTest() ) ) );
        return new ActionResult<>(EnumActionResult.SUCCESS, stack);
    }

Posted

Nevermind I figured it out. Instead of new ItemSaddle() for example I need to use Items.SADDLE. Makes sense.

But then I noticed that it spawns 2 copies of that item, one of which is not really there. I fixed it with if( !world.isRemote ), but I'm not sure if that's correct. Shouldn't the server know about that item?

Posted

I fixed it with if( !world.isRemote ), but I'm not sure if that's correct. Shouldn't the server know about that item?

If anything, you should only spawn it if !world.isRemote (if not client) or return if world.isRemote (if client) so that the entityItem is only spawned server-side.

If you "fixed" it by making the ghost item vanish, then you removed the client-side spawned one.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted

You will need an entity class, entity model class, entity render class, item class, and item model for the entity.

(scratch the item class and item model if you are just looking to summon/spawn it)

 

(I recommend techne and mcrayfish model maker)

 

Here is an examplemod src of what I'm talking about, So you can clearly see what needs to be done, It has one entity that is also a wieldable item that can be thrown:

https://www.dropbox.com/s/npqsjfyga587vyq/examplemodsrc.7z?dl=0

 

(I wrote this for 1.10.2 using java 8.)

 

My guess would be to make an item like a stick and when you right clicked spawn a new entity in the world similar to how you would create a new explosion.

Posted

You will need an entity class, entity model class, entity render class, item class, and item model for the entity.

(scratch the item class and item model if you are just looking to summon/spawn it)

 

For this (dropping an item), no you do not.  You've told like three people now that they need a custom entity and in all three cases you have been flat wrong.  Stop doing this.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

You will need an entity class, entity model class, entity render class, item class, and item model for the entity.

(scratch the item class and item model if you are just looking to summon/spawn it)

 

For this (dropping an item), no you do not.  You've told like three people now that they need a custom entity and in all three cases you have been flat wrong.  Stop doing this.

 

Why wouldn't you create your own? Its not clearly stated if its "custom" or not. Since there is problems with the textures i figured it was not a vanilla entity he/she was looking to spawn. (I may be wrong though)

In which case they would already have a custom entity but may not be registering it right, or may not have a render model. Or be rendering the wrong model, or have an incorrect texture.

 

You could spawn an entity that's already in game though you're right.

 

And the previous posts you were talking about:

Fireworks entity is an entity, and the topic i posted on was for a custom fireworksrocket entity.

The 2nd I suggested a possibility of an invisible/x entity. That you could put on blocks.

Posted

Why wouldn't you create your own? Its not clearly stated if its "custom" or not. Since there is problems with the textures i figured it was not a vanilla entity he/she was looking to spawn. (I may be wrong though)

In which case they would already have a custom entity but may not be registering it right, or may not have a render model. Or be rendering the wrong model, or have an incorrect texture.

 

If an item has the wrong texture (e.g. missing) there is a problem with the item's JSON model or with its registration, there is nothing wrong with Vanilla's EntityItem class.

 

There is no reason to create a custom EntityItem class unless you need to override certain EntityItem behavior.

 

Please stop suggesting a complicated solution to a simple problem.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Why wouldn't you create your own? Its not clearly stated if its "custom" or not. Since there is problems with the textures i figured it was not a vanilla entity he/she was looking to spawn. (I may be wrong though)

In which case they would already have a custom entity but may not be registering it right, or may not have a render model. Or be rendering the wrong model, or have an incorrect texture.

 

If an item has the wrong texture (e.g. missing) there is a problem with the item's JSON model or with its registration, there is nothing wrong with Vanilla's EntityItem class.

 

There is no reason to create a custom EntityItem class unless you need to override certain EntityItem behavior.

 

Please stop suggesting a complicated solution to a simple problem.

 

You are repeating what I stated.

"(scratch the item class and item model if you are just looking to summon/spawn it)"

Posted

In which case:

 

Stop suggesting custom entities for simple problems.  It is the wrong solution.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

In which case:

 

Stop suggesting custom entities for simple problems.  It is the wrong solution.

 

No, YOU, are the wrong solution.

 

lol... I just had to...

getting off here now. Have a goodn'

Posted

I tried to drop vanilla items as well and they had a missing texture too, but the problem is solved as described above. Initializing objects after the register phase seems like a bad idea, I got it.

@Matryoshika: Yeah, that was what I was confused about. I fixed it, but it didn't make sense to me. I know now that I got the meaning of isRemote mixed up because I'm not a native speaker. I thought isRemote==true means Server side, but it's vice versa, right? This means now that if( !world.isRemote ) is the correct thing to check for server side and this is how I accidently fixed it. Not sure what you mean with "if not client" though. Doesn't !world.isRemote already check for server side only?

Posted
... if !world.isRemote (if not client) or return if world.isRemote (if client)...

Not sure what you mean with "if not client" though. Doesn't !world.isRemote already check for server side only?

First, I merely described what each check does.

However, there are two ways of fixing the issue: 1) Nest code inside if-statement that checks if it is run on the server

if(!world.isRemote){
    //do stuff serverside
}

 

or 2) have your code do nothing client-side.

if(world.isRemote)
    return;

//do stuff serverside

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.