Jump to content

Enchantment Shine


Recommended Posts

I have two feature requests:

1) The ability to have an item return a custom color for the enchantment glow, taking the itemstack as a parameter

2) The ability to put the enchantment glow on blocks (for inventory and entity and held, not placed)

I have some prototype code for this that I can work on making into a forge pull request, but I am unsure of how to make sure I follow all the conventions.

If I should submit my code, then how should I let the item set the color? Should I have it call GL11.setColorf or should it return an int or somesuch?

Thank you,

Sound Logic

Link to comment
Share on other sites

I currently am using an IItemRenderer, but my objection is that it requires rewriting the entire item rendering sequence, doesn't permit any good way to interact with any other custom item rendering behaviors, and on the whole seems a bit much for a single color parameter. I am also working on putting the enchantment glow code in an itemblock renderer, but this seems like something other people could take advantage of.

As I said, I can try to make a forge pull request if I could be told how it would be recommended that the color be communicated

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.