Jump to content

[Solved] Check if player has achievement


Dijkstra
 Share

Recommended Posts

In the crafted item event i get and player and item and there is method on the player that I can run called hasAchievement, but looking into that it always returns false, in single player, looked in to how entity player mp does and came up with this

 

!Minecraft.getMinecraft().getIntegratedServer().getPlayerList().getPlayerStatsFile(player).hasAchievementUnlocked(achievement)

 

works in singles player but crashes the client on a server

 

Full method

 

private void checkAchivment(Achievement achievement, ItemStack item, ItemStack item1, ItemStack item2,  EntityPlayer player){
        Logging.info("Checking...");
        if(item1.getItem().equals(item2.getItem())){
            Logging.info("Items Match");
            if(Minecraft.getMinecraft().isIntegratedServerRunning()){
                Logging.info("I am single player");
                if(!Minecraft.getMinecraft().getIntegratedServer().getPlayerList().getPlayerStatsFile(player).hasAchievementUnlocked(achievement)){
                    //do stuff                }
            }
            else {
                Logging.info("I am a server");
                if(!player.hasAchievement(achievement)){
                    //do stuff 
                }
            }

        }
    }

 

 

I am not happy was this part of the method and fell there should be better way of checking if the player has an achievement also

if(Minecraft.getMinecraft().isIntegratedServerRunning()){
                Logging.info("I am single player");
                if(!Minecraft.getMinecraft().getIntegratedServer().getPlayerList().getPlayerStatsFile(player).hasAchievementUnlocked(achievement)){
                    //do stuff                }
            }
            else {
                Logging.info("I am a server");
                if(!player.hasAchievement(achievement)){
                    //do stuff 
                }
            }

Edit:

Working method for give a reward with an achievement:

https://gist.github.com/Dijkstra1/30eb97f26aacfd3a1af3258f9a37f2e3

Link to comment
Share on other sites

!Minecraft.getMinecraft().getIntegratedServer().getPlayerList().getPlayerStatsFile(player).hasAchievementUnlocked(achievement)

 

You can also check if an achievement is unlocked like so, which is how the achievements page fetches the info:

 

Minecraft.getMinecraft().thePlayer.getStatFileWriter().hasAchievementUnlocked(achievement)

Link to comment
Share on other sites

Why call hasAchievement, in single player i always get false, do not know if i am meant to target the method at the integrated server as before my method was like this and do stuff was always being called even after getting the achievement.

private void checkAchivment(Achievement achievement, ItemStack item, ItemStack item1, ItemStack item2,  EntityPlayer player){
        Logging.info("Checking...");
        if(item1.getItem().equals(item2.getItem())){
            Logging.info("Items Match");               
           if(!player.hasachievement(achievement)){
                    //do stuff 
            }
        }
    }

 

P.S. Thanks TheMasterGabriel that looks like it should work on both sides

Link to comment
Share on other sites

@SubscribeEvent
    public void onCraft(PlayerEvent.ItemCraftedEvent e){
        Logging.info("Item CRafted");
        checkAchivment(achievments[0], new ItemStack(Blocks.DIRT, 2), new ItemStack(Blocks.DIAMOND_BLOCK), e.crafting, e.player);
    }

Link to comment
Share on other sites

new ItemStack(Blocks.DIRT, 2), new ItemStack(Blocks.DIAMOND_BLOCK)

if(item1.getItem().equals(item2.getItem())){

 

Gosh.  I wonder why this doesn't return true.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Read again, you misread ;)

 

Ah, you're right.  That's what the OP gets for using useless variable names like "item" "item1" and "item2"

FFS, name those something intelligent.  If you're going to number them at least make them "1" "2" and "3"!

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I got something that works!, Draco18s hope the method parameters are more to your liking, I do not know if there is any way to make this more efficient, if there is I would be more than happy to find out.

 

private void checkAchivment(Achievement achievement, ItemStack item, EntityPlayer player) {
        if (!player.worldObj.isRemote && player instanceof EntityPlayerMP && achievement instanceof ModdedAchievement) {
            EntityPlayerMP playerMP = ((EntityPlayerMP) player);
            StatisticsManagerServer file = playerMP.getStatFile();

            if (!file.hasAchievementUnlocked(achievement) && file.canUnlockAchievement(achievement)) {
                ModdedAchievement moddedAchievement = ((ModdedAchievement) achievement);
                if (moddedAchievement.getTarget().getItem().equals(item.getItem())) {
                    if(moddedAchievement.getReward() != null){
                        ItemStack rewrad = moddedAchievement.getReward();
                        if (!player.inventory.addItemStackToInventory(rewrad)) {
                            playerMP.worldObj.spawnEntityInWorld(new EntityItem(playerMP.worldObj, playerMP.posX, playerMP.posY, playerMP.posZ, rewrad));
                        }
                    }
                    playerMP.addStat(achievement);
                }
            }
        }


    }

diesieben07 for my how are my achievements  initialized

 

public class ModdedAchievement extends Achievement {

    private static AchievementPage moddedAchievements;

    public static final Achievement[] achievments = new Achievement[]{
            new ModdedAchievement("blockDiamond", 0, 0, Blocks.DIAMOND_BLOCK, null, itemStack(Blocks.DIRT, 2).copy(), itemStack(Blocks.DIAMOND_BLOCK))
    };

    public static void init(){
        moddedAchievements =  new AchievementPage(MOD_NAME, achievments);
        AchievementPage.registerAchievementPage(moddedAchievements);
    }

}

 

At the moment I have just the one test one that gives you reward of of 2 dirt for making a diamond block

 

Link to comment
Share on other sites

this is what the method getReward does

public ItemStack getReward() {
        return reward.copy();
    }

 

This is in my ModdedAchievement class, item stacks are set in the constructor

 

Is it fine having copying the item stack there

 

or should i do

public ItemStack getReward() {
        return reward;
    }

ItemStack rewrad = moddedAchievement.getReward().copy();

To me it does not seem to make much different

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I created an SOUL_JAR Item that has been registered for each mob like - mod:soul_jar_minecraft_cow etc.. but it all has different registry names, i have a model file name soul_jar.json and i want to know how to bind each of those items to this class (When mod iterates through all of vanilla mobs and registering items for them).   I didn't found any info about it because all of info is outdated, and forge docs is complicated asf (i wish there would be more examples) i also used AI but it showing me only outdated info, but theres some code where i registering my item and trying to bind it to model ->   public static void register(IEventBus eventBus){ ITEMS.register(eventBus); Set<ResourceLocation> entityKeyList = ForgeRegistries.ENTITY_TYPES.getKeys(); for (ResourceLocation k : entityKeyList) { EntityType<?> entityType = ForgeRegistries.ENTITY_TYPES.getValue(k); if (!entityType.getCategory().equals(MobCategory.MISC)) { RegistryObject<Item> SOUL_JAR = ITEMS.register("soul_jar" + '_' + k.toString().replace(':', '_').replace('.', '_'), () -> new JarItem(new Item.Properties().rarity(Rarity.RARE).tab(ModTabs.MAGICAL_OBSESSION_JARS), entityType)); if (Thread.currentThread().getThreadGroup() == SidedThreadGroups.CLIENT) { ItemModelShaper itemModelShaper = Minecraft.getInstance().getItemRenderer().getItemModelShaper(); itemModelShaper.register(SOUL_JAR.get().asItem(), new ModelResourceLocation("item.soul_jar", "inventory")); } } } } I also have more questions like how to iterate through all other mods mobs also, or render mob inside of a jar in inventory, but i will try to figure it out.
    • I looked into OctoEconomyAPI and saw that it was a JAR api for fabric. This means you have a fabric mod in your mods folder. I downloaded your mod folder and wasted 2 solid hours creating a Python script to try to find the faulty mod, and eventually just gave up. I suggest you create two installations with half or the mods in each, find which one doesn't launch, cut that one in half, and repeat until you find the fabric mod. Investigué OctoEconomyAPI y vi que era una API JAR para fabric. Esto significa que tienes un mod de Fabric en tu carpeta de mods. Descargué su carpeta de mods y desperdicié 2 horas completas creando un script de Python para tratar de encontrar el mod defectuoso, y finalmente me di por vencido. Le sugiero que cree dos instalaciones con la mitad o las modificaciones en cada una, encuentre cuál no se inicia, córtela por la mitad y repita hasta que encuentre la modificación Fabric.   (The Python script I made is here): (El script de Python que hice está aquí):  
    • I've got it to work now. Instead of using the texture manager I used the Render System:   RenderSystem.setShaderTexture(0, new ResourceLocation("mcaquests", "textures/item/questbook.png"));  
    • Hello ive been having the same issue over Curse Forge's auto modding or when i use manual modding. The error seems to be within either Oculus or Rubidium. Im using 1.19 with the latest 1.19 forge + 1.19 compatible Oculus and Rubidium. Just in case the versions i am using; Oculus - oculus-1.4.3a Rubidium - rubidium-0.6.3 Note: I tried removing the two and add Optifine and it opens without a problem. I didnt use all 3 together to get this error im talking tho, i know they are not compatible with optifine dont worry. Logs Debug The actual error code im getting on start-up is ''1'' and nothing else on the pop up box. I have tried finding the jar files on the internet and insert them on my own but that didnt go too far.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.