[1.10.2] Detect creative mode during AnvilUpdateEvent

[jeffryfisher]

The AnvilUpdateEvent does not have a getPlayer() method. Is there any way to detect that the anvil user is in C-mode?

 

Without a way to detect creative mode, I don't think it's possible to inject new behavior for a mod and still respect creative mode privilege (or invoke any other player-dependent behavior). Here's the critical statement from the AnvilUpdateEvent class: "If the event is not canceled, but the output is not null, it will set the output and not run vanilla behavior" (emphasis added).

 

That means that if my event handler sets anvil output, then the handler is on the hook (so to speak) to emulate all bypassed behavior. I'm stumped because the bypassed behavior includes some creative-mode privilege to which the event seems to be blind (or am I blind?).

 

If this is a gap in Forge design, should I post something elsewhere?

 

PS: onAnvilRepair, which does specify a player, is not an adequate replacement event. By the time it is called (picking up from an anvil output slot), it is far too late to control what enchantments should be allowed from books or how many levels the repair will cost.

[Animefan8888]

The AnvilUpdateEvent does not have a getPlayer() method. Is there any way to detect that the anvil user is in C-mode?

 

Without a way to detect creative mode, I don't think it's possible to inject new behavior for a mod and still respect creative mode privilege (or invoke any other player-dependent behavior). Here's the critical statement from the AnvilUpdateEvent class: "If the event is not canceled, but the output is not null, it will set the output and not run vanilla behavior" (emphasis added).

 

That means that if my event handler sets anvil output, then the handler is on the hook (so to speak) to emulate all bypassed behavior. I'm stumped because the bypassed behavior includes some creative-mode privilege to which the event seems to be blind (or am I blind?).

 

If this is a gap in Forge design, should I post something elsewhere?

 

PS: onAnvilRepair, which does specify a player, is not an adequate replacement event. By the time it is called (picking up from an anvil output slot), it is far too late to control what enchantments should be allowed from books or how many levels the repair will cost.

I believe by vanilla behavior it means looking for the repair recipe. There fore you do not need to have a player variable.

[jabelar]

In the meantime can you replace the vanilla anvil with a custom one, or can you intercept other events for player interaction with blocks to help you make an educated guess on who's working on the anvil?

[Animefan8888]

In the meantime can you replace the vanilla anvil with a custom one, or can you intercept other events for player interaction with blocks to help you make an educated guess on who's working on the anvil?

I feel as if my answer was kinda pushed to the side.... Maybe I should ask my question Why do you need the player? Are you trying to grab player information(capability data) or just to check creative mode? Or are you just going to check if Player is not creative then change the data. Because as I said vanilla behavior most likely means grab recipe for anvil.

[jeffryfisher]

I should clarify:

 

When my event handler decides to change the anvil output, the change will cause a large part of vanilla anvil behavior to be skipped. My handler, not wanting to change all that behavior, then needs to do everything that the vanilla method would have done.

 

Unfortunately, there are a couple of branches in that vanilla code that respect the player being in creative mode. Imitating those special cases is the only reason my handler needs any player data. A creative-mode boolean would suffice for my current mod, but I can imagine other mods where various player conditions could affect anvil behavior for that player.

 

As it stands, when my mod's custom enchantment is applied via anvil, a creative mode player will be subject to survival-mode cost and limits, and the repair might become impossible (which interferes with my testing).

 

I've never written a pull request. How much detail do I need to provide, and where do I submit it? BTW, this issue also came up during 1.8 about a year ago. I don't know if a request was made then.

 

[Animefan8888]

I should clarify:

 

When my event handler decides to change the anvil output, the change will cause a large part of vanilla anvil behavior to be skipped. My handler, not wanting to change all that behavior, then needs to do everything that the vanilla method would have done.

 

Unfortunately, there are a couple of branches in that vanilla code that respect the player being in creative mode. Imitating those special cases is the only reason my handler needs any player data. A creative-mode boolean would suffice for my current mod, but I can imagine other mods where various player conditions could affect anvil behavior for that player.

 

As it stands, when my mod's custom enchantment is applied via anvil, a creative mode player will be subject to survival-mode cost and limits, and the repair might become impossible (which interferes with my testing).

 

I've never written a pull request. How much detail do I need to provide, and where do I submit it? BTW, this issue also came up during 1.8 about a year ago. I don't know if a request was made then.

 

What is the behavior as im pretty sure that ContainerRepair/SlotRepair (i think that is a thing) handles the subtracting, though i do agree that the player should be passed. About the pull request i think you just need to specify what you are changing and provide the code.