[1.10.2] [Solved] Custom EntityHanging doesn't render on a server

[Palaster]

I am dealing with a custom entity that extends EntityHanging. But, no matter what I do with the renderer it doesn't show up on servers. I even went as far as to create a clone of the EntityItemFrame and RenderItemFrame and it still doesn't show up on server. I have registered both the entity and the renderer.

 

This is the original Entity: https://github.com/Vazkii/Charset/blob/1.10/src/main/java/pl/asie/charset/storage/locking/EntityLock.java

This is the original Render: https://github.com/Vazkii/Charset/blob/1.10/src/main/java/pl/asie/charset/storage/locking/RenderLock.java

 

Also, this is the actually code i am trying to help fix the issue associated with this.

[Draco18s]

Last I poked at EntityHanging, you couldn't meaningfully extend it, because all of the classes involved in figuring out which entity to spawn and how to render it were hardcoded with switch statements / ternary operators.

[jeffryfisher]

My custom paintings extended EntityPainting and went through all kinds of contortions (including writing my own renderer) in 1.7.10 and 1.8 to deal with the stupid final enum etc. There's at least one gotcha in the client-side message handling code where it checks explicitly for class==EntityPainting, so no instance-of will be rendered unless you defeat the check.

 

I am currently upgrading my mods to 1.10.2  and will get to my paintings this week. I'll let you know what I discover.

 

One thing I can tell you right away though: NOTHING renders on a server. ALL rendering is client-side only. You should do some reading and then start over on your design to avoid any attempt  to render on your server.

 

Here's the critical piece of my code to defeat client-side message handling in mc 1.8 (I'm looking at it, but even though I wrote it myself, I no longer understand it):

@SideOnly(Side.CLIENT)
public class classAltPaintingSpawnCallback implements Function<EntitySpawnMessage, Entity> {

  protected Field fieldStream;

  public classAltPaintingSpawnCallback() {      // This will be constructed in the init phase
    try {   // Crack open the message and enable access to dataStream via Field variable (reflection)
      this.fieldStream = EntitySpawnMessage.class.getDeclaredField ("dataStream");
      this.fieldStream.setAccessible (true);
    } catch (NoSuchFieldException e) {
      System.out.println ("ERROR (" + e.getMessage () + "): Field 'dataStream' does not exist in class EntitySpawnMessage. ");
    }
  }

  /**
   * Helper class with one function to parse message and call the correct entity constructor that returns an instance of my entity
   * class. Got all that? I wrote it, and it still makes my head hurt.
   *
   * Why does the message protocol delay reading my extra data until after entity construction? I may never know, but I do know that
   * it's there waiting for me, so I'm taking it by force. 
   */
  @Override
  public Entity apply(EntitySpawnMessage m) {
    WorldClient wc = FMLClientHandler.instance ().getWorldClient ();
    try {
      ByteBuf b = (ByteBuf) fieldStream.get (m);                // Steal the dataStream from message m
      int x = b.readInt ();                                     // world tile x (+ is East)
      int y = b.readInt ();                                     // world tile y (+ is Up)
      int z = b.readInt ();                                     // world tile z (+ is South)
      EnumFacing facing = EnumFacing.VALUES[b.readByte ()];     // Compass dir 0-6 is D, U, N, S, W, E
      int lot = b.readByte ();                                  // Texture number 0-15 taken from carpet color used to craft item
      String title = ByteBufUtils.readUTF8String (b);
      return new classAltPainting (wc, new BlockPos (x, y, z), facing, lot, title);
    } catch (ReflectiveOperationException e) {
      System.out.println ("ERROR: classAltPaintingSpawnCallback.apply() threw: " + e.getMessage ());
      return null;
    }
  }
}

[Palaster]

I know that rendering is only done on the client-side. When I said it didn't render on servers I meant that if a player is on a server and places it in the world it won't render for them or anyone else. But, it will render on singe-player.

[TheGreyGhost]

Hi

 

My guess is that you've messed up the registration of your entity on the server.  Perhaps you have registered in the client proxy instead of the common proxy?

 

If you spawn your entity and look at it, what do you see in single player vs multiplayer (on the F3 debug screen, I mean)?

 

-TGG

 

[jeffryfisher]

if a player is on a server and places it in the world it won't render for them or anyone else. But, it will render on single-player.

So it is actually placed, just not visible?

 

Look at my callback. Use it to set breakpoints. See what the client is doing in the vicinity of the EntitySpawnMessage hook.

[jeffryfisher]

@jeffry, looking at your code it seems like you have re-implemented IEntityAdditionalSpawnData in a very hacky way.

That sounds familiar. I think you're right. The OP might only need IEntityAdditionalSpawnData (my situation did not quite fit because I needed the data you see me extracting by force, i.e. reflection)

[Palaster]

@jeffry, looking at your code it seems like you have re-implemented IEntityAdditionalSpawnData in a very hacky way.

That sounds familiar. I think you're right. The OP might only need IEntityAdditionalSpawnData (my situation did not quite fit because I needed the data you see me extracting by force, i.e. reflection)

 

You are correct I got it working all I needed was to write an Enum to the entity using IEntityAdditionalSpawnData. Thank you for the help.