Jump to content

Wierd issue with registering ItemBlocks in 1.10


KeeganDeathman

Recommended Posts

Whilst updating, I created the code:

//preinit for(Block block : labstuffBlocks)
	{
		if(labstuffBlocks.indexOf(block) == labstuffItemBlocks.size())
		{
			ItemBlock item = new ItemBlock(block);
			item.setRegistryName(block.getRegistryName());
			labstuffItemBlocks.add(item);
			ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
		}
	}

	for(Item item : labstuffItems)
	{
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
	}

//init

for(Block block : labstuffBlocks)
		{
			if(block.getRegistryName() != null)
			{
				block.setUnlocalizedName(block.getRegistryName().toString());
				GameRegistry.register(block);
				Item item = labstuffItemBlocks.get(labstuffBlocks.indexOf(block));
				GameRegistry.register(item);
			}
		}
		for(Item item : labstuffItems)
		{
			item.setUnlocalizedName(item.getRegistryName().getResourcePath());
			if(item.getRegistryName() != null)
			GameRegistry.register(item);
		}

 

And am adding blocks back in(through commented out declarations) one at a time.

One block, say Manganese Ore, works great! Wonderful!

But adding in more, say Copper Ore and the Circuit Design Table, causes an issue.

First, Manganese Ore's itemblock is remapped to copper ore, leaving manganese ore and the table with no active itemblock model.

 

All three have model files, and the blocks themselves render fine.

What could cause this.

In the past, also, I have used a hash map to store the Block to ItemBlock mappings, but thought this could be causing a block to grab the itemblock one earlier than it should(it wasn't)

[shadow=gray,left][glow=red,2,300]KEEGAN[/glow][/shadow]

Link to comment
Share on other sites

Why did you create an ItemBlock map when you could just have a block map then when registering create the instance. Look at my block tutorial if you want i do something similar.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I access the itemblocks in other places as well.

 

there's a method already in place  for that isn't there

There is Item.getItemFromBlock(block)

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

And am adding blocks back in(through commented out declarations) one at a time.

One block, say Manganese Ore, works great! Wonderful!

But adding in more, say Copper Ore and the Circuit Design Table, causes an issue.

First, Manganese Ore's itemblock is remapped to copper ore...

Are you creating a new world after each addition?

 

Try stepping through your pre- and initialization methods in the debugger, paying attention to what's assigned where. Debugger stepping is much better than naked-eye code analysis for spotting run-time errors.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.