Custom Crop Crashes w/ Unknown Error Upon Planting.

[gmod622]

Hello!

 

So during creation of a plant, I ran into an error, upon right clicking tilled soil:

 

 

 

[09:37:40] [server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
at net.minecraft.item.ItemSeeds.getPlant(ItemSeeds.java:52) ~[itemSeeds.class:?]
at net.minecraft.block.Block.canSustainPlant(Block.java:1826) ~[block.class:?]
at net.minecraft.item.ItemSeeds.onItemUse(ItemSeeds.java:31) ~[itemSeeds.class:?]
at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:755) ~[ForgeHooks.class:?]
at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:158) ~[itemStack.class:?]
at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:509) ~[PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processRightClickBlock(NetHandlerPlayServer.java:706) ~[NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_101]
at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 5 more

 

 

 

Some of the lines leads me to believe its something to do about my seed. So here is my seed class:

 

 

 

package com.lambda.PlentifulMisc.main.block;

import com.lambda.PlentifulMisc.main.item.ModItems;

import net.minecraft.block.BlockCrops;
import net.minecraft.item.Item;

public class PMBlkCropWatermelon extends BlockCrops {

public PMBlkCropWatermelon() {
	setUnlocalizedName("pmcropwatermelon");
	setRegistryName("pmcropwatermelon");
}

@Override
protected Item getSeed() {
	return ModItems.watermelonSeed;
}

@Override
protected Item getCrop() {
	return ModItems.watermelon;
}

}

 

 

 

And here is where I'm Registering the item:

 

 

 

package com.lambda.PlentifulMisc.main.item;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class ModItems {

public static PMItemBase cheese;
public static PMItemBase watermelon;
public static ItemWatermelonSeed watermelonSeed;

public static void init() {
	cheese = register(new PMItemBase("pmcheese").setCreativeTab(CreativeTabs.FOOD));
	watermelonSeed = register(new ItemWatermelonSeed());
	watermelon = register(new PMItemBase("pmwatermelon").setCreativeTab(CreativeTabs.FOOD));
}

private static <T extends Item> T register(T item) {
	GameRegistry.register(item);

	if (item instanceof ItemModelProvider ) {
		((ItemModelProvider )item).registerItemModel(item);
	}

	return item;
}

}

 

 

 

My Main Class.

 

 

 

package com.lambda.PlentifulMisc.main;

import com.lambda.PlentifulMisc.main.block.ModBlocks;
import com.lambda.PlentifulMisc.main.info.PMReference;
import com.lambda.PlentifulMisc.main.item.ModItems;
import com.lambda.PlentifulMisc.main.item.PMItemBase;
import com.lambda.PlentifulMisc.main.tab.PMTab;
import com.lambda.PlentifulMisc.proxy.CommonProxy;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;

@Mod(modid = PMReference.MODID, version = PMReference.VERSION)
public class PlentifulMisc
{ 
@SidedProxy(serverSide = "com.lambda.PlentifulMisc.proxy.CommonProxy", clientSide = "com.lambda.PlentifulMisc.proxy.ClientProxy")
public static CommonProxy proxy;
@Mod.Instance(PMReference.MODID)

public static PlentifulMisc instance;
public static final PMTab creativeTab = new PMTab();



    @EventHandler
    public void preInit(FMLPreInitializationEvent event)
    {
	System.out.println("[Plentiful Misc] Plentiful Misc is loading!");
	System.out.println("[Plentiful Misc] Thanks for downloading!");

	System.out.println("[Plentiful Misc] Initializing Blocks!");
	ModBlocks.init();
	System.out.println("[Plentiful Misc] Initializing Items!");
	ModItems.init();


    }

    @EventHandler
    public void init(FMLInitializationEvent event)
    {
    }

@EventHandler
    public void postInit(FMLPostInitializationEvent event)
    {

    }
}

 

 

 

And finally, my Client Proxy:

 

 

 

package com.lambda.PlentifulMisc.proxy;

import com.lambda.PlentifulMisc.main.PlentifulMisc;
import com.lambda.PlentifulMisc.main.info.PMReference;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy extends CommonProxy {
@Override
public void registerItemRenderer(Item item, int meta, String id) {
	ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(PMReference.MODID + ":" + id, "inventory"));
}
}

 

 

 

[NOTE:] Yes, I understand that my code is very messy, uncommented, etc, this is just a test project.

 

Thanks.

[jeffryfisher]

So when you set a breakpoint at ItemSeeds.java:52 and re-ran in the debugger, what did you find? What's null there, and how could you make it not null before reaching that point?

[imacatlolol]

Make sure you're registering your crop block and seed item at the exact same time (as in, put their registration in the same file. I use a separate class for items and blocks that need to be registered together).

[Draco18s]

You can't register them at the exact same time: one will always goes first.

Stop passing references to constructors and instead alter the class files to point to your items/blocks lists.

[gmod622]

So when you set a breakpoint at ItemSeeds.java:52 and re-ran in the debugger, what did you find? What's null there, and how could you make it not null before reaching that point?

 

Seems like it doesn't like how its calculating which way its facing:

 

 

    public BlockPos offset(EnumFacing facing)
    {
        return this.offset(facing, 1);
    }

    /**
     * Offsets this BlockPos n blocks in the given direction
     */
    public BlockPos offset(EnumFacing facing, int n)
    {
        return n == 0 ? this : new BlockPos(this.getX() + facing.getFrontOffsetX() * n, this.getY() + facing.getFrontOffsetY() * n, this.getZ() + facing.getFrontOffsetZ() * n);
    }

 

 

 

These two functions is where the first null spits out; The code that I jumped inside of was:

        if (facing == EnumFacing.UP && playerIn.canPlayerEdit(pos.offset(facing), facing, stack) && state.getBlock().canSustainPlant(state, worldIn, pos, EnumFacing.UP, this) && worldIn.isAirBlock(pos.up()))

 

 

[jeffryfisher]

So... Which value there was null? You did hover over each, right? When you have located the null element, then you should be able to see where you forgot to set it.

[jabelar]

For crops, this usually happens when you construct / register the seed item before you construct / register the crop block. So you need to control the order they are constructed / registered.

 

But as JeffryFisher says you should practice your ability to debug this sort of thing yourself. Find the null pointer then think or trace back why the thing that is null is so at that point in the execution.

[Draco18s]

For crops, this usually happens when you construct / register the seed item before you construct / register the crop block. So you need to control the order they are constructed / registered.

 

Actually what usually happens is that they've set up their code in such a way that swapping the two results in a similar, but different, crash.  Because they're trying to pass the seed to the block constructor and the block to the seed constructor.

 

Not the case here (they posted the block class, which is not taking the seed as a parameter) but they didn't post the Item class, so who knows what it's doing.

[trollworkout]

I created a custom crop last night. In fact two. And both working fine!

 

You don't need to create a custom seed item. You need, however, to create a custom crop block because getSeed and getCrop needs to be overriden.

 

 

public class FennelCrop extends BlockCrops 
{
public FennelCrop() 
{
	super();
}

@Override
    protected Item getSeed()
    {
	return ModItems.FENNEL;
    }

@Override
    protected Item getCrop()
    {
        return ModItems.FENNEL;
    }

}

 

 

 

For seed you can use MC's own ItemSeed or even ItemSeedFood both will work.

 

In my ModItems I got this

 

 

public static final Item FENNEL = new ItemSeedFood(1, 0.3F, ModBlocks.CROP_FENNEL, Blocks.FARMLAND).setUnlocalizedName("fennel").setRegistryName("fennel").setCreativeTab(ModData.CREATIVE_TAB);

 

 

after which I register in preInit

 

Note that I used MC's own ItemSeedFood . This is fine because it has the crop, seed in the constructor. Minecraft's or is it Forge's own BlockCrop does not have a way to change crop and seed so you need to create a custom one so you can override the return stuff.

 

Note that in ModBlocks I have to register the crop.

 

And finally I have a ModelsHandler class where I register the models for item and for the crop block. I can show you that too. You HAVE to to id properly or else it will not show up. YOu need various models for each crop stage from 0 to 7 . You need a blockstate with age=0 ... age=7 pointing at the above block model. And for the item you just do it  the regular way like any other non specific MC item.

 

[gmod622]

I created a custom crop last night. In fact two. And both working fine!

 

You don't need to create a custom seed item. You need, however, to create a custom crop block because getSeed and getCrop needs to be overriden.

 

 

public class FennelCrop extends BlockCrops 
{
public FennelCrop() 
{
	super();
}

@Override
    protected Item getSeed()
    {
	return ModItems.FENNEL;
    }

@Override
    protected Item getCrop()
    {
        return ModItems.FENNEL;
    }

}

 

 

 

For seed you can use MC's own ItemSeed or even ItemSeedFood both will work.

 

In my ModItems I got this

 

 

public static final Item FENNEL = new ItemSeedFood(1, 0.3F, ModBlocks.CROP_FENNEL, Blocks.FARMLAND).setUnlocalizedName("fennel").setRegistryName("fennel").setCreativeTab(ModData.CREATIVE_TAB);

 

 

after which I register in preInit

 

Note that I used MC's own ItemSeedFood . This is fine because it has the crop, seed in the constructor. Minecraft's or is it Forge's own BlockCrop does not have a way to change crop and seed so you need to create a custom one so you can override the return stuff.

 

Note that in ModBlocks I have to register the crop.

 

And finally I have a ModelsHandler class where I register the models for item and for the crop block. I can show you that too. You HAVE to to id properly or else it will not show up. YOu need various models for each crop stage from 0 to 7 . You need a blockstate with age=0 ... age=7 pointing at the above block model. And for the item you just do it  the regular way like any other non specific MC item.

 

By ModelsHandler, do you mean just a JSON?

I'm pretty sure this JSON will work out for a crop, or is there something more I need?

 

 

 

{
    "forge_marker": 1,
    "defaults": {
        "model": "cross"
    },
    "variants": {
        "age": {
            "0": {
                "textures": {
                    "cross": "pm:blocks/watermelon/0"
                }
            },
            "1": {
                "textures": {
                    "cross": "pm:blocks/watermelon/1"
                }
            },
            "2": {
                "textures": {
                    "cross": "pm:blocks/watermelon/2"
                }
            },
            "3": {
                "textures": {
                    "cross": "pm:blocks/watermelon/3"
                }
            },
            "4": {
                "textures": {
                    "cross": "pm:blocks/watermelon/4"
                }
            },
            "5": {
                "textures": {
                    "cross": "pm:blocks/watermelon/5"
                }
            },
            "6": {
                "textures": {
                    "cross": "pm:blocks/watermelon/6"
                }
            },
            "7": {
                "textures": {
                    "cross": "pm:blocks/watermelon/7"
                }
            }
        }
    }
}

 

 

[trollworkout]

modelhandler is my own class name nothing to do with forge. I jsut call the class that registers all my models that.

 

feel free to have a look at my crop files  for ex wormwood crop

https://github.com/trollworkout/technorcery/blob/master/src/main/java/com/technorcery/blocks/WormwoodCrop.java

 

you can find the json and all the other stuff there

 

is FULLY functional tested and not only grows properly but also has a seed, and a crop drop and when you middle click on it in creative you get the wormwood seeds