[1.10.2] Command lag spike problem

[SteveKunG]

My mod has added command for checking mojang status. But when execute the command it make lag spike in game.

 

Command :

 

package stevekung.mods.indicatorutils.command;

 

import net.minecraft.client.Minecraft;

import net.minecraft.command.CommandBase;

import net.minecraft.command.CommandException;

import net.minecraft.command.ICommandSender;

import net.minecraft.server.MinecraftServer;

import stevekung.mods.indicatorutils.utils.JsonMessageUtils;

import stevekung.mods.indicatorutils.utils.MojangStatusChecker;

import stevekung.mods.indicatorutils.utils.MojangStatusChecker.ServerStatus;

 

public class CommandMojangStatusCheck extends CommandBase

{

    @Override

    public int getRequiredPermissionLevel()

    {

        return 0;

    }

 

    @Override

    public String getCommandUsage(ICommandSender sender)

    {

        return "/" + this.getCommandName();

    }

 

    @Override

    public String getCommandName()

    {

        return "mojangstatus";

    }

 

    @Override

    public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException

    {

        for (MojangStatusChecker statusChecker : MojangStatusChecker.values())

        {

            String service = statusChecker.getName();

            ServerStatus status = statusChecker.getStatus();

            Minecraft.getMinecraft().thePlayer.addChatMessage(JsonMessageUtils.json("\"text\":\"" + service + ": \",\"extra\":[{\"text\":\"" + status.getStatus() + "\",\"color\":\"" + status.getColor() + "\"}]"));

        }

    }

}

 

 

Mojang Status Checker :

Original code from : https://bukkit.org/threads/resource-check-if-a-mojang-server-is-online-offline.226634/

 

package stevekung.mods.indicatorutils.utils;

 

import java.io.BufferedReader;

import java.io.IOException;

import java.io.InputStreamReader;

import java.net.URL;

 

import com.google.gson.JsonElement;

import com.google.gson.JsonObject;

import com.google.gson.JsonParser;

 

import net.minecraft.util.text.TextFormatting;

 

public enum MojangStatusChecker

{

    MAIN_WEBSITE("Main Website", "minecraft.net"),

    SESSION_SERVER("Minecraft Session Server", "session.minecraft.net"),

    ACCOUNTS("Accounts Service", "account.mojang.com"),

    AUTHENTICATION("Authentication Service", "auth.mojang.com"),

    SKINS_SERVER("Skins Server", "skins.minecraft.net"),

    AUTHENTICATION_SERVER("Authentication Server", "authserver.mojang.com"),

    MOJANG_SESSION_SERVER("Mojang Session Server", "sessionserver.mojang.com"),

    MOJANG_API("Mojang API Service", "api.mojang.com"),

    TEXTURES("Textures Service", "textures.minecraft.net"),

    MOJANG_MAIN_WEBSITE("Mojang Main Website", "mojang.com");

 

    private String name;

    private String serviceURL;

 

    private MojangStatusChecker(String name, String serviceURL)

    {

        this.name = name;

        this.serviceURL = serviceURL;

    }

 

    public String getName()

    {

        return this.name;

    }

 

    public ServerStatus getStatus()

    {

        try

        {

            URL url = new URL("http://status.mojang.com/check?service=" + this.serviceURL);

            BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(url.openStream()));

            JsonObject jsonObject = (JsonObject) new JsonParser().parse(bufferedReader);

            JsonElement status = jsonObject.get(this.serviceURL);

            return ServerStatus.get(status.getAsString());

        }

        catch (IOException e)

        {

            return ServerStatus.UNKNOWN;

        }

    }

 

    public enum ServerStatus

    {

        ONLINE("Online", TextFormatting.GREEN.getFriendlyName()),

        UNSTABLE("Unstable", TextFormatting.YELLOW.getFriendlyName()),

        OFFLINE("Offline", TextFormatting.DARK_RED.getFriendlyName()),

        UNKNOWN("Unknown", TextFormatting.RED.getFriendlyName());

 

        private String status;

        private String color;

 

        ServerStatus(String status, String color)

        {

            this.status = status;

            this.color = color;

        }

 

        public String getStatus()

        {

            return this.status;

        }

 

        public String getColor()

        {

            return this.color;

        }

 

        public static ServerStatus get(String status)

        {

            if (status.equals("green"))

            {

                return ServerStatus.ONLINE;

            }

            else if (status.equals("yellow"))

            {

                return ServerStatus.UNSTABLE;

            }

            else if (status.equals("red"))

            {

                return ServerStatus.OFFLINE;

            }

            else

            {

                return ServerStatus.UNKNOWN;

            }

        }

    }

}

 

[lukas2005]

does it print something on a chat after this lag or it freezes for ever?

[SteveKunG]

When execute this command it make lag for a short. Not freeze the game.

[SteveKunG]

OK. I have learn something about thread. And my FPS get stable.

Thanks!

 

Here is my simple thread code.

 

/*******************************************************************************

* Copyright 2016 Wasinthorn Suksri/SteveKunG - Indicator Utils

*

* This work is licensed under a Creative Commons Attribution-NonCommercial-NoDerivatives 4.0 International Public License.

* To view a copy of this license, visit http://creativecommons.org/licenses/by-nc-nd/4.0/.

******************************************************************************/

 

package stevekung.mods.indicatorutils.utils;

 

import net.minecraft.client.Minecraft;

import net.minecraftforge.fml.client.FMLClientHandler;

import net.minecraftforge.fml.relauncher.Side;

import stevekung.mods.indicatorutils.utils.MojangStatusChecker.ServerStatus;

 

public class ThreadMojangStatusCheck extends Thread

{

    private boolean startup;

 

    public ThreadMojangStatusCheck(boolean startup)

    {

        super("Mojang Status Check Thread");

        this.startup = startup;

    }

 

    @Override

    public void run()

    {

        if (FMLClientHandler.instance().getSide() == Side.CLIENT)

        {

            if (this.startup)

            {

                for (MojangStatusChecker statusChecker : MojangStatusChecker.values())

                {

                    String service = statusChecker.getName();

                    ServerStatus status = statusChecker.getStatus();

                    IULog.info(statusChecker.getName() + status.getStatus());

                }

            }

            else

            {

                for (MojangStatusChecker statusChecker : MojangStatusChecker.values())

                {

                    String service = statusChecker.getName();

                    ServerStatus status = statusChecker.getStatus();

                    Minecraft.getMinecraft().thePlayer.addChatMessage(JsonMessageUtils.json("\"text\":\"" + service + ": \",\"extra\":[{\"text\":\"" + status.getStatus() + "\",\"color\":\"" + status.getColor() + "\"}]"));

                }

            }

        }

    }

}

 

[lukas2005]

OK. I have learn something about thread. And my FPS get stable.

Thanks!

 

Here is my simple thread code.

 

/*******************************************************************************

* Copyright 2016 Wasinthorn Suksri/SteveKunG - Indicator Utils

*

* This work is licensed under a Creative Commons Attribution-NonCommercial-NoDerivatives 4.0 International Public License.

* To view a copy of this license, visit http://creativecommons.org/licenses/by-nc-nd/4.0/.

******************************************************************************/

 

package stevekung.mods.indicatorutils.utils;

 

import net.minecraft.client.Minecraft;

import net.minecraftforge.fml.client.FMLClientHandler;

import net.minecraftforge.fml.relauncher.Side;

import stevekung.mods.indicatorutils.utils.MojangStatusChecker.ServerStatus;

 

public class ThreadMojangStatusCheck extends Thread

{

    private boolean startup;

 

    public ThreadMojangStatusCheck(boolean startup)

    {

        super("Mojang Status Check Thread");

        this.startup = startup;

    }

 

    @Override

    public void run()

    {

        if (FMLClientHandler.instance().getSide() == Side.CLIENT)

        {

            if (this.startup)

            {

                for (MojangStatusChecker statusChecker : MojangStatusChecker.values())

                {

                    String service = statusChecker.getName();

                    ServerStatus status = statusChecker.getStatus();

                    IULog.info(statusChecker.getName() + status.getStatus());

                }

            }

            else

            {

                for (MojangStatusChecker statusChecker : MojangStatusChecker.values())

                {

                    String service = statusChecker.getName();

                    ServerStatus status = statusChecker.getStatus();

                    Minecraft.getMinecraft().thePlayer.addChatMessage(JsonMessageUtils.json("\"text\":\"" + service + ": \",\"extra\":[{\"text\":\"" + status.getStatus() + "\",\"color\":\"" + status.getColor() + "\"}]"));

                }

            }

        }

    }

}

 

 

You shloud change this line:

Minecraft.getMinecraft().thePlayer.addChatMessage(JsonMessageUtils.json("\"text\":\"" + service + ": \",\"extra\":[{\"text\":\"" + status.getStatus() + "\",\"color\":\"" + status.getColor() + "\"}]"));

to

Minecraft.getMinecraft().thePlayer.getServerForPlayer().addScheduledTask(new Runnable()
{
  public void run() {
    Minecraft.getMinecraft().thePlayer.addChatMessage(JsonMessageUtils.json("\"text\":\"" + service + ": \",\"extra\":[{\"text\":\"" + status.getStatus() + "\",\"color\":\"" + status.getColor() + "\"}]"));
  }
});

you cant do this your way because you are on separate thread useful link:http://greyminecraftcoder.blogspot.com.au/2015/01/thread-safety-with-network-messages.html(about networking but it explains threads)

[larsgerrits]

Why are you generating your

ITextComponent

from JSON? Use the methods on

ITextComponent

to format it if you are generating it from code.