[SOLVED] Getting color for ItemStack in crafting

[yooksi]

After a lot of experimenting I've learned the basics of setting up item subtypes and making them display in different colours via ColorHandlers. This however does not work for items that are displayed in the crafting output field when crafting (they are displayed with their default non-coloured textures). The only way I know how to fix this is to make an item model and texture file for every colour I want (not to mention registering separate classes). This will bring a lot of redundant files, is there a way around this?

[larsgerrits]

Can you please explain further? What do you expect to get as a crafting result? And show relevant code, we need it to help.

[yooksi]

  On 10/22/2016 at 4:26 PM, larsgerrits said:

Can you please explain further? What do you expect to get as a crafting result? And show relevant code, we need it to help.

 

I want the ItemStack that is the result of the crafting (displayed in the crafting output slot) to be coloured, much the same way as it would be after it leaves the crafting output slot - via the use of

IItemColor#getColorFromItemstack

. The mentioned method works for all cases except when the item is residing in the crafting output slot, then a default texture is used (from metadata).

 

So let's say I've got a test item that has a model file and a custom texture all set up. I register a ColorHandler for it, and return

Color.RED

from

getColorFromItemstack

. The item is properly colored red in my inventory and in the creative tabs. Everything works fine until I decide to craft that item, in which case the item is displayed un-colored (using the default texture, without custom color applied to it) in the crafting output slot. When removed, the item is rendered normally again.

 

In order to fix this I would need to abandon the subtype system of handling this item and split it up into separate items (one for each color), each with it's own model and texture file. My question is, is there a way of forcing the item in the crafting output slot to be rendered with a color applied to it (just like we do with

getColorFromItemstack

) WITHOUT resorting to dedicating separate item classes, model and texture files? Hope I made more sense this time =)

[Choonster]

The colour returned by

IItemColor

is always used to render the item's model, regardless of where it is. You can see this by crafting a leather helmet with dye, the output item will be rendered with the appropriate colour.

 

Post your

Item

and

IItemColor

.

[Draco18s]

I suspect the problem is that the color is coming from NBT and he's using the onCrafted to apply the NBT, rather than in the recipe output declaration.

 

Or something similar.

[yooksi]

  On 10/22/2016 at 5:00 PM, Choonster said:

The colour returned by

IItemColor

is always used to render the item's model, regardless of where it is. You can see this by crafting a leather helmet with dye, the output item will be rendered with the appropriate colour.

 

Post your

Item

and

IItemColor

.

 

Ah, you are right. Now that I checked it again

getColorFromItemstack

does get properly called even when the item is in the crafting output grid. I must have been setting my debug breakpoints in wrong places, because I could have sworn it was never called.

 

However, my next problem is that because I store the colour values (or to be more precise dyeColor metadata values) in item NBT, I am unable to retrieve them when crafting because the item did not have a chance to initialize it's NBTTagCompound. I do the initialization when the ItemCraftedEvent is fired. I would like to do the initialization in getSubItems but unfortunately that is not called until after the item has been crafted (pulled out of the crafting output slot). Any idea on how I should handle this?

[yooksi]

  On 10/22/2016 at 5:07 PM, Draco18s said:

I suspect the problem is that the color is coming from NBT and he's using the onCrafted to apply the NBT, rather than in the recipe output declaration.

 

Or something similar.

 

Spot on, that's exactly what I am doing.

When should create a new NBTTagCompound for the item to make this work?

[Choonster]

  On 10/22/2016 at 5:17 PM, yooksi said:

  Quote

The colour returned by

IItemColor

is always used to render the item's model, regardless of where it is. You can see this by crafting a leather helmet with dye, the output item will be rendered with the appropriate colour.

 

Post your

Item

and

IItemColor

.

Ah, you are right. Now that I checked it again

getColorFromItemstack

does get properly called even when the item is in the crafting output grid. I must have been setting my debug breakpoints in wrong places, because I could have sworn it was never called.

 

However, my next problem is that because I store the colour values (or to be more precise dyeColor metadata values) in item NBT, I am unable to retrieve them when crafting because the item did not have a chance to initialize it's NBTTagCompound. I do the initialization when the ItemCraftedEvent is fired. I would like to do the initialization in getSubItems but unfortunately that is not called until after the item has been crafted (pulled out of the crafting output slot). Any idea on how I should handle this?

 

Set the NBT from

IRecipe#getCraftingResult

instead of

ItemCraftedEvent

.

 

Events should generally only be used when dealing with things from vanilla or other mods, overriding the appropriate method should be preferred.

[yooksi]

  On 10/22/2016 at 5:21 PM, Choonster said:

Set the NBT from

IRecipe#getCraftingResult

instead of

ItemCraftedEvent

.

 

Events should generally only be used when dealing with things from vanilla or other mods, overriding the appropriate method should be preferred.

 

I am guessing that I have to declare my recipe as an IRecipe and then make it override

IRecipe#getCraftingResult

, correct? If so, I don't know how to do this, any examples?

[Choonster]

  On 10/22/2016 at 5:29 PM, yooksi said:

  Quote

Set the NBT from

IRecipe#getCraftingResult

instead of

ItemCraftedEvent

.

 

Events should generally only be used when dealing with things from vanilla or other mods, overriding the appropriate method should be preferred.

 

I am guessing that I have to declare my recipe as an IRecipe and then make it override

IRecipe#getCraftingResult

, correct? If so, I don't know how to do this, any examples?

 

You'll probably want to create a class that extends an existing implementation of

IRecipe

like

ShapedOreRecipe

and then override

IRecipe#getCraftingResult

to call the super method, add the NBT and return the

ItemStack

.

 

Use

GameRegistry#addRecipe(IRecipe)

to add an instance of this recipe class.

[yooksi]

  On 10/22/2016 at 5:52 PM, Choonster said:

 

You'll probably want to create a class that extends an existing implementation of

IRecipe

like

ShapedOreRecipe

and then override

IRecipe#getCraftingResult

to call the super method, add the NBT and return the

ItemStack

.

 

Use

GameRegistry#addRecipe(IRecipe)

to add an instance of this recipe class.

 

After taking a look at

ShapedOreRecipe

and

RecipeFirework

, I realized that setting up this class manually is going to be a pain in the ass, and for some reason I don't feel comfortable extending

ShapedOreRecipe

out of pure convenience in the moment. If it gets changed and becomes incompatible with my recipes, I will have to rewrite them. Makes more sense to set it up manually, right?

 

EDIT: I figured out that

ShapedOreRecipe

is actually a Forge implemented class, and in order to have a custom recipe class I need to register it and all that. Think I will stick with the native Forge class for now.