MC1.10+ Custom bookshelf

[winnetrie]

I created bookshelfs for the other woodtypes. I have 1 problem!

When i break them they return 3 books wich is normal and that's also what i want them to do. So that's fine!

Yet they do drop as a book with metedata. You see them ingame as huge black/pink cubes.

How can i prevent this?

Here is the code :

 

  Reveal hidden contents

public class BlockModBookshelf extends BlockBookshelf implements IMetaBlockName{
public static final PropertyEnum TYPE = PropertyEnum.create("type", BlockModBookshelf.EnumType.class);
public BlockModBookshelf(){
	super();
        setHardness(1.50F);
        //setResistance(7F);
        setSoundType(SoundType.WOOD);
        this.setDefaultState(this.blockState.getBaseState().withProperty(TYPE, EnumType.SPRUCE));
        setUnlocalizedName(References.temBlocks.BOOKSHELF.getUnlocalizedName());
	setRegistryName(References.temBlocks.BOOKSHELF.getRegistryName());
	setCreativeTab(Tem.blockstab);


}

@Override
public float getEnchantPowerBonus(World world, BlockPos pos){
	Block block = world.getBlockState(pos).getBlock();
        return this == block || block instanceof BlockBookshelf ? 1 : 0;
    }

@Override
protected BlockStateContainer createBlockState() {
    return new BlockStateContainer(this, new IProperty[] { TYPE });
}
@Override
public IBlockState getStateFromMeta(int meta) {	
    return getDefaultState().withProperty(TYPE, EnumType.values()[meta]);
}

@Override
public int getMetaFromState(IBlockState state) {
    return ((Enum<EnumType>) state.getValue(TYPE)).ordinal();
}
@Override
public int damageDropped(IBlockState state) {
    return getMetaFromState(state);
}
@Override
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list) {
	for (EnumType t : EnumType.values())
    list.add(new ItemStack(itemIn, 1, t.ordinal()));  
}

@Override
public String getSpecialName(ItemStack stack) {
	return EnumType.values()[stack.getItemDamage()].name().toLowerCase();
}
@Override
public int quantityDropped(Random random)
    {
        return 3;
    }
    @Override
    @Nullable
    public Item getItemDropped(IBlockState state, Random rand, int fortune){
    	
        return Items.BOOK;
    }

public enum EnumType implements IStringSerializable{

	SPRUCE(0, "spruce"), BIRCH(1, "birch"), JUNGLE(2, "jungle"), ACACIA(3, "acacia"), DARKOAK(4,"darkoak");

    private int ID;
    private String name;
   
    private EnumType(int ID, String name) {
        this.ID = ID;
        this.name = name;
            
    }
    @Override
    public String getName() {
        return name;
    }
    public int getID() {
        return ID;
    }
    @Override
    public String toString() {
        return getName();
    }
}

}

 

 

this is the methis that return the metadata for the drop.

Removing this from the class solves it, but then in creative mode you don't get the right block if you

click with the middlemouse button.

@Override
public int damageDropped(IBlockState state) {
    return getMetaFromState(state);
}

 

[Choonster]

Remove the

Block#damageDropped

override and override

Block#getPickBlock

to return the appropriate

ItemStack

of your bookshelf.

[winnetrie]

  On 11/6/2016 at 3:02 AM, Choonster said:

Remove the

Block#damageDropped

override and override

Block#getPickBlock

to return the appropriate

ItemStack

of your bookshelf.

jup fixed it now:

@Override
public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
	Block block = world.getBlockState(pos).getBlock();
	int meta = ((Enum<EnumType>) world.getBlockState(pos).getValue(TYPE)).ordinal();
        return new ItemStack(block,1,meta);
}

This method comes standard with return getItem(world, pos, state)

But that's deprecated and doesn't work in this case.

So i came with this idea. What you think? Good or bad? It's working.

[Choonster]

There's no need to get the

IBlockState

from the world, you receive it as an argument.

 

You can also just use

this

as the

Block

instead of getting it from the

IBlockState

.

 

You should never need to cast the value returned by

IBlockState#getValue

, it should already return the appropriate type.

[winnetrie]

  On 11/6/2016 at 4:08 AM, Choonster said:

There's no need to get the

IBlockState

from the world, you receive it as an argument.

 

You can also just use

this

as the

Block

instead of getting it from the

IBlockState

.

 

You should never need to cast the value returned by

IBlockState#getValue

, it should already return the appropriate type.

I added a cast to it because eclipse tells me do to so. If i don't it it marked as "wrong".

i now changed my code to this:

@Override
public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
	Block block = state.getBlock();
	int meta = block.getMetaFromState(state);
        return new ItemStack(block,1,meta);
}

Strange i haven't seent his before but this looks a lot better now.

I also decided to get the meta from the state. Perhaps it makes more sense.