[1.10] Is it possible to detect a custom method and edit it?

[JackTheRedCreeper]

Kind of like when you edit a Minecraft vanilla method (such as explosions), but from another mod. Add some code or edit what's there.

 

I'm more interested in if it's possible, as a friend is having problems with his mod (I made custom explosions in mine and his mod is not detecting them) and we're lost on what to do.

 

If it's just necessary to have some code on the custom explosion side, that'd be good enough. However if it all can be done without extra explosion code, it would have more mod compatibility.

 

The idea is: My projectile causes a explosion (CustomExp), my friend's mod detects CustomExp and modifies it.

At the moment his mod only works with vanilla explosions because they're "pre-ofbuscated", to say so (you know where they are and what their name is already)

 

 

[abused_master]

Tell your friend to make an api and then link into that api

[Matryoshika]

How does he modify it?

Larger|smaller radius? Power?

Stops it?

 

Most likely, unless your friend is doing something major, he can simply subscribe to the

ExplosionEvent

and handle things from there. As long as any mod-dev makes his/her explosions fire this event as well (which they seriously should) then that is all that is needed.

[JackTheRedCreeper]

  On 11/6/2016 at 3:47 PM, abused_master said:

Tell your friend to make an api and then link into that api

 

We could do that, but it's not that important and we want the most compatible method possible.

 

  Quote

How does he modify it?

Larger|smaller radius? Power?

Stops it?

 

Most likely, unless your friend is doing something major, he can simply subscribe to the

ExplosionEvent

and handle things from there. As long as any mod-dev makes his/her explosions fire this event as well (which they seriously should) then that is all that is needed.

 

He's moving the explosion to other coords. Don't think it's too major.

 

I belive he can use this method because my custom explosion is just a few value changes (on radius and power)

 

Now to wait for him to get online...

[jeffryfisher]

  On 11/6/2016 at 3:02 PM, JackTheRedCreeper said:

Kind of like when you edit a Minecraft vanilla method...

That would be a core mod. This forum does not support core mods. You shouldn't edit vanilla methods. If you ever seriously needed a vanilla method to change, then you would submit a "pull request" to the Forge developers.

 

Likewise, you shouldn't edit the methods inside other mods (if that's even possible). Instead, comunicate with the mod's owner about supporting what you want to do.

 

Learn how to integrate your mod with Forge so that your mod can "play nice" with other mods. If you talk about core-modding or hacking others' mods, then maybe the forum moderators will explain things better than I have.

 

However, if all you want to do is to detect the existence of a method in a class, then use reflection. The post-init event handler is a good place to accomplish such inter-mod coordination. Once your code knows that a class and method exist, then you can (still using reflection) call the method to act on the class or objects thereof. Be careful with reflection; it's inefficient.

[JackTheRedCreeper]

  On 11/6/2016 at 5:09 PM, jeffryfisher said:

  Quote

Kind of like when you edit a Minecraft vanilla method...

That would be a core mod. This forum does not support core mods. You shouldn't edit vanilla methods. If you ever seriously needed a vanilla method to change, then you would submit a "pull request" to the Forge developers.

 

Likewise, you shouldn't edit the methods inside other mods (if that's even possible). Instead, comunicate with the mod's owner about supporting what you want to do.

 

Learn how to integrate your mod with Forge so that your mod can "play nice" with other mods. If you talk about core-modding or hacking others' mods, then maybe the forum moderators will explain things better than I have.

 

However, if all you want to do is to detect the existence of a method in a class, then use reflection. The post-init event handler is a good place to accomplish such inter-mod coordination. Once your code knows that a class and method exist, then you can (still using reflection) call the method to act on the class or objects thereof. Be careful with reflection; it's inefficient.

 

I mean something like an EventHandler (those are the ones used to replace Tnt properties for example, no?). His mod works perfectly but it doesn't detect custom explosions, which makes it finnicky.

We thought about "waht if I make CustomExplosion and you detect that?" but the problem is minecraft's ofbuscation.

I guess reflection is what we need because what my friend does is check for explosion, and if that explosion is in the world class. However, after doing those checks, he needs to change the explosion's location.

We'll try the ExplosionEvent first.

[Draco18s]

You would need to tell the person who wrote the custom explosions to add the explosion event.

[JackTheRedCreeper]

  On 11/6/2016 at 8:22 PM, Draco18s said:

You would need to tell the person who wrote the custom explosions to add the explosion event.

 

That's a good idea! So the thing now is to call the event cross-mods, huh..

[Draco18s]

Realistically any mod that does things like vanilla, but not and vanilla has an event, that mod should also fire that event in their custom whatever.

[JackTheRedCreeper]

  On 11/6/2016 at 11:33 PM, Draco18s said:

Realistically any mod that does things like vanilla, but not and vanilla has an event, that mod should also fire that event in their custom whatever.

 

Yeah, explosion event. My friend hasn't gotten online yet.

When he does and we test all of this, we'll tell you!

 

Amusingly my custom explosions work in dev environment because it's not ofbuscated, but hopefully ExplosionEvent isn't affected.

[Matryoshika]

  On 11/7/2016 at 10:21 AM, JackTheRedCreeper said:

Amusingly my custom explosions work in dev environment because it's not ofbuscated, but hopefully ExplosionEvent isn't affected.

What? If your friend is dealing with obfuscated jars, he is doing it all wrong.

When you build the jar, your code is obfuscated to be able to work properly with "real" (aka non-dev environment) Minecraft.

When building (since 1.8and later, I believe), you should by default get 2 jars inside the build/libs folder, [name].jar, and [name]-sources.jar. The "sources" indicates a non-obfuscated version of your mod, which other devs can use for cross-mod/addon interaction, etcetera.

[JackTheRedCreeper]

  On 11/7/2016 at 11:50 AM, Matryoshika said:

  Quote

Amusingly my custom explosions work in dev environment because it's not ofbuscated, but hopefully ExplosionEvent isn't affected.

What? If your friend is dealing with obfuscated jars, he is doing it all wrong.

When you build the jar, your code is obfuscated to be able to work properly with "real" (aka non-dev environment) Minecraft.

When building (since 1.8and later, I believe), you should by default get 2 jars inside the build/libs folder, [name].jar, and [name]-sources.jar. The "sources" indicates a non-obfuscated version of your mod, which other devs can use for cross-mod/addon interaction, etcetera.

Oh! That'd be more in my side. The problem he has is detecting a custom mod class, because of obfuscation.

Huh, but thing is, even if someone used "CustomExplosion", supposedly the class and such is all obfuscated, which makes it impossible to find.

I guess there's some method my friend doesn't know, hence this thread.

 

 

Edit (11-11): Still no response from my friend

 

[JackTheRedCreeper]

Ok, my friend finally got online. He says that he had to do it his own way so the items wouldn't be destroyed by the explosions. Any ideas on how to prevent explosions from destroying drops?