Adding fish to rod 1.10

[alexschopbarteld]

Quick question, how do i add my item to the fishingrod as a fish.

 

i used to do it with addfish and with the weighted method but since i updated to 1.10 the last one doenst seem to work anymore, ideas?

[Draco18s]

You may want to look at my helper class I use:

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/hardlib/util/LootUtils.java

[alexschopbarteld]

And  what function of that class do i use to make my item spawn in the gameplay.fishing.fish loot table? do i do that in the same class or a seperate one?

[alexschopbarteld]

public static void addItemToTable(ResourceLocation gameplayFishingFish, Item item, int weight, float numRolls, float probability, int minQuantity, int maxQuantity, float minLootBonus, float maxLootBonus, String name) {

addItemToTable(LootTableList.GAMEPLAY_FISHING_FISH, RunecraftItems.RawAnchovies, 0, 0, weight, minQuantity, maxQuantity, minLootBonus, maxLootBonus, name);

}

 

[Draco18s]

And  what function of that class do i use to make my item spawn in the gameplay.fishing.fish loot table? do i do that in the same class or a seperate one?

 

No, you subscribe to the LootTableLoadEvent, and when the gameplay.fishing.fish loot table is loaded, you get it's loot table and call addItemToTable(...) passing the appropriate arguments.

e.g.:

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/farming/FarmingEventHandler.java#L428

[alexschopbarteld]

 

@SubscribeEvent

public void lootTableLoad(LootTableLoadEvent event) {

LootCondition[] chance;

LootCondition[] lootingEnchant;

LootFunction[] count;

LootEntryItem[] item;

LootPool newPool;

if(event.getName().getResourcePath().equals("gameplay.fishing.fish")) {

LootTable loot = event.getTable();

AddlootHandler.addItemToTable(loot, RunecraftItems.RawAnchovies, 10000000, 2, 1, 3, 5, 0, 1, "RawAnchovies");

}

}

}

 

 

[Draco18s]

Ok?  What's your question/problem?

[alexschopbarteld]

Well, google told me that the weight is sort of a % of how common the item is i used the method i posted above and made the weight very high but it doesnt want to appear on the rod...

[Draco18s]

While that's what it's for I'm not sure it's actually used the way you think it is.  I know that for entities like cows, the weight is irrelevant because there's only one entry in the pool.

 

Let me look at fish for a minute.

 

Ah, ok.

 

So my LootUtils class is not constructed to properly handle adding items to the fishing tables because: I have them added as new pools and vanilla is going to ignore it.  Along with a few loot functions that aren't needed (unclear if having a stack other than size 1 is relevant, applicable, or allowed for fishing).

 

You'll want to get a reference to the LootPool named "main" (there's a

table#getPool(name)

method) and you'll want to insert a new LootEntry to it.