[1.10.2] Custom Crop Planting Crash

[THEGamingninja]

I'm having a bit of an Issue with Crops, whenever I try to place the seed It crashes the game

Here's my code.

 

Seed Item Class

package thegamingninja.moreutils.init;

import net.minecraft.block.Block;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemSeeds;
import thegamingninja.moreutils.Load;
import thegamingninja.moreutils.Reference;

public class ItemRegenSeed extends ItemSeeds {

public ItemRegenSeed(){
	super(ModCrops.regencrop, Blocks.FARMLAND);
	setUnlocalizedName("regen_seed");
	setRegistryName(Reference.MoreUtilItems.REGEN_SEED.getRegistryName());
	setCreativeTab(Load.CREATIVE_TAB);
 }
}

 

package thegamingninja.moreutils.init;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.fml.common.registry.GameRegistry;
import thegamingninja.moreutils.Reference;
import thegamingninja.moreutils.block.CropRegen;

public class ModCrops {

public static Block regencrop;

public static void init() {

	regencrop = new CropRegen();
}

public static void register() {
	registerBlock(regencrop);
}

public static void registerRenders() {
	registerRender(regencrop);

}

private static void registerBlock(Block block) {
	GameRegistry.register(block);
	ItemBlock item = new ItemBlock(block);
	item.setRegistryName(block.getRegistryName());
	GameRegistry.register(item);
}
private static void registerRender(Block block) {

	Item item = Item.getItemFromBlock(block);

	Minecraft.getMinecraft().getRenderItem().getItemModelMesher()
	.register(item, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + item.getUnlocalizedName() .substring(5), "inventory"));
}



}

 

Client Proxy Class

package thegamingninja.moreutils.proxy;

import thegamingninja.moreutils.init.ModBlocks;
import thegamingninja.moreutils.init.ModCrops;
import thegamingninja.moreutils.init.ModItems;

public class ClientProxy implements CommonProxy {

@Override
public void init() {
	ModItems.registerRenders();
	ModBlocks.registerRenders();
	ModCrops.registerRenders();
}

}

[Draco18s]

You register your items before your blocks, so you pass null to your item's constructor.

 

There's literally 4000 posts on this forum about this issue.

[THEGamingninja]

I changed It to this

package thegamingninja.moreutils.proxy;

import thegamingninja.moreutils.init.ModBlocks;
import thegamingninja.moreutils.init.ModCrops;
import thegamingninja.moreutils.init.ModItems;

public class ClientProxy implements CommonProxy {

@Override
public void init() {
	ModBlocks.registerRenders();
	ModItems.registerRenders();
	ModCrops.registerRenders();
}

}

 

Still have the same Issue.

[Draco18s]

Gosh.

What ever could the problem be?

 

This is one of the reasons one should use the new

RegistryEvent

s, to avoid problems like these.

 

Given that I've seen people (try to) pass the item to their block, and the block to their item...I'm not so sure.

 

You can't do that.

Your crop class must reference ModItems.seed directly, it cannot take it as a parameter to its constructor.

[THEGamingninja]

How would I use the new RegistryEvent? kinda to new to modding.

[Draco18s]

I haven't messed with them yet myself.  Here's how Lex does it:

https://github.com/LexManos/VoidUtils/blob/master/src/main/java/net/minecraftforge/lex/voidutils/VoidUtils.java#L96-L120

 

But the point remains:

 

Your crop class must reference ModItems.seed directly, it cannot take it as a parameter to its constructor.

[jeffryfisher]

If you want help with a (another) crash, make sure that you post the crash report.