[1.11] Structure lights not updating

[Kokkie]

Hello, I made a structure for in my dimension but the lights of it aren't updated when it spawns, how can I fix this?

Code:

public class WorldGenCheeseHouse2 extends WorldGenerator {

private static final BlockStateMatcher IS_STONE = BlockStateMatcher.forBlock(CheeseBlocks.CHEESE_STONE);
private final ResourceLocation HOUSE = new ResourceLocation(Reference.MODID + ":cheese_house");

public boolean generate(World worldIn, Random rand, BlockPos position) {
	while (worldIn.isAirBlock(position) && position.getY() > 2) {
		position = position.down();
	}
	if (!IS_STONE.apply(worldIn.getBlockState(position))) {
		return false;
	}
        Random random = worldIn.getChunkFromChunkCoords(position.getX(), position.getZ()).getRandomWithSeed(987234911L);
        Rotation[] arotation = Rotation.values();
        Rotation rotation = arotation[random.nextInt(arotation.length)];
        ChunkPos chunkpos = new ChunkPos(position);
        StructureBoundingBox structureboundingbox = new StructureBoundingBox(chunkpos.getXStart() - 16, 0, chunkpos.getZStart() - 16, chunkpos.getXEnd() + 16, 256, chunkpos.getZEnd() + 16);
        PlacementSettings placementsettings = (new PlacementSettings()).setRotation(rotation).setBoundingBox(structureboundingbox).setRandom(random);
        MinecraftServer minecraftserver = worldIn.getMinecraftServer();
	TemplateManager templatemanager = worldIn.getSaveHandler().getStructureTemplateManager();
        Template template = templatemanager.getTemplate(minecraftserver, HOUSE);
        template.addBlocksToWorld(worldIn, position, placementsettings, 20);
	return true;
}

}

Image: https://i.gyazo.com/3a9a3f8df4d5c9dffebf815899a130bf.png

[Kokkie]

Does it have something to do with template.addBlocksToWorld(worldIn, position, placementsettings, 20);?

[Kokkie]

bump

[Kokkie]

please?

[jabelar]

I'm not sure specifically about 1.11 but in previous versions you need to make sure that when you add the block to world that the lighting is updated. So you should check what your add block to world function is doing.

 

However, having lighting updated after every block placed can slow the generation of the structure, so maybe you should look for a way to update the chunk lighting once at the end of the structure generation.

 

 

[robustus]

I didnt get too deep into this but if the lights are spawned in the biome decoration they are fine if they are spawned earlier than that they wont update.

[Kokkie]

They are sometimes updated, sometimes not, didn't see patterns for rotation...

[Kokkie]

How can i update the lights of the chunk?

[Kokkie]

bump

[Kokkie]

bump

[Raycoms]

Did you try to mark the chunk as dirty?

[Kokkie]

How can I do that?

[Raycoms]

world.markBlocksDirtyVertical(); //Wil have 6 int positions as parameters to define the area.

 

 

 

[Kokkie]

Doesn't work as well

[Kokkie]

I also tried world.markChunkDirty or something like that but that didn't work

[Kokkie]

Bump

[Kokkie]

This is not only happening for the structure, also lava light isn't updated, and from my village the lights aren't either...

[Kokkie]

bump

[diesieben07]

Why on earth are you passing 20 for the flags parameter? Where did you get this number? What made you think it is correct?

And stop f***ing bumping.

[Kokkie]

20 is used in vanilla as well...

[diesieben07]

You should probably be using 3.

[Kokkie]

But what about all the other lights not updating in my dimension/biome

[diesieben07]

I don't know what you are talking about.

[Kokkie]

In my biome all the other lights (lava, other structures etc.) are also not loading (when they are first loaded)...

[Kokkie]

Bump