[1.10.2] Sync capabilities with client

JimiIT92 · December 11, 2016

I've created a custom capability to add mana, strength and other stats. Server side they works as intended but i'm having troubles displaying them correctly client side. So, for instance, i have a mana bar that will display the current amount of mana. But it always display 100 (the base value), even if i send a message to the client telling it what is the current mana value. So here are the message and the message handler i'm using

package com.rpg.messages;

import com.rpg.capabilities.player.IPlayerCapabilities;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class PlayerCapabilitiesMessage implements IMessage{

private IPlayerCapabilities value;

public PlayerCapabilitiesMessage() {
	this.value = null;
}

public PlayerCapabilitiesMessage(IPlayerCapabilities value) {
	this.value = value;
}

@Override
public void fromBytes(ByteBuf buf) {
	if(this.value != null) {
		this.value.setStrength(buf.readInt());
		this.value.setSkill(buf.readInt());
		this.value.setResistance(buf.readInt());
		this.value.setSpeed(buf.readInt());
		this.value.setVitality(buf.readInt());
		this.value.setMana(buf.readInt());
		this.value.setLevel(buf.readInt());
		this.value.setMaxHealth(buf.readFloat());
		this.value.setMaxHunger(buf.readFloat());
	}
}

@Override
public void toBytes(ByteBuf buf) {
	if(this.value != null) {
		buf.writeInt(this.value.getStrength());
		buf.writeInt(this.value.getSkill());
		buf.writeInt(this.value.getResistance());
		buf.writeInt(this.value.getSpeed());
		buf.writeInt(this.value.getVitality());
		buf.writeInt(this.value.getMana());
		buf.writeInt(this.value.getLevel());
		buf.writeFloat(this.value.getMaxHealth());
		buf.writeFloat(this.value.getMaxHunger());
	}
}

public void setValue(IPlayerCapabilities value) {
	this.value = value;
}

public IPlayerCapabilities getValue() {
	return this.value;
}
}

package com.rpg.messages;

import com.rpg.RPG;
import com.rpg.capabilities.player.IPlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilitiesProvider;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.IThreadListener;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class PlayerMessageHandler implements IMessageHandler<PlayerCapabilitiesMessage, IMessage>{

@Override
public IMessage onMessage(PlayerCapabilitiesMessage message, MessageContext ctx) {
	IThreadListener thread = RPG.PROXY.getListener(ctx);
	final EntityPlayer player = RPG.PROXY.getPlayer(ctx);
	final IPlayerCapabilities value = message.getValue();
	thread.addScheduledTask(new Runnable() {
		@Override
		public void run() {
			if(player != null) {
				IPlayerCapabilities capabilities = player.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
				if(capabilities != null && value != null) {
					capabilities.setStrength(value.getStrength());
					capabilities.setSkill(value.getSkill());
					capabilities.setResistance(value.getResistance());
					capabilities.setSpeed(value.getSpeed());
					capabilities.setVitality(value.getVitality());
					capabilities.setMana(value.getMana());
					capabilities.setLevel(value.getLevel());
					capabilities.setMaxHealth(value.getMaxHealth());
					capabilities.setMaxHunger(value.getMaxHunger());
				}
			}
		}
	});
	return null;
}

}

This is the mana bar rendering code

package com.rpg.gui;

import org.lwjgl.opengl.GL11;

import com.rpg.RPG;
import com.rpg.capabilities.player.IPlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilitiesProvider;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.Gui;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.RenderGameOverlayEvent;
import net.minecraftforge.client.event.RenderGameOverlayEvent.ElementType;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class GuiOverlay extends Gui{
private Minecraft mc;
private static final ResourceLocation icons = new ResourceLocation(RPG.MODID, "textures/gui/icons.png");

public GuiOverlay(Minecraft mc) {
	super();
	this.mc = mc;
}


@SubscribeEvent
public void onRenderExperienceBar(RenderGameOverlayEvent event) {
	if (event.isCancelable() || event.getType() != ElementType.EXPERIENCE)
		return;

	int xPos = 2;
	int yPos = 2;

	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
	GL11.glDisable(GL11.GL_LIGHTING);
	this.mc.getTextureManager().bindTexture(icons);

	EntityPlayer player = this.mc.thePlayer;
        IPlayerCapabilities iplayer = player.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
        
        if(iplayer != null) {
        	this.drawTexturedModalRect(xPos, yPos, 0, 80, 100, 5);
    		int manaBarWidth = (int) (((float) iplayer.getMana() / 100) * 100);
    		this.drawTexturedModalRect(xPos, yPos, 0, 85, manaBarWidth, 5);
    		this.drawCenteredString(this.mc.fontRendererObj, String.valueOf(iplayer.getMana()),xPos + 50, yPos - 1, 0xFFFFFF);
        }
}
}

This is how i registered the message

public static SimpleNetworkWrapper NETWORK;
@EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	NETWORK = NetworkRegistry.INSTANCE.newSimpleChannel(MODID);
    	
    	NETWORK.registerMessage(PlayerMessageHandler.class, PlayerCapabilitiesMessage.class, 1, Side.CLIENT);
    }

And these are the proxyes

package com.rpg.proxy;

import com.rpg.events.EventDimensionChange;
import com.rpg.events.EventPlayerClone;
import com.rpg.events.EventPlayerLogIn;
import com.rpg.events.EventPlayerTick;
import com.rpg.messages.PlayerMessageHandler;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.IThreadListener;
import net.minecraft.world.WorldServer;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class CommonProxy {

public void init() {
	MinecraftForge.EVENT_BUS.register(new PlayerMessageHandler());
}

public IThreadListener getListener(MessageContext ctx) {
	return (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
}

public EntityPlayer getPlayer(MessageContext ctx) {
	return ctx.getServerHandler().playerEntity;
}
}

package com.rpg.proxy;

import com.rpg.RPG;
import com.rpg.capabilities.CapabilityHandler;
import com.rpg.capabilities.item.IItemCapabilities;
import com.rpg.capabilities.item.ItemCapabilities;
import com.rpg.capabilities.item.ItemCapabilitiesStorage;
import com.rpg.capabilities.player.IPlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilitiesStorage;
import com.rpg.events.EventDimensionChange;
import com.rpg.events.EventPlayerClone;
import com.rpg.events.EventPlayerLogIn;
import com.rpg.events.EventPlayerRespawn;
import com.rpg.events.EventPlayerTick;
import com.rpg.events.EventRightClick;
import com.rpg.gui.GuiHandler;
import com.rpg.gui.GuiOverlay;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.IThreadListener;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.common.capabilities.CapabilityManager;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;
import net.minecraftforge.fml.relauncher.Side;

public class ClientProxy extends CommonProxy{

public void init() {
	CapabilityManager.INSTANCE.register(IPlayerCapabilities.class, new PlayerCapabilitiesStorage(), PlayerCapabilities.class);
	CapabilityManager.INSTANCE.register(IItemCapabilities.class, new ItemCapabilitiesStorage(), ItemCapabilities.class);

	MinecraftForge.EVENT_BUS.register(new CapabilityHandler());

	MinecraftForge.EVENT_BUS.register(new EventDimensionChange());
	MinecraftForge.EVENT_BUS.register(new EventPlayerClone());
	MinecraftForge.EVENT_BUS.register(new EventPlayerLogIn());
	MinecraftForge.EVENT_BUS.register(new EventPlayerTick());
	MinecraftForge.EVENT_BUS.register(new EventPlayerRespawn());
	MinecraftForge.EVENT_BUS.register(new EventRightClick());

	MinecraftForge.EVENT_BUS.register(new GuiOverlay(Minecraft.getMinecraft()));

	NetworkRegistry.INSTANCE.registerGuiHandler(RPG.INSTANCE, new GuiHandler());
}

public IThreadListener getListener(MessageContext ctx) {
	return ctx.side == Side.CLIENT ? Minecraft.getMinecraft() : super.getListener(ctx);
}

public EntityPlayer getPlayer(MessageContext ctx) {
	return ctx.side == Side.CLIENT ? Minecraft.getMinecraft().thePlayer : super.getPlayer(ctx);
}
}

Every tick i do this

package com.rpg.events;

import com.rpg.RPG;
import com.rpg.capabilities.player.IPlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilitiesProvider;
import com.rpg.messages.PlayerCapabilitiesMessage;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent.PlayerTickEvent;
import net.minecraftforge.fml.relauncher.Side;

public class EventPlayerTick {

@SubscribeEvent
public void onPlayerTick(PlayerTickEvent event) {
	if(event.side == Side.SERVER) {
		EntityPlayer player = event.player;
        IPlayerCapabilities capabilities = player.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
		RPG.NETWORK.sendTo(new PlayerCapabilitiesMessage(capabilities), (EntityPlayerMP) player);
	}	
}
}

As i said server side there are no problems at all, it's just that in GUI isn't displayed the correct value. How can i fix this?

MCenderdragon · December 11, 2016

Why are you registering the Message Handler for server adn clietn, only the client needs it? And the EventPlayerTick get only registered on the CLient but this is needed on the server because you send the Message from the Server to the CLient.

JimiIT92 · December 11, 2016

Woops, i've changed that so now the Tick Handler is registered in the common proxy and the Message Handler is only registered in the pre-init event, but i got the same issue. Also debugging i noticed that in the message, when i read the value, this return null, even if i specify a capability in the constructor of that message

JimiIT92 · December 11, 2016

Ok, after doing some changes now it works and the value si displayed correctly. But now i'm having some troubles with the right click event and a GUI. First at all it looks like the right click event is fired twice

This is the event code

@SubscribeEvent
public void onRightClick(PlayerInteractEvent.RightClickBlock event) {
	if(!event.getWorld().isRemote) {
		EntityPlayer player = event.getEntityPlayer();
        IPlayerCapabilities capabilities = player.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
        if(capabilities != null) {
        	capabilities.removeMana(1);
	        event.getEntityPlayer().addChatMessage(new TextComponentString(capabilities.getMana() + ""));
	        RPG.NETWORK.sendTo(new PlayerCapabilitiesMessage(capabilities), (EntityPlayerMP) player);
        }
	}
}

This event should be fired only server side and will send a chat message to the player with the current amount of mana. But for some reason, if for example i have 100 mana, when i right click a block the player got 2 chat messages and the mana goes to 98, meaning that the code is called twice and i don't know why this happen

For the GUI i have this GUI

package com.rpg.gui;

import java.io.IOException;

import org.lwjgl.opengl.GL11;

import com.rpg.RPG;
import com.rpg.capabilities.player.IPlayerCapabilities;
import com.rpg.capabilities.player.PlayerCapabilitiesProvider;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiMerchant;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.OpenGlHelper;
import net.minecraft.client.renderer.RenderHelper;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class GuiTalents extends GuiScreen {

private static final ResourceLocation TALENTS = new ResourceLocation(RPG.MODID, "textures/gui/talents.png");

public GuiTalents() {

}

/** The old x position of the mouse pointer */
private float oldMouseX;
/** The old y position of the mouse pointer */
private float oldMouseY;

@Override
public void drawScreen(int mouseX, int mouseY, float partialTicks) {

	GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
	GL11.glDisable(GL11.GL_LIGHTING);
	this.mc.getTextureManager().bindTexture(this.TALENTS);

	int xPos = width / 2 - 87;
	int yPos = height / 2 - 87;
	this.drawTexturedModalRect(xPos, yPos, 0, 0, 176, 185);
	this.oldMouseX = (float) mouseX;
	this.oldMouseY = (float) mouseY;
	IPlayerCapabilities capabilities = Minecraft.getMinecraft().thePlayer
			.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
	if (capabilities != null) {
		drawEntityOnScreen(xPos + 31, yPos + 75, 30, (float) (xPos + 31) - this.oldMouseX,
				(float) (yPos + 75 - 50) - this.oldMouseY, this.mc.thePlayer);
		this.fontRendererObj.drawString(Minecraft.getMinecraft().thePlayer.getName(), xPos + 80, yPos + 10,
				4210752);

		this.fontRendererObj.drawString(I18n.format("gui.talents.mana") + ": ", xPos + 80, yPos + 28, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.level") + ": ", xPos + 80, yPos + 48, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.class") + ": ", xPos + 80, yPos + 68, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.vitality") + ": ", xPos + 30, yPos + 88, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.strength") + ": ", xPos + 30, yPos + 108, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.skill") + ": ", xPos + 30, yPos + 128, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.speed") + ": ", xPos + 30, yPos + 148, 4210752);
		this.fontRendererObj.drawString(I18n.format("gui.talents.resistance") + ": ", xPos + 30, yPos + 168,
				4210752);

		this.fontRendererObj.drawString(String.valueOf(capabilities.getMana() + "/100"), xPos + 116, yPos + 28,
				4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getLevel() + "/30"), xPos + 116, yPos + 48,
				4210752);
		this.fontRendererObj.drawString(String.valueOf("No Class"), xPos + 116, yPos + 68, 4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getVitality() + "/10"), xPos + 116, yPos + 88,
				4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getStrength() + "/10"), xPos + 116, yPos + 108,
				4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getSkill() + "/10"), xPos + 116, yPos + 128,
				4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getSpeed() + "/10"), xPos + 116, yPos + 148,
				4210752);
		this.fontRendererObj.drawString(String.valueOf(capabilities.getResistance() + "/10"), xPos + 116,
				yPos + 168, 4210752);

		int points = capabilities.getStrength() + capabilities.getVitality() + capabilities.getResistance()
				+ capabilities.getSkill() + capabilities.getSpeed();

		if (points <= capabilities.getLevel()) {
			this.buttonList.add(new UpgradeButton(1, xPos + 116 + 40, yPos + 88));
			this.buttonList.add(new UpgradeButton(2, xPos + 116 + 40, yPos + 108));
			this.buttonList.add(new UpgradeButton(3, xPos + 116 + 40, yPos + 128));
			this.buttonList.add(new UpgradeButton(4, xPos + 116 + 40, yPos + 148));
			this.buttonList.add(new UpgradeButton(5, xPos + 116 + 40, yPos + 168));
		}
	}
	super.drawScreen(mouseX, mouseY, partialTicks);
}

@Override
public boolean doesGuiPauseGame() {
	return false;
}

@Override
protected void actionPerformed(GuiButton button) throws IOException {
	IPlayerCapabilities capabilities = Minecraft.getMinecraft().thePlayer
			.getCapability(PlayerCapabilitiesProvider.PLAYER_CAP, null);
	if (capabilities != null) {
		if (button.id == 1) {
			capabilities.addVitality(1);
			return;
		}
	}

	super.actionPerformed(button);
}

public static void drawEntityOnScreen(int posX, int posY, int scale, float mouseX, float mouseY,
		EntityLivingBase ent) {
	GlStateManager.enableColorMaterial();
	GlStateManager.pushMatrix();
	GlStateManager.translate((float) posX, (float) posY, 50.0F);
	GlStateManager.scale((float) (-scale), (float) scale, (float) scale);
	GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
	float f = ent.renderYawOffset;
	float f1 = ent.rotationYaw;
	float f2 = ent.rotationPitch;
	float f3 = ent.prevRotationYawHead;
	float f4 = ent.rotationYawHead;
	GlStateManager.rotate(135.0F, 0.0F, 1.0F, 0.0F);
	RenderHelper.enableStandardItemLighting();
	GlStateManager.rotate(-135.0F, 0.0F, 1.0F, 0.0F);
	GlStateManager.rotate(-((float) Math.atan((double) (mouseY / 40.0F))) * 20.0F, 1.0F, 0.0F, 0.0F);
	ent.renderYawOffset = (float) Math.atan((double) (mouseX / 40.0F)) * 20.0F;
	ent.rotationYaw = (float) Math.atan((double) (mouseX / 40.0F)) * 40.0F;
	ent.rotationPitch = -((float) Math.atan((double) (mouseY / 40.0F))) * 20.0F;
	ent.rotationYawHead = ent.rotationYaw;
	ent.prevRotationYawHead = ent.rotationYaw;
	GlStateManager.translate(0.0F, 0.0F, 0.0F);
	RenderManager rendermanager = Minecraft.getMinecraft().getRenderManager();
	rendermanager.setPlayerViewY(180.0F);
	rendermanager.setRenderShadow(false);
	rendermanager.doRenderEntity(ent, 0.0D, 0.0D, 0.0D, 0.0F, 1.0F, false);
	rendermanager.setRenderShadow(true);
	ent.renderYawOffset = f;
	ent.rotationYaw = f1;
	ent.rotationPitch = f2;
	ent.prevRotationYawHead = f3;
	ent.rotationYawHead = f4;
	GlStateManager.popMatrix();
	RenderHelper.disableStandardItemLighting();
	GlStateManager.disableRescaleNormal();
	GlStateManager.setActiveTexture(OpenGlHelper.lightmapTexUnit);
	GlStateManager.disableTexture2D();
	GlStateManager.setActiveTexture(OpenGlHelper.defaultTexUnit);
}

@SideOnly(Side.CLIENT)
static class UpgradeButton extends GuiButton {

	public UpgradeButton(int buttonID, int x, int y) {
		super(buttonID, x, y, 11, 7, "");
		this.visible = true;
		this.enabled = true;
	}

	/**
	 * Draws this button to the screen.
	 */
	public void drawButton(Minecraft mc, int mouseX, int mouseY) {
		mc.getTextureManager().bindTexture(GuiTalents.TALENTS);
		GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
		this.hovered = mouseX >= this.xPosition && mouseY >= this.yPosition && mouseX < this.xPosition + 11
				&& mouseY < this.yPosition + 7;
		if (this.hovered)
			this.drawTexturedModalRect(this.xPosition, this.yPosition, 14, 194, 11, 7);
		else
			this.drawTexturedModalRect(this.xPosition, this.yPosition, 0, 194, 11, 7);
	}
}

}

But when i click on a button the value is not incremented by 1 (instead goes from 12 to 45!) and also when i reload the world the value goes back to 0. Now i think this is because this modification is handled client side (in the GUI) but i don't know what should i send to the server (the same message that i send to the client?). Please help me understand why this happen, since it's the very first time i work with capabilities and networking in general

Draco18s · December 11, 2016

First at all it looks like the right click event is fired twice

Once for each hand.

JimiIT92 · December 11, 2016

Ah, i didn't know that I'll add a check then to limit it to one hand. But what about the GUI? Why is the button code called many times instead of jsut one?

Sign In

[1.10.2] Sync capabilities with client

Recommended Posts

JimiIT92

MCenderdragon

JimiIT92

JimiIT92

Draco18s

JimiIT92

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information