[1.11] [SOLVED] Making sure players don't spawn in deep water/ocean areas.

[Mopop]

I'm curious as to which way I could go about making sure that players only spawn on land. I'm used to bukkit and they just had a biome.isOcean method. I can't seem to find anything similar for forge.

 

Thanks.

[Draco18s]

Use the biome dictionary.

[Mopop]

Use the biome dictionary.

 

Hmm. I was looking into that. I'll mess around with it now. I'll probably have some poorly written code coming up soon!

[Mopop]

Ok after messing with that and other things I'm writing. I got this code, but of course, it doesn't work. I'm sure I'm miss using the BiomeDictonary but I couldn't find much documentation on it.

 

@SubscribeEvent
    public void playerSpawn (PlayerEvent.PlayerRespawnEvent e)
    {
        BlockPos spawnPos = randomSpawn();
        Biome biome = grabBiome(e.player, spawnPos);

        do
        {
            e.player.getEntityWorld().getWorldInfo().setSpawn(spawnPos);
        }
        while (BiomeDictionary.hasType(biome, BiomeDictionary.Type.OCEAN) | e.player.getEntityWorld().getBlockState(spawnPos).getMaterial() == Material.WATER);
        {
            e.player.getEntityWorld().getWorldInfo().setSpawn(randomSpawn());
            spawnPos = e.player.getEntityWorld().getSpawnPoint();
            biome = grabBiome(e.player, spawnPos);
        }
    }

 

Also bonus points if someone knows how I can delay my code like sleep.thread() without it making Minecraft freeze. I'm trying to wait 8 seconds then it kills a mob. I can get it to pause for like a second then do it, but it looks so unnatural like that. Also how do you set it so that a mob doesn't drop anything? I set entity.setDropItemsWhenDead() to false and it still drops their items on death.

 

Sorry for the question inside a question, didn't want to make a whole new topic if I didn't have to.

 

Thanks in advance.

[Draco18s]

It doesn't work because you have a while loop that does nothing.  It continually sets the spawn point to a fixed location.

Then after it leaves the infinite loop, it sets the spawn to a random location.

 

Also, thread.sleep is not how you make things happen across time.  If you want something to occur across ticks, you need to count ticks in a tick event handler.

[Mopop]

So the while statement is broke? Heres how I -thought- it worked.

 

-while the biome equals ocean or the block the player is going to be spawned to is in water

 

- Set another spawn location with the randomSpawn() method

 

- Get the new spawn location information and assign it to the spawnPos variable

 

-From the spawnPos field find write over the biome field so that it can find the new biome instead of it staying on the old biome.

 

-back to the while statement to see if the information to see if the biome is an ocean or the block is water.

 

Where did I go wrong along the way?

[Draco18s]

So the while statement is broke? Heres how I -thought- it worked.

 

-while the biome equals ocean or the block the player is going to be spawned to is in water

 

- Set another spawn location with the randomSpawn() method

 

Going to stop you right there.  You're wrong:

That's your loop.

 

"While the biome equals ocean or the block is water, setSpawn(spawnPos);"

 

do { /*something } while(/*condition*/);

 

You do not have a "while loop."  You have a "do-while loop" and it ends with the semicolon.

 

Those other three lines exist inside a block that is just a block.  There's no wrapper conditional or anything on it.  It's just a code block.

 

public void someMethod() {
    //method block
    {
        //some unnamed block. perfectly valid code.
    }
    while(/*condition*/) {
        //loop block  
    }
}

[Mopop]

Ah whoops, I'm still kinda rusty right now at coding.

 

I'm guessing the logic part is also wrong in the while statement? Because I moved all the code up to the do statement and I still spawn in water, and sometimes it just spawns me in this weird dark place and the game locks up.

 

 

@SubscribeEvent
    public void playerSpawn (PlayerEvent.PlayerRespawnEvent e)
    {
        BlockPos spawnPos = randomSpawn();
        Biome biome = grabBiome(e.player, spawnPos);

        do
        {
            e.player.getEntityWorld().getWorldInfo().setSpawn(spawnPos);
            spawnPos = e.player.getEntityWorld().getSpawnPoint();
            biome = grabBiome(e.player, spawnPos);
        }
        while (BiomeDictionary.hasType(biome, BiomeDictionary.Type.OCEAN) | e.player.getEntityWorld().getBlockState(spawnPos).getMaterial() == Material.WATER);
    }

 

 

Thanks for helping me out.

[Mopop]

I'm also having problems getting the TickEvent to work for me. I just need a timer to count 8 seconds whenever the mob is set on fire. I've been working on it a couple hours and it either doesn't work, or looks very unnatural. I've tried looking on google and tried finding source code to read with stuff I would suspect had timers, but did not.

[jeffryfisher]

Ah whoops, I'm still kinda rusty right now at coding.

 

Oh... That can get you into trouble in this forum if you stack up Java ignorance. Once is understandable, because anyone can have a slip, but a losing streak will wear out mods' patience.

 

I recommend finding a Java helper through whom you can filter your questions, at least until you have more confidence that your questions are really about Forge and Minecraft, not basic coding.

 

Also: Eclipse (or any IDE worth the name) can help you too. It has features to show you matching braces, whole statements etc. Running in the debugger can let you step through your methods to see what it is doing and what variables have what values at various places. If you use these features before posting here, then you'll have solved more yourself and arrive with more information to give us.

 

PS: Yes, your program logic makes no sense. Find help with intro programming (ask a programmer to tell you how local variables work within computer programs) and get it cleaned up.

 

[Mopop]

I know the basics at the very least. I've never been too advanced of a coder but I do have a grip on scope, variables, and using the debugger. I even set up my IDE to filter out from stepping into the APIs so I don't have to step out of thousands of line of code.

 

I've stepped through the code it says that it is an Ocean biome, but yet it doesn't try to grab another spawnpoint. I'm guessing I'm just using the wrong calls due to an ignorance of the forge API. I do know of a good java coders discord server, so maybe I'll run somethings past those guys too.

 

I do try very hard to come up with answers myself, I usually do not post until I've tried several approaches, google my problem , read other modders source code. I know how much coding forums hate people asking for them to write the code and I'm not trying to do that.

 

I will reassess my code though, thank you for your help and responding kindly.

[Draco18s]

I've stepped through the code it says that it is an Ocean biome, but yet it doesn't try to grab another spawnpoint.

 

You've stated that you understand scope and how to step through code.

 

Please show where the code is to fetch a new, random, spawn point and explain why it should be called during the second iteration of the loop.

[Mopop]

 

@SubscribeEvent

    public void playerSpawn (PlayerEvent.PlayerRespawnEvent e)

    {

        BlockPos spawnPos = randomSpawn();

        Biome biome = grabBiome(e.player, spawnPos);

 

        do

        {

            e.player.getEntityWorld().getWorldInfo().setSpawn(spawnPos);

            spawnPos = e.player.getEntityWorld().getSpawnPoint();

            biome = grabBiome(e.player, spawnPos);

        }

        while(BiomeDictionary.hasType(biome, BiomeDictionary.Type.OCEAN) | e.player.getEntityWorld().getBlockState(spawnPos).getMaterial() == Material.WATER);

    }

 

    public Biome grabBiome(Entity e, BlockPos pos)

    {

        return e.getEntityWorld().getBiome(pos);

    }

 

    private BlockPos randomSpawn()

    {

        double min = Math.ceil(0);

        double max = Math.floor(1000000);

 

        int randomX = (int) (Math.floor(Math.random() * (max - min)) + min);

        int randomZ = (int) (Math.floor(Math.random() * (max - min)) + min);

        int y = 1;

 

        BlockPos spawn = new BlockPos(randomX, y, randomZ);

        return spawn;

    }

 

 

There is all my spawn code.

 

Well I put it in there because if it looped around it would need another random spawn then I noticed, it never was getting another spawn point. so I rewrote it and it seems to be working, tried 15 times only problem was once I spawned in a tree...I thought MC checked to see if it's a spawnable block before placing you? Or is this something I have to write myself? Here is the new code btw.

 

 

public void playerSpawn (PlayerEvent.PlayerRespawnEvent e)
    {
        Biome biome;
        BlockPos spawnPos;

        do
        {
            spawnPos = randomSpawn();
            e.player.getEntityWorld().getWorldInfo().setSpawn(spawnPos);
            spawnPos = e.player.getEntityWorld().getSpawnPoint();
            biome = grabBiome(e.player, spawnPos);
        }
        while(BiomeDictionary.hasType(biome, BiomeDictionary.Type.OCEAN));
    }

 

 

 

[Draco18s]

Player spawn gives no fucks about trees. It's only mob spawn that requires a full, non-transparent, block. And even then is on a mob-by-mob basis (most mobs don't override that default though).

[Mopop]

I threw this at the end of my code

 

e.player.preparePlayerToSpawn();

 

After 30 respawns I haven't spawned in a tree, it looks like this method checks to make sure that a player can spawn properly? Thank you so much for your patience and help. I think I'm going to list this one as solved!