So I've tried to get used to the new mechanics in 1.9+ forge and I'm having a few issues. I'm doing this in netbeans because I wanted to try something new.

 

I've tried to create a basic item, an Obsidian sword.

 

My Code:

 

ObsidianSword.java

package com.coal.item.items;

import com.coal.BasicMod;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ObsidianSword extends Item{
    
    public ObsidianSword(){
        super();
        
       this.setCreativeTab(CreativeTabs.COMBAT);
       this.setUnlocalizedName("obsidiansword");
       

    }
}

 

ModItems.java

package com.coal.item;

import com.coal.BasicMod;
import com.coal.item.items.ObsidianSword;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.ItemMeshDefinition;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.registry.GameRegistry;

public final class ModItems {
    

    public static Item obsidianSword;
    
    public static final void preinit(){
        obsidianSword = registerItem(new ObsidianSword(), "obsidiansword");
    }
    
    public static final void registerRenders(){
        registerRender(obsidianSword);
    }
    
    private static final void registerRender(Item i){
      ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));
    }
    
    private static final Item registerItem(Item i, String n){
        GameRegistry.register(i, new ResourceLocation(BasicMod.MODID, n));
        return i;
    }
    
}

 

Main Class:

package com.coal;



import com.coal.item.ModItems;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;


@Mod(modid = BasicMod.MODID, version = BasicMod.VERSION)
public class BasicMod
{
    public static final String MODID = "basicmod";
    public static final String VERSION = "1.0";

    @EventHandler
    public void preInit(FMLInitializationEvent event)
    {
        System.out.println("Started Pre-Init!");
        
        

    }

    @EventHandler
    public void init(FMLInitializationEvent event)
    {
        ModItems.preinit();
        
        System.out.println("Started Init!");
       ModItems.registerRenders();
    }

    @EventHandler
    public void postInit(FMLInitializationEvent event)
    {
        System.out.println("Started PostInit!");
    }
}

 

obsidiansword.json

{
    "parent": "item/generated",
    "textures":{
        "layer0":"basicmod:items/obsidiansword" 
    }
}

 

My Project Structure:

 

Whenever I run it I get this in the log:

 

[20:25:32] [Client thread/ERROR] [FML]: Exception loading model for variant basicmod:item.obsidiansword#inventory for item "basicmod:obsidiansword", normal location exception:

net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model basicmod:item/item.obsidiansword with loader VanillaLoader.INSTANCE, skipping

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]

at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:318) ~[ModelLoader.class:?]

at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:175) ~[ModelBakery.class:?]

at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:148) ~[ModelLoader.class:?]

at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.notifyReloadListeners(SimpleReloadableResourceManager.java:132) [simpleReloadableResourceManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.reloadResources(SimpleReloadableResourceManager.java:113) [simpleReloadableResourceManager.class:?]

at net.minecraft.client.Minecraft.refreshResources(Minecraft.java:800) [Minecraft.class:?]

at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:357) [FMLClientHandler.class:?]

at net.minecraft.client.Minecraft.init(Minecraft.java:562) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]

at GradleStart.main(GradleStart.java:26) [start/:?]

Caused by: java.io.FileNotFoundException: basicmod:models/item/item.obsidiansword.json

at net.minecraft.client.resources.FallbackResourceManager.getResource(FallbackResourceManager.java:69) ~[FallbackResourceManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.getResource(SimpleReloadableResourceManager.java:65) ~[simpleReloadableResourceManager.class:?]

at net.minecraft.client.renderer.block.model.ModelBakery.loadModel(ModelBakery.java:334) ~[ModelBakery.class:?]

at net.minecraftforge.client.model.ModelLoader.access$1100(ModelLoader.java:119) ~[ModelLoader.class:?]

at net.minecraftforge.client.model.ModelLoader$VanillaLoader.loadModel(ModelLoader.java:869) ~[ModelLoader$VanillaLoader.class:?]

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]

... 23 more

[20:25:32] [Client thread/ERROR] [FML]: Exception loading model for variant basicmod:item.obsidiansword#inventory for item "basicmod:obsidiansword", blockstate location exception:

net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model basicmod:item.obsidiansword#inventory with loader VariantLoader.INSTANCE, skipping

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]

at net.minecraftforge.client.model.ModelLoader.loadItemModels(ModelLoader.java:326) ~[ModelLoader.class:?]

at net.minecraft.client.renderer.block.model.ModelBakery.loadVariantItemModels(ModelBakery.java:175) ~[ModelBakery.class:?]

at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:148) ~[ModelLoader.class:?]

at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.notifyReloadListeners(SimpleReloadableResourceManager.java:132) [simpleReloadableResourceManager.class:?]

at net.minecraft.client.resources.SimpleReloadableResourceManager.reloadResources(SimpleReloadableResourceManager.java:113) [simpleReloadableResourceManager.class:?]

at net.minecraft.client.Minecraft.refreshResources(Minecraft.java:800) [Minecraft.class:?]

at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:357) [FMLClientHandler.class:?]

at net.minecraft.client.Minecraft.init(Minecraft.java:562) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_101]

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_101]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_101]

at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_101]

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]

at GradleStart.main(GradleStart.java:26) [start/:?]

Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException

at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:78) ~[ModelBlockDefinition.class:?]

at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1185) ~[ModelLoader$VariantLoader.class:?]

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]

... 23 more

 

For some reason it seems to think the json is in item.item which doesn't exist. But I've tried making another folder called item and adjusting it and it still gives exactly the same error.

 

I've been following multiple tutorials so I'm sure I've done a billion things wrong.

 

If anyone could help it would be greatly appreciated!

 

 

1) You didn't actually include ModItems, you pasted a second copy of your obsidian sword.

2) Caused by: java.io.FileNotFoundException: basicmod:models/item/item.obsidiansword.json

 

Your file name doesn't match the resource you told Minecraft to load.

1) You didn't actually include ModItems, you pasted a second copy of your obsidian sword.

2) Caused by: java.io.FileNotFoundException: basicmod:models/item/item.obsidiansword.json

 

Your file name doesn't match the resource you told Minecraft to load.

1. oops! My mistake! Fixed on the thread now.

2. So my file is actually called "item.obsidiansword" instead of being obsidiansword in the package item? I don't see where I've managed to do that though... Is it the unlocalized name?

It's because you used the unlocalized name, yes.  You should change this:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));

To:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(i.getRegistryName(), "inventory"));

getRegistryName() automatically appends your Mod ID (and honestly, your unlocalized name should too, e.g.

someItem.setUnlocalizedName(someItem.getRegistryName())

).

It's because you used the unlocalized name, yes.  You should change this:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));

To:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(i.getRegistryName(), "inventory"));

getRegistryName() automatically appends your Mod ID (and honestly, your unlocalized name should too, e.g.

someItem.setUnlocalizedName(someItem.getRegistryName())

).

 

Thanks, that fixed the errors but I still can't see my texture... Is there anything wrong with my json file?

Post the new error log.

Post the new error log.

Sorry for the late response but there is nothing in the logs. Nothing at all. No error. Nothing.

What exactly does your item look like in the game? Is it a cube or a flat square? Presumably you mean that it is showing the purple/black squares texture?

What exactly does your item look like in the game? Is it a cube or a flat square? Presumably you mean that it is showing the purple/black squares texture?

It's a cube with purple and black squares. There is nothing in the logs, no errors or anything.

ModelLoader.setCustomModelResourceLocation must be called in

ModelRegistryEvent

.

It isn't being fired for some reason:

 

Events Class:

package com.coal;

import com.coal.item.ModItems;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class BasicEvents {
    @SubscribeEvent
    public void onModelRegistry(ModelRegistryEvent event){
        System.out.println("======================="
                + "========================="
                + "Models Registered! "
        );
       ModItems.registerRenders();
    }
}

 

Main:

package com.coal;



import com.coal.item.ModItems;
import static com.coal.item.ModItems.obsidianSword;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.FMLCommonHandler;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


@Mod(modid = BasicMod.MODID, version = BasicMod.VERSION)
public class BasicMod
{
    public static final String MODID = "basicmod";
    public static final String VERSION = "1.0";

    BasicEvents events = new BasicEvents();
    
    @EventHandler
    public void preInit(FMLInitializationEvent event)
    {
        System.out.println("Started Pre-Init!");
        MinecraftForge.EVENT_BUS.register(events);

    }

    @EventHandler
    public void init(FMLInitializationEvent event)
    {
        ModItems.preinit();
        
       System.out.println("Started Init!");
       //ModItems.registerRenders();
       System.out.println(obsidianSword.getUnlocalizedName());
    }

    @EventHandler
    public void postInit(FMLInitializationEvent event)
    {
        System.out.println("Started PostInit!");
    }
    
    
}

 

Have I registered it incorrectly?

 

 

 

preInit is too late to register for that event. You have to either subscribe to it from your

@Mod

class' constructor or (much cleaner) use

@EventBusSubscriber

.

How do I use EventBusSubscriber? I've tried this:

 

@EventBusSubscriber(new BasicEvents())

Which informs me that BasicEvents() cannot be converted to side.

 

Same error when I try this:

 

@EventBusSubscriber(MinecraftForge.EVENT_BUS.register(new BasicEvents()))

You know how annotations work, yes?

 

I suggest you read the documentation.

So I added @Mod.EventBusSubscriber to the top of my events class and I still have nothing in the console which I printed and there is no texture either.

 

This is what the class looks like:

package com.coal;

import com.coal.item.ModItems;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


@Mod.EventBusSubscriber
public class BasicEvents {
    @SubscribeEvent
    public void onModelRegistry(ModelRegistryEvent event){
        System.out.println("======================="
                + "========================="
                + "Model Registered! "
        );
       ModItems.registerRenders();
    }
}

@EventBusSubscriber

adds the class to the EventBus, not an instance (like it says in the documentation). Read the linked documentation again to understand what the difference is. Then look at your code and it should be obvious.

So I made the method static and apparently it's worked but I'm encountering this error that I had a while back:

 

 

ava.lang.NullPointerException: Initializing game

at com.coal.item.ModItems.registerRender(ModItems.java:33)

at com.coal.item.ModItems.registerRenders(ModItems.java:29)

at com.coal.BasicEvents.onModelRegistry(BasicEvents.java:17)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_0_BasicEvents_onModelRegistry_ModelRegistryEvent.invoke(.dynamic)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)

at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185)

at net.minecraftforge.fml.client.FMLClientHandler.fireSidedRegistryEvents(FMLClientHandler.java:1072)

at net.minecraftforge.fml.common.FMLCommonHandler.fireSidedRegistryEvents(FMLCommonHandler.java:753)

at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:625)

at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:266)

at net.minecraft.client.Minecraft.init(Minecraft.java:478)

at net.minecraft.client.Minecraft.run(Minecraft.java:387)

at net.minecraft.client.main.Main.main(Main.java:118)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)

at GradleStart.main(GradleStart.java:26)

 

 

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

 

-- Head --

Thread: Client thread

Stacktrace:

at com.coal.item.ModItems.registerRender(ModItems.java:33)

at com.coal.item.ModItems.registerRenders(ModItems.java:29)

at com.coal.BasicEvents.onModelRegistry(BasicEvents.java:17)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_0_BasicEvents_onModelRegistry_ModelRegistryEvent.invoke(.dynamic)

at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)

at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185)

at net.minecraftforge.fml.client.FMLClientHandler.fireSidedRegistryEvents(FMLClientHandler.java:1072)

at net.minecraftforge.fml.common.FMLCommonHandler.fireSidedRegistryEvents(FMLCommonHandler.java:753)

at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:625)

at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:266)

at net.minecraft.client.Minecraft.init(Minecraft.java:478)

 

-- Initialization --

Details:

Stacktrace:

at net.minecraft.client.Minecraft.run(Minecraft.java:387)

at net.minecraft.client.main.Main.main(Main.java:118)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)

at GradleStart.main(GradleStart.java:26)

 

 

 

I looked this up before and it said it was because there was no unlocalized name until it reached the init or something like that. It uses registry name now but the same principle may apply.

 

Or it's something else.

These rendering registration methods are entirely client side. You cannot have them in common code,

ModItems

is common code (i.e. loaded on the server and the client). This will crash a dedicated server, since it has no idea wtf a "model" or a "texture" is.

 

You get this exception because you create and register your items in init. You should be creating them in the field initializer (see below for an example) and register them in

RegistryEvent.Register<Item>

. You use this event in the same fashion as

ModelRegistryEvent

.

 

Example for above:

 

public static final Item myItem = new MyItem();

 

Thank you very much. It works now and I can see the texture.