Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.11.2] Difficulty Adding an item with a Texture

Hexadecimal

By Hexadecimal
in Modder Support

 Share

Recommended Posts

Hexadecimal Tree Puncher

Hexadecimal

Posted
Posted

So I've tried to get used to the new mechanics in 1.9+ forge and I'm having a few issues. I'm doing this in netbeans because I wanted to try something new.

 

I've tried to create a basic item, an Obsidian sword.

 

My Code:

 

ObsidianSword.java

package com.coal.item.items;

import com.coal.BasicMod;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ObsidianSword extends Item{
    
    public ObsidianSword(){
        super();
        
       this.setCreativeTab(CreativeTabs.COMBAT);
       this.setUnlocalizedName("obsidiansword");
       

    }
}

 

ModItems.java

package com.coal.item;

import com.coal.BasicMod;
import com.coal.item.items.ObsidianSword;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.ItemMeshDefinition;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.registry.GameRegistry;

public final class ModItems {
    

    public static Item obsidianSword;
    
    public static final void preinit(){
        obsidianSword = registerItem(new ObsidianSword(), "obsidiansword");
    }
    
    public static final void registerRenders(){
        registerRender(obsidianSword);
    }
    
    private static final void registerRender(Item i){
      ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));
    }
    
    private static final Item registerItem(Item i, String n){
        GameRegistry.register(i, new ResourceLocation(BasicMod.MODID, n));
        return i;
    }
    
}

 

Main Class:

package com.coal;



import com.coal.item.ModItems;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;


@Mod(modid = BasicMod.MODID, version = BasicMod.VERSION)
public class BasicMod
{
    public static final String MODID = "basicmod";
    public static final String VERSION = "1.0";

    @EventHandler
    public void preInit(FMLInitializationEvent event)
    {
        System.out.println("Started Pre-Init!");
        
        

    }

    @EventHandler
    public void init(FMLInitializationEvent event)
    {
        ModItems.preinit();
        
        System.out.println("Started Init!");
       ModItems.registerRenders();
    }

    @EventHandler
    public void postInit(FMLInitializationEvent event)
    {
        System.out.println("Started PostInit!");
    }
}

 

obsidiansword.json

{
    "parent": "item/generated",
    "textures":{
        "layer0":"basicmod:items/obsidiansword" 
    }
}

 

My Project Structure:

6fb1c71a78.png

 

Whenever I run it I get this in the log:

 

  Reveal hidden contents

 

For some reason it seems to think the json is in item.item which doesn't exist. But I've tried making another folder called item and adjusting it and it still gives exactly the same error.

 

I've been following multiple tutorials so I'm sure I've done a billion things wrong.

 

If anyone could help it would be greatly appreciated!

 

 

Draco18s Reality Controller

Draco18s

Posted
Posted

1) You didn't actually include ModItems, you pasted a second copy of your obsidian sword.

2) Caused by: java.io.FileNotFoundException: basicmod:models/item/item.obsidiansword.json

 

Your file name doesn't match the resource you told Minecraft to load.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 12/31/2016 at 8:42 PM, Draco18s said:

1) You didn't actually include ModItems, you pasted a second copy of your obsidian sword.

2) Caused by: java.io.FileNotFoundException: basicmod:models/item/item.obsidiansword.json

 

Your file name doesn't match the resource you told Minecraft to load.

1. oops! My mistake! Fixed on the thread now.

2. So my file is actually called "item.obsidiansword" instead of being obsidiansword in the package item? I don't see where I've managed to do that though... Is it the unlocalized name?

Draco18s Reality Controller

Draco18s

Posted
Posted

It's because you used the unlocalized name, yes.  You should change this:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));

To:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(i.getRegistryName(), "inventory"));

getRegistryName() automatically appends your Mod ID (and honestly, your unlocalized name should too, e.g. 

someItem.setUnlocalizedName(someItem.getRegistryName())

).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 12/31/2016 at 8:48 PM, Draco18s said:

It's because you used the unlocalized name, yes.  You should change this:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(BasicMod.MODID + ":" + i.getUnlocalizedName(), "inventory"));

To:

ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(i.getRegistryName(), "inventory"));

getRegistryName() automatically appends your Mod ID (and honestly, your unlocalized name should too, e.g. 

someItem.setUnlocalizedName(someItem.getRegistryName())

).

 

Thanks, that fixed the errors but I still can't see my texture... Is there anything wrong with my json file?

Draco18s Reality Controller

Draco18s

Posted
Posted

Post the new error log.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 3:03 PM, Jazzable said:

What exactly does your item look like in the game? Is it a cube or a flat square? Presumably you mean that it is showing the purple/black squares texture?

It's a cube with purple and black squares. There is nothing in the logs, no errors or anything.

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 3:24 PM, diesieben07 said:

ModelLoader.setCustomModelResourceLocation must be called in 

ModelRegistryEvent

.

It isn't being fired for some reason:

 

Events Class:

package com.coal;

import com.coal.item.ModItems;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class BasicEvents {
    @SubscribeEvent
    public void onModelRegistry(ModelRegistryEvent event){
        System.out.println("======================="
                + "========================="
                + "Models Registered! "
        );
       ModItems.registerRenders();
    }
}

 

Main:

package com.coal;



import com.coal.item.ModItems;
import static com.coal.item.ModItems.obsidianSword;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.FMLCommonHandler;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


@Mod(modid = BasicMod.MODID, version = BasicMod.VERSION)
public class BasicMod
{
    public static final String MODID = "basicmod";
    public static final String VERSION = "1.0";

    BasicEvents events = new BasicEvents();
    
    @EventHandler
    public void preInit(FMLInitializationEvent event)
    {
        System.out.println("Started Pre-Init!");
        MinecraftForge.EVENT_BUS.register(events);

    }

    @EventHandler
    public void init(FMLInitializationEvent event)
    {
        ModItems.preinit();
        
       System.out.println("Started Init!");
       //ModItems.registerRenders();
       System.out.println(obsidianSword.getUnlocalizedName());
    }

    @EventHandler
    public void postInit(FMLInitializationEvent event)
    {
        System.out.println("Started PostInit!");
    }
    
    
}

 

Have I registered it incorrectly?

 

 

 

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 4:19 PM, diesieben07 said:

preInit is too late to register for that event. You have to either subscribe to it from your 

@Mod

class' constructor or (much cleaner) use 

@EventBusSubscriber

.

How do I use EventBusSubscriber? I've tried this:

 

@EventBusSubscriber(new BasicEvents())

Which informs me that BasicEvents() cannot be converted to side.

 

Same error when I try this:

 

@EventBusSubscriber(MinecraftForge.EVENT_BUS.register(new BasicEvents()))

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 4:47 PM, diesieben07 said:

You know how annotations work, yes?

 

I suggest you read the documentation.

So I added @Mod.EventBusSubscriber to the top of my events class and I still have nothing in the console which I printed and there is no texture either.

 

This is what the class looks like:

package com.coal;

import com.coal.item.ModItems;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


@Mod.EventBusSubscriber
public class BasicEvents {
    @SubscribeEvent
    public void onModelRegistry(ModelRegistryEvent event){
        System.out.println("======================="
                + "========================="
                + "Model Registered! "
        );
       ModItems.registerRenders();
    }
}

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 5:30 PM, diesieben07 said: 

@EventBusSubscriber

adds the class to the EventBus, not an instance (like it says in the documentation). Read the linked documentation again to understand what the difference is. Then look at your code and it should be obvious.

So I made the method static and apparently it's worked but I'm encountering this error that I had a while back:

 

 

  Reveal hidden contents

 

 

I looked this up before and it said it was because there was no unlocalized name until it reached the init or something like that. It uses registry name now but the same principle may apply.

 

Or it's something else.

Hexadecimal Tree Puncher

Hexadecimal

Posted
  • Author
Posted
  On 1/1/2017 at 6:56 PM, diesieben07 said:

These rendering registration methods are entirely client side. You cannot have them in common code, 

ModItems

is common code (i.e. loaded on the server and the client). This will crash a dedicated server, since it has no idea wtf a "model" or a "texture" is.

 

You get this exception because you create and register your items in init. You should be creating them in the field initializer (see below for an example) and register them in 

RegistryEvent.Register<Item>

. You use this event in the same fashion as 

ModelRegistryEvent

.

 

Example for above:

 

public static final Item myItem = new MyItem();

 

Thank you very much. It works now and I can see the texture.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • MoonDrop14
      Modded Minecraft 1.12.2 crash, need help

      By MoonDrop14 · Posted

      Okay so I went to a different version of that mod and it booted right up, thank you
    • TileEntity
      Modded Minecraft 1.12.2 crash, need help

      By TileEntity · Posted

      C:\Users\bruiser\curseforge\minecraft\Instances\Fazbear Remnants\essential\loader\stage1\launchwrapper\stage2.forge_1.12.2.jar: The process cannot access the file because it is being used by another process. Restart your system and test it again If there is no change, delete the mentioned essential folder or remove the mod essential
    • TileEntity
      Game crashes on 1.12.2 with exit code 6

      By TileEntity · Posted

      Does it work with newer versions? For 1.16.5 also make a test with Embeddium + Oculus as Optifine replacement
    • joshua123
      Temu Coupon Code $100 Off [acs670886] For New Users

      By joshua123 · Posted

      Looking for the best Temu coupon code $100 off? You’re in the right place! We’ve got the ultimate deal that helps you save big on your favorite items. Our exclusive ACS670886 Temu coupon code is perfect for shoppers in the USA, Canada, and Europe. Whether you're a new or existing customer, this code ensures you get maximum benefits. By using the Temu coupon $100 off, you can unlock exciting savings on Temu’s vast collection. Don’t miss this chance to claim your Temu 100 off coupon code today! What Is The Coupon Code For Temu $100 Off? Both new and existing customers can enjoy incredible benefits with our Temu coupon $100 off on the Temu app and website. This $100 off Temu coupon ensures huge savings for everyone! ACS670886 – Get a flat $100 off on selected purchases. ACS670886 – Unlock a $100 coupon pack for multiple uses. ACS670886 – Enjoy a $100 flat discount if you're a new customer. ACS670886 – Existing customers can claim an extra $100 promo code. ACS670886 – This $100 coupon is valid for shoppers in the USA and Canada. Temu Coupon Code $100 Off For New Users In 2025 New users can maximize their savings by applying our Temu coupon $100 off on the Temu app. This Temu coupon code $100 off unlocks amazing deals for first-time shoppers. ACS670886 – Get a flat $100 discount for new users. ACS670886 – Receive a $100 coupon bundle as a welcome offer. ACS670886 – Unlock up to $100 in coupons for multiple uses. ACS670886 – Enjoy free shipping to 68 countries. ACS670886 – Get an extra 30% off on any purchase as a first-time user. How To Redeem The Temu Coupon $100 Off For New Customers? Using the Temu $100 coupon is easy! Follow these steps to redeem your Temu $100 off coupon code for new users: Sign up on the Temu app or website. Browse and add your favorite items to the cart. Enter ACS670886 at checkout. See the $100 discount applied instantly. Complete your purchase and enjoy your savings! Temu Coupon $100 Off For Existing Customers Existing customers can also benefit from our exclusive Temu $100 coupon codes for existing users. Use this Temu coupon $100 off for existing customers free shipping deal and save more! ACS670886 – Get an extra $100 discount for existing users. ACS670886 – Enjoy a $100 coupon bundle for multiple purchases. ACS670886 – Receive a free gift with express shipping across the USA/Canada. ACS670886 – Grab an extra 30% off on top of existing discounts. ACS670886 – Avail free shipping to 68 countries. How To Use The Temu Coupon Code $100 Off For Existing Customers? Redeeming your Temu coupon code $100 off as an existing user is simple. Just follow these steps: Log in to your Temu account. Select your desired products and add them to your cart. Apply ACS670886 at checkout. Your Temu coupon $100 off code will be applied automatically. Confirm your order and enjoy massive savings! Latest Temu Coupon $100 Off First Order First-time buyers get the best deals with our Temu coupon code $100 off first order. This Temu coupon code first order ensures maximum savings. ACS670886 – Flat $100 discount for the first order. ACS670886 – Special $100 Temu coupon code for new customers. ACS670886 – Get up to $100 in coupons for multiple uses. ACS670886 – Free shipping to 68 countries. ACS670886 – Extra 30% off on any first-time purchase. How To Find The Temu Coupon Code $100 Off? Finding a Temu coupon $100 off is easy! Check out the Temu coupon $100 off Reddit section or follow these tips: Subscribe to the Temu newsletter for exclusive deals. Follow Temu’s official social media pages for the latest updates. Visit trusted coupon sites for verified and working codes. Is Temu $100 Off Coupon Legit? Yes, our Temu $100 Off Coupon Legit and verified! Wondering if the Temu 100 off coupon legit? Here’s why: The ACS670886 code is officially tested and confirmed. Valid for all customers in the USA, Canada, and Europe. No expiration date—use it anytime! How Does Temu $100 Off Coupon Work? The Temu coupon code $100 off first-time user works instantly upon applying at checkout. Simply enter the Temu coupon codes 100 off, and the discount is automatically deducted. How To Earn Temu $100 Coupons As A New Customer? To earn a Temu coupon code $100 off, sign up on Temu, make your first purchase, and refer friends. This 100 off Temu coupon code can be unlocked through special promotions. What Are The Advantages Of Using The Temu Coupon $100 Off? $100 discount on the first order $100 coupon bundle for multiple uses 70% discount on popular items Extra 30% off for existing customers Up to 90% off on selected products Free gifts for new users Free delivery to 68 countries Temu $100 Discount Code And Free Gift For New And Existing Customers Enjoy the Temu $100 off coupon code and get amazing benefits! Our $100 off Temu coupon code ensures huge savings. ACS670886 – $100 discount for the first order. ACS670886 – Extra 30% off on any item. ACS670886 – Free gift for new Temu users. ACS670886 – Up to 70% discount on all Temu items. ACS670886 – Free shipping in 68 countries including the USA and UK. Final Note: Use The Latest Temu Coupon Code $100 Off Using the Temu coupon code $100 off is the smartest way to save on Temu! Don’t wait—grab your discount now. Our Temu coupon $100 off is available for all customers, ensuring maximum savings. Get yours today! FAQs Of Temu $100 Off Coupon Q: How can I get the Temu $100 off coupon? A: Use code ACS670886 at checkout to claim your $100 discount. Q: Is the Temu $100 coupon valid for existing customers? A: Yes! Existing users can also apply ACS670886 and enjoy savings. Q: Does the Temu $100 off coupon have an expiration date? A: No, ACS670886 is valid indefinitely. Q: Can I use the Temu coupon on multiple orders? A: Yes! ACS670886 allows multiple redemptions. Q: Is the Temu $100 coupon applicable worldwide? A: Yes, it’s valid in the USA, Canada, Europe, and 68 other countries.
    • Lordpun
      Game crashes on 1.12.2 with exit code 6

      By Lordpun · Posted

      I tried both Vanilla and Optfine like you said, and both gave the same result. So I believe the issue is most likely with Minecraft in general and not Forge

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept