{SOLVED}[1.10.2]Updating Blockstate on neighbor Change problem

[Bitterholz]

Hi, Quick Question:

How do i enforce an update to the Blockstate when a neighboring block is changed?

 

My Pipe System currently doesnt update its model Correctly if neighboring Pipes are being placed.

 

AKA they are very lazy in updating their State.

 

Any tips?

[Bitterholz]

This is a Network of 2 Pipes just been placed. They connect up perfectly.

 

Now when I add in another Pipe:

Watch how the New Pipe sets its connection accordingly, while the 2 older ones remain unchanged.

 

Now if i add ANOTHER one like this:

See how it Updates the Oldest Pipe but does not form a connection to the newest one.

 

[Bitterholz]

What do you have right now? You might be able to use Block#onNeighborChanged (I might be wrong about the name, I don't have Eclipse on this computer...) or something like that in your block class. Then check

if (worldIn.getBlockState(pos).getBlock == ModBlocks.PIPE_THINGY)

and if the neighbor block is a PIPE_THINGY (replace this with your pipe's name ), then do Block#scheduleUpdate (again, it's something like this, but I don't have access to Eclipse right now...). This seems like an interesting thing to work on, so good luck!

 

Also, side question, do you have working ItemBlock models for your pipes? I have been fighting with this for a few months now....

 

Trying with

@Override
public void onNeighborChange(IBlockAccess world, BlockPos pos, BlockPos neighbor) {
	this.requiresUpdates();
}

right now. lets hope thats a success.

 

Also if you mean "Item renders its OBJ model in the hand/UI, then Yes, my Pipe does render its model in hand.

[Bitterholz]

Sadly no change with requiresUpdate();

 

Pipe Block Code:

 

public class PipeBasic extends BlockGenericPipe implements ITileEntityProvider{

public PipeBasic() {
	super(Material.IRON);
	setUnlocalizedName(References.NAME_PIPE_BASIC);
	setRegistryName(References.RN_PIPE_BASIC);
	setCreativeTab(CreativeTabs.TRANSPORTATION);

}

@Override
@SideOnly(Side.CLIENT)
public void initModel() {
	ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(this), 0, new ModelResourceLocation(getRegistryName(), "inventory"));

}

@Override
public IBlockState getExtendedState(IBlockState state, IBlockAccess world, BlockPos pos) {
	if(world.getTileEntity(pos) != null && world.getTileEntity(pos) instanceof TileBasicPipe) {
		TileBasicPipe te = (TileBasicPipe)world.getTileEntity(pos);
		te.checkConnections(world, pos);
		return ((IExtendedBlockState) state).withProperty(Properties.AnimationProperty, te.state);
	}
	return state;
}

@Override
public void onNeighborChange(IBlockAccess world, BlockPos pos, BlockPos neighbor) {
	TileBasicPipe te = (TileBasicPipe)world.getTileEntity(pos);
	te.checkConnections(world, pos);
	this.requiresUpdates();
}



@Override
@SideOnly(Side.CLIENT)
public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess worldIn, BlockPos pos, EnumFacing side) {return false;}

@Override
public boolean isBlockNormalCube(IBlockState state) {return false;}

@Override
public boolean isOpaqueCube(IBlockState state) {return false;}

@Override
    public boolean isVisuallyOpaque() { return false; }

@Override
public int getMetaFromState(IBlockState state) {return 0;}

@Override
public boolean hasTileEntity() {return true;}

@Override
public TileEntity createNewTileEntity(World worldIn, int meta) {
	return new TileBasicPipe();
}

@Override
public BlockStateContainer createBlockState() {
	return new ExtendedBlockState(this, new IProperty[0], new IUnlistedProperty[] {Properties.AnimationProperty});
}

}

 

 

Tile Code

 

public class TileBasicPipe extends TileEntity{

private final List<String> hidden = new ArrayList<String>();
public final IModelState state = new IModelState()
{
	private final Optional<TRSRTransformation> value = Optional.of(TRSRTransformation.identity());

	@Override
	public Optional<TRSRTransformation> apply(Optional<? extends IModelPart> part)
        {
            if(part.isPresent())
            {
                // This whole thing is subject to change, but should do for now.
                UnmodifiableIterator<String> parts = Models.getParts(part.get());
                if(parts.hasNext())
                {
                    String name = parts.next();
                    // only interested in the root level
                    if(!parts.hasNext() && hidden.contains(name))
                    {
                        return value;
                    }
                }
            }
            return Optional.absent();
        }

};


@Override
public NBTTagCompound getUpdateTag() {return writeToNBT(new NBTTagCompound());}

@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	NBTTagCompound nbtTag = new NBTTagCompound();
	this.writeToNBT(nbtTag);
	return new SPacketUpdateTileEntity(getPos(), 1, nbtTag);
}

@Override
    public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity packet) {
        this.readFromNBT(packet.getNbtCompound());
    }

@Override
    public void readFromNBT(NBTTagCompound compound) {super.readFromNBT(compound);}

@Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        super.writeToNBT(compound);
        
        return compound;
    }

public boolean canConnect(IBlockAccess world, BlockPos pos) {
	TileEntity te = world.getTileEntity(pos);
	return (te instanceof TileBasicPipe);
}

public void checkConnections(IBlockAccess world, BlockPos pos) {
	hidden.add("CUP");
	hidden.add("CDOWN");
	hidden.add("CNORTH");
	hidden.add("CSOUTH");
	hidden.add("CEAST");
	hidden.add("CWEST");
	hidden.add("GUP");
	hidden.add("GDOWN");
	hidden.add("GNORTH");
	hidden.add("GWEST");
	hidden.add("GSOUTH");
	hidden.add("GEAST");
	hidden.add("GCENTER");


	//North Connection
	if(canConnect(world, pos.north())) {
		//if(hidden.contains("UP"))
			hidden.remove(Connections.NORTH.toString());
	}
	else {hidden.add(Connections.NORTH.toString());}

	//South Connection
	if(canConnect(world, pos.south())) {
		//if(hidden.contains("DOWN"))
			hidden.remove(Connections.SOUTH.toString());
	}
	else{hidden.add(Connections.SOUTH.toString());}

	//East Connection
	if(canConnect(world, pos.east())) {
		//if(hidden.contains("EAST"))
			hidden.remove(Connections.EAST.toString());
	}
	else{hidden.add(Connections.EAST.toString());}

	//West Connection
	if(canConnect(world, pos.west())) {
		//if(hidden.contains("WEST"))
			hidden.remove(Connections.WEST.toString());
	}
	else{hidden.add(Connections.WEST.toString());}

	//Up Connection
	if(canConnect(world, pos.up())) {
		//if(hidden.contains("SOUTH"))
			hidden.remove(Connections.UP.toString());
	}
	else{hidden.add(Connections.UP.toString());}

	//Down Connection
	if(canConnect(world, pos.down())) {
		//if(hidden.contains("NORTH"))
			hidden.remove(Connections.DOWN.toString());
	}
	else{hidden.add(Connections.DOWN.toString());}

	this.markDirty();
}	
}

 

 

[Draco18s]

I don't know why you're calling requiresUpdates(). It doesn't do anything:

 

    public boolean requiresUpdates()
    {
        return true;
    }

 

You need to call these, from your TE, so that the TE data is synced back to the client and the block is re-rendered:

		worldObj.markBlockRangeForRenderUpdate(pos, pos);
	worldObj.notifyBlockUpdate(pos, getState(), getState(), 3);
	worldObj.scheduleBlockUpdate(pos,this.getBlockType(),0,0);
	markDirty();

[Bitterholz]

@Draco18s

Does the Tile have to be ITickable for that?

 

ive added those calls to my checkConnections(), but it didnt change anything about the behavior.

 

Also what do you refer to with

getState()

?

[Draco18s]

@Draco18s

Does the Tile have to be ITickable for that?

 

No.

 

Also what do you refer to with

getState()

?

 

getState just does this:

 

	private IBlockState getState() {
	return worldObj.getBlockState(pos);
}

 

I did it as sort of a replacement for 1.7's getMetadata() method.  You don't really need it as long as you in-line its functionality.

[Bitterholz]

I see...

 

Well, now im doing

if(worldObj.isRemote) {
		this.worldObj.markBlockRangeForRenderUpdate(this.pos, this.pos);
		this.worldObj.notifyBlockUpdate(pos, getState(), getState(), 3);
		this.worldObj.scheduleBlockUpdate(this.pos, this.getBlockType(), 0, 0);

		markDirty();
	}

At the end of checkConnections()

 

The Pipes do Update their State, but it does by no means happen immediately as i place a neighboring Pipe.

rather just happens slowly over time.

[Draco18s]

Did I tell you to wrap it in an if(worldObj.isRemote) check?

[Bitterholz]

Oh that was just me trying to see if it makes a difference(Hint it doesnt)

 

Both times updates DO happen most of the time but they happen awfully slow.

Sometimes no update occurs

 

[Draco18s]

I'm not sure then. My own TE-valued-states work just fine.

[Bitterholz]

Logging the calls of the State changes i found out that adding a new pipe to an existing network causes a massive spam of state updates...

[Bitterholz]

Allright, i figured out i had a derp in my Code, where i was constantly trying to hide parts of the model, spamming the hiding list with entries

all fixed now, stuff behaves beautifully!