(Solved) [1.11] Replacing block with another block

[Rohzek]

How would one go about stopping the spawn of a vanilla block, say, the Pumpkin and replacing it with a modded block? On world generation, that is, not on growing.

[Koward]

Hi,

You could subscribe to DecorateBiomeEvent.Decorate and check event.getType() to PUMPKIN.

It triggers before all pumpkins in the chunk. So you cancel it with setResult, then you do whatever you want.

[Rohzek]

So, I can block the spawn with:

setResult(Result.DENY);

 

That actually didn't seem to block them from spawning, for some reason.

[Koward]

  On 1/7/2017 at 1:34 PM, Rohzek said:

So, I can block the spawn with:

setResult(Result.DENY);

 

That actually didn't seem to block them from spawning, for some reason.

 

Could you show the code where you catch the event ?

[Draco18s]

Mind that will only work for things like pumpkins. If you wanted to replace--say--cobblestone in villages, you'd have a much harder time.

[Rohzek]

  On 1/7/2017 at 2:36 PM, Koward said:

Could you show the code where you catch the event ?

@Mod.EventBusSubscriber
public class DecorateBiomeEventSP 
{
@SubscribeEvent
public static void onDecorateBiome(DecorateBiomeEvent.Decorate event)
{
	World world = event.getWorld();
	BlockPos pos = event.getPos();
	EventType type = event.getType();

	if(type == EventType.PUMPKIN)
	{
		event.setResult(Result.DENY);
		world.setBlockState(pos, SPBlocks.PUMPKIN_SP.getDefaultState());
	}
}
}

  Quote

Mind that will only work for things like pumpkins. If you wanted to replace--say--cobblestone in villages, you'd have a much harder time.

 

I'm only replacing the melons and pumpkins. The melons use the same texture so I just changed the drop you get with the harvest drops event to my custom one, but my custom pumpkin removes the face (and will make you carve one on, to get the vanilla pumpkin... unless I can make a custom block work to spawn the snow golem) so I'm trying to replace them.

[Rohzek]

You know what? It needed to be registered on the terrain event bus, not the event bus. Now, it's working but my attempt at placing my own block in it's place crashes.

World world = event.getWorld();
BlockPos pos = event.getPos();
EventType type = event.getType();

if(type == EventType.PUMPKIN)
{
event.setResult(Result.DENY);
if(!world.isRemote)
{
	LogHelper.debug("I blocked a pumpkin spawn");
	world.setBlockState(pos, SPBlocks.PUMPKIN_SP.getDefaultState());
}
}

 

EDIT:

 

Because the pos it always spits out, is at y level 0. I'm quite confused here.

[Koward]

As I said the event is triggered once before all pumpkins are generated in chunk. Not for each pumpkin.

You have to mimic the way pumpkins are generated.

In vanilla (note : build 1.10.2 2185, check if it's the same for you, it's in BiomeDecorator.java), that is :

        if (random.nextInt(32) == 0)
        {
            int i5 = random.nextInt(16) + 8;
            int k9 = random.nextInt(16) + 8;
            int j13 = worldIn.getHeight(this.chunkPos.add(i5, 0, k9)).getY() * 2;

            if (j13 > 0)
            {
                int k16 = random.nextInt(j13);
                (new WorldGenPumpkin()).generate(worldIn, random, this.chunkPos.add(i5, k16, k9));
            }
        }

(Use the random of the Decorate event, else you'll break seeds).

 

I found this by looking with my IDE where the Decorate event was called, and I saw the one where the type PUMPKIN is checked.

If you paste this code in your event, vanilla pumpkins will generate. Now if you want something different, you have to create a new WorldGenPumpkin. Just extend it and override the methods you need (probably at least generate() as it's called there).

 

The pos that's given by the event are coordinates of the chunk (or at least the chunk cross-shaped intersection, but that's the idea). So it's basically a position on a 2D map seen from above, and a y value would be meaningless. That's why y = 0. Anyway you do not need it for pumpkins.

If you wanted to edit trees that would have been trickier because some data used to calculate them are not passed to the event, but for pumpkins everything seems okay.

[Rohzek]

Okay, yeah thanks.

 

I made my own WorldGenPumpkin to spawn my mod block, and dropped it in with that, and it worked.

(You sort of need it for the pumpkins. The event pos replaces this.chunkpos in that generation command)