Renamed: Figured out most of villagers, need help ironing out bugs

OrangeVillager61 · January 29, 2017

That should work, yes.

Okay, but I've been getting this error:

Failed to save chunk
net.minecraft.util.ReportedException: Saving entity NBT
at net.minecraft.entity.Entity.writeToNBT(Entity.java:1877) ~[Entity.class:?]
at net.minecraft.entity.Entity.writeToNBTOptional(Entity.java:1760) ~[Entity.class:?]
at net.minecraft.world.chunk.storage.AnvilChunkLoader.writeChunkToNBT(AnvilChunkLoader.java:394) ~[AnvilChunkLoader.class:?]
at net.minecraft.world.chunk.storage.AnvilChunkLoader.saveChunk(AnvilChunkLoader.java:191) [AnvilChunkLoader.class:?]
at net.minecraft.world.gen.ChunkProviderServer.saveChunkData(ChunkProviderServer.java:209) [ChunkProviderServer.class:?]
at net.minecraft.world.gen.ChunkProviderServer.saveChunks(ChunkProviderServer.java:237) [ChunkProviderServer.class:?]
at net.minecraft.world.WorldServer.saveAllChunks(WorldServer.java:1065) [WorldServer.class:?]
at net.minecraft.server.MinecraftServer.saveAllWorlds(MinecraftServer.java:425) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.saveAllWorlds(IntegratedServer.java:238) [integratedServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:141) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]
Caused by: java.lang.IllegalArgumentException: Empty string not allowed
at net.minecraft.nbt.NBTTagString.<init>(NBTTagString.java:23) ~[NBTTagString.class:?]
at net.minecraft.nbt.NBTTagCompound.setString(NBTTagCompound.java:158) ~[NBTTagCompound.class:?]
at orangeVillager61.ImprovedVillagers.Entities.VillagerStorages.writeNBT(VillagerStorages.java:25) ~[VillagerStorages.class:?]
at orangeVillager61.ImprovedVillagers.Entities.VillagerStorages.writeNBT(VillagerStorages.java:1) ~[VillagerStorages.class:?]
at orangeVillager61.ImprovedVillagers.Entities.VillagerProvider.serializeNBT(VillagerProvider.java:53) ~[VillagerProvider.class:?]
at net.minecraftforge.common.capabilities.CapabilityDispatcher.serializeNBT(CapabilityDispatcher.java:123) ~[CapabilityDispatcher.class:?]
at net.minecraft.entity.Entity.writeToNBT(Entity.java:1846) ~[Entity.class:?]
... 11 more

Choonster · January 29, 2017

You can't create an

NBTTagString

with a

null

value, so you can't call

NBTTagCompound#setString

with a

null

value.

Only call

NBTTagCompound#setString

if the name value isn't

null

.

OrangeVillager61 · January 31, 2017

Okay, also, do I need to do anything to the render the villagers other than

		ResourceLocation resourceLocation1 = new ResourceLocation("iv", "villager");
	EntityRegistry.registerModEntity(resourceLocation1, IvVillager.class, "IvVillager", 0, Iv.instance, 32, 1, true);

Choonster · January 31, 2017

EntityRegistry.registerModEntity

isn't really related to rendering, but it is required to register your entity class using it.

If you don't explicitly register a

Render

for your entity class, Minecraft will use the one for the super class.

OrangeVillager61 · January 31, 2017

EntityRegistry.registerModEntity
isn't really related to rendering, but it is required to register your entity class using it.

If you don't explicitly register a
Render
for your entity class, Minecraft will use the one for the super class.

Alright, and how do I know if it is using the Villager renderer?

OrangeVillager61 · February 1, 2017

Okay, I seem to have fixed most bugs but I have two major issues, firstly when overriding a villager, there's a around 50% chance it doesn't override and the original entity turns into a strange thing that looks like a villager but doesn't behave like an entity and I can go through it and doesn't obey the las of gravity.

Also, the overrided villager doesn't gain a name until I reload the game.

public class OverrideVillagers {
@SubscribeEvent
public void entityJoinedWorldEventHandler(EntityJoinWorldEvent event)
{
	if (event.getEntity().getClass() == EntityVillager.class && Config.overwriteOriginalVillagers == 0)
	{
		event.getEntity().setDead();
		doOverwriteVillager(event, (EntityVillager) event.getEntity());
	}
}

private void doOverwriteVillager(EntityJoinWorldEvent event, EntityVillager entity) 
{
	if (entity.getProfession() >= 0 && entity.getProfession() <= 4)
	{
		IvVillager entityVillager = new IvVillager(entity.getWorld(), entity.getProfession());
		entityVillager.setGrowingAge(entity.getGrowingAge());
		entityVillager.onInitialSpawn(event.getWorld().getDifficultyForLocation(new BlockPos(entity)), (IEntityLivingData)null);
		entityVillager.setLocationAndAngles(entity.posX, entity.posY, entity.posZ, 0.0F, 0.0F);
		event.getWorld().setEntityState(entityVillager, (byte)12); 
		event.getWorld().spawnEntity(entityVillager); 

	}
}
}

OrangeVillager61 · February 1, 2017

You must not spawn entities on the client.

Okay, but this doesn't fix that it needs a relog for the villagers to gain names.

OrangeVillager61 · February 9, 2017

So, how to not need a reload for the villagers to gain names?

OrangeVillager61 · February 9, 2017

2 hours ago, diesieben07 said:

Post your villager class.

public class IvVillager extends EntityVillager{
	
	protected Village villageObj; 
	public String name;
	public int Gender;
    protected boolean isWillingToMate;
    protected int wealth;
    private MerchantRecipeList buyingList;
    private String lastBuyingPlayer;
    private int careerId;
    private int careerLevel;
    private boolean isLookingForHome;
    private boolean areAdditionalTasksSet;
    private final InventoryBasic villagerInventory;
    Random r = new Random();
    /** A multi-dimensional array mapping the various professions, careers and career levels that a Villager may offer */
	protected String[] male_list = {"Bob", "Joseph", "Aaron", "Philp", "Adam", "Paul", "Donald", "Ryan", 
									"Mark", "Brian", "Robert", "Willam", "Harold", "Anthony", "Julius", 
									"Mathew", "Tyler", "Noah", "Patrick", "Caden", "Michael", "Jeffery",
									"James", "John", "Thomas", "Otto", "Bill", "Sheldon", "Leonard", 
									"Howard", "Carter", "Theodore", "Herbert"};
	protected String[] female_list = {"Karen", "Lessie", "Kayla", "Brianna", "Isabella", "Elizabeth",
									  "Kira", "Jadzia", "Abigail", "Chloe", "Olivia", "Sophia", "Emily", 
									  "Charlotte", "Amelia", "Maria", "Daria", "Sarah", "Theodora",
									  "Tia", "Jennifer", "Anglica", "Denna", "Tasha", "Catherine", "Lily",
									  "Amy", "Penny", "Julina", "Audrey", "Avery"};
	
	public IvVillager(World world) {
		super(world);
        this.villagerInventory = new InventoryBasic("Items", false, 8);
	}
	public IvVillager(World world, int professionId) {
		super(world, professionId);
	    this.setProfession(professionId);
        this.villagerInventory = new InventoryBasic("Items", false, 8);
	}
	public InventoryBasic getVillagerInventory()
    {
        return this.villagerInventory;
    }
	 @Override
	 public void writeEntityToNBT(NBTTagCompound compound)
	    {
	        super.writeEntityToNBT(compound);
	        compound.setInteger("Profession", this.getProfession());
	        compound.setString("ProfessionName", this.getProfessionForge().getRegistryName().toString());
	        compound.setInteger("Riches", this.wealth);
	        compound.setInteger("Career", this.careerId);
	        compound.setInteger("CareerLevel", this.careerLevel);
	        compound.setBoolean("Willing", this.isWillingToMate);

	        if (this.buyingList != null)
	        {
	            compound.setTag("Offers", this.buyingList.getRecipiesAsTags());
	        }

	        NBTTagList nbttaglist = new NBTTagList();

	        for (int i = 0; i < this.getVillagerInventory().getSizeInventory(); ++i)
	        {
	            ItemStack itemstack = this.villagerInventory.getStackInSlot(i);

	            if (!itemstack.isEmpty())
	            {
	                nbttaglist.appendTag(itemstack.writeToNBT(new NBTTagCompound()));
	            }
	        }

	        compound.setTag("Inventory", nbttaglist);
	        if (world.isRemote == false){
	        	IVillagerStorage villagerN = this.getCapability(VillagerProvider.VIL_CAP, null);
	        	villagerN.setGender(this.Gender);
	        	villagerN.setName(this.name);
	        }
	        
	    }
	 @Override
	 public void readEntityFromNBT(NBTTagCompound compound){
		 super.writeEntityToNBT(compound);
		 if (world.isRemote == false){
	         IVillagerStorage villagerN = this.getCapability(VillagerProvider.VIL_CAP, null);
			 this.name = villagerN.getName();
			 this.Gender = villagerN.getGender();
			 this.setCustomNameTag(this.name);
		 }
		 this.setProfession(compound.getInteger("Profession"));
	        if (compound.hasKey("ProfessionName"))
	        {
	            net.minecraftforge.fml.common.registry.VillagerRegistry.VillagerProfession p =
	                net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation(compound.getString("ProfessionName")));
	            if (p == null)
	                p = net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation("minecraft:farmer"));
	            this.setProfession(p);
	        }
	        this.wealth = compound.getInteger("Riches");
	        this.careerId = compound.getInteger("Career");
	        this.careerLevel = compound.getInteger("CareerLevel");
	        this.isWillingToMate = compound.getBoolean("Willing");

	        if (compound.hasKey("Offers", 10))
	        {
	            NBTTagCompound nbttagcompound = compound.getCompoundTag("Offers");
	            this.buyingList = new MerchantRecipeList(nbttagcompound);
	        }

	        NBTTagList nbttaglist = compound.getTagList("Inventory", 10);

	        for (int i = 0; i < nbttaglist.tagCount(); ++i)
	        {
	            ItemStack itemstack = new ItemStack(nbttaglist.getCompoundTagAt(i));

	            if (!itemstack.isEmpty())
	            {
	                this.villagerInventory.addItem(itemstack);
	            }
	        }

	        this.setCanPickUpLoot(true);
	        this.setAdditionalAItasks();
		 
	 }
	 private void populateBuyingList()
	    {
	        if (this.careerId != 0 && this.careerLevel != 0)
	        {
	            ++this.careerLevel;
	        }
	        else
	        {
	            this.careerId = this.getProfessionForge().getRandomCareer(this.rand) + 1;
	            this.careerLevel = 1;
	        }

	        if (this.buyingList == null)
	        {
	            this.buyingList = new MerchantRecipeList();
	        }

	        int i = this.careerId - 1;
	        int j = this.careerLevel - 1;
	        java.util.List<EntityVillager.ITradeList> trades = this.getProfessionForge().getCareer(i).getTrades(j);

	        if (trades != null)
	        {
	            for (EntityVillager.ITradeList entityvillager$itradelist : trades)
	            {
	                entityvillager$itradelist.addMerchantRecipe(this, this.buyingList, this.rand);
	            }
	        }
	    }
    }

}

OrangeVillager61 · February 10, 2017

15 hours ago, diesieben07 said:

You will need to store the name in a DataParameter, not a field, otherwise it will not be synced to the client. Vanilla entities have plenty of examples.

Do I apply this to Capabilities?

OrangeVillager61 · February 10, 2017

2 minutes ago, diesieben07 said:

No, capabilities have to do the syncing manually.

So, in the IvVillager file, I use DataParameter , but in the capabilities I use the same code as before?

OrangeVillager61 · February 10, 2017

3 minutes ago, diesieben07 said:

Define "same code as before".

I mean I leave all of the strings as strings and not DataParamater<String>.

Edited February 10, 2017 by OrangeVillager61

OrangeVillager61 · February 11, 2017

On 2/10/2017 at 1:36 PM, diesieben07 said:

Yes...

Alright, but this causes the villager to be removed...

public class IvVillager extends EntityVillager{
	
	public IvVillager(World world) {
		super(world);
        this.villagerInventory = new InventoryBasic("Items", false, 20);
	}
	public IvVillager(World world, int professionId) {
		super(world, professionId);
	    this.setProfession(professionId);
        this.villagerInventory = new InventoryBasic("Items", false, 20);
	}
	public InventoryBasic getVillagerInventory()
    {
        return this.villagerInventory;
    }
	@Override
	protected void entityInit()
    {
		super.entityInit();
		this.getDataManager().register(Gender, Integer.valueOf(0));
        this.setGender();
		this.getDataManager().register(Name, String.valueOf("None"));
		this.setName();
    }
	@Override
	protected void initEntityAI()
    {
        this.tasks.addTask(0, new EntityAISwimming(this));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityZombie.class, 8.0F, 0.6D, 0.6D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityEvoker.class, 12.0F, 0.8D, 0.8D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityVindicator.class, 8.0F, 0.8D, 0.8D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityVex.class, 8.0F, 0.6D, 0.6D));
        this.tasks.addTask(1, new EntityAITradePlayer(this));
        this.tasks.addTask(2, new EntityAILookAtTradePlayer(this));
        this.tasks.addTask(2, new EntityAIMoveIndoors(this));
        this.tasks.addTask(3, new EntityAIRestrictOpenDoor(this));
        this.tasks.addTask(4, new EntityAITempt(this, 1.25D, Items.EMERALD, false));
        this.tasks.addTask(4, new EntityAIOpenDoor(this, true));
        this.tasks.addTask(5, new EntityAIMoveTowardsRestriction(this, 0.6D));
        this.tasks.addTask(6, new VilsPerDoor(this));
        this.tasks.addTask(7, new EntityAIFollowGolem(this));
        this.tasks.addTask(9, new EntityAIWatchClosest2(this, EntityPlayer.class, 3.0F, 1.0F));
        this.tasks.addTask(9, new EntityAIVillagerInteract(this));
        this.tasks.addTask(9, new EntityAIWanderAvoidWater(this, 0.6D));
        this.tasks.addTask(10, new EntityAIWatchClosest(this, EntityLiving.class, 8.0F));
    }
	public int getGender()
    {
        return ((Integer)this.getDataManager().get(Gender)).intValue();
    }
	public void setGender()
	{
		IVillagerStorage villagerN = this.getCapability(VillagerProvider.VIL_CAP, null);
		if (this.gender == 0 || this.gender == 1){
			villagerN.setGender(this.gender);
		}
		this.getDataManager().set(Gender, Integer.valueOf(this.gender));
	}
	public String getName()
	{
        return ((String)this.getDataManager().get(Name));
	}
	public void setName()
	{
		IVillagerStorage villagerN = this.getCapability(VillagerProvider.VIL_CAP, null);
		if (this.name != null){
			villagerN.setName(this.name);
		}
		this.getDataManager().set(Name, String.valueOf(this.name));
	}
	private void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
        }
    }
	 @Override
	 public void writeEntityToNBT(NBTTagCompound compound)
	    {
	        super.writeEntityToNBT(compound);
	        compound.setInteger("Profession", this.getProfession());
	        compound.setString("ProfessionName", this.getProfessionForge().getRegistryName().toString());
	        compound.setInteger("Riches", this.wealth);
	        compound.setInteger("Career", this.careerId);
	        compound.setInteger("CareerLevel", this.careerLevel);
	        compound.setBoolean("Willing", this.isWillingToMate);

	        if (this.buyingList != null)
	        {
	            compound.setTag("Offers", this.buyingList.getRecipiesAsTags());
	        }

	        NBTTagList nbttaglist = new NBTTagList();

	        for (int i = 0; i < this.getVillagerInventory().getSizeInventory(); ++i)
	        {
	            ItemStack itemstack = this.villagerInventory.getStackInSlot(i);

	            if (!itemstack.isEmpty())
	            {
	                nbttaglist.appendTag(itemstack.writeToNBT(new NBTTagCompound()));
	            }
	        }

	        compound.setTag("Inventory", nbttaglist);
	        if (world.isRemote == false){
	        	this.setGender();
	        	this.setName();
	        }
	        
	    }
	 @Override
	 public void readEntityFromNBT(NBTTagCompound compound){
		 super.writeEntityToNBT(compound);
		 if (world.isRemote == false){
			 this.getGender();
			 this.getName();
			 this.setCustomNameTag(this.getName());
		 }
		 this.setProfession(compound.getInteger("Profession"));
	        if (compound.hasKey("ProfessionName"))
	        {
	            net.minecraftforge.fml.common.registry.VillagerRegistry.VillagerProfession p =
	                net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation(compound.getString("ProfessionName")));
	            if (p == null)
	                p = net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation("minecraft:farmer"));
	            this.setProfession(p);
	        }
	        this.wealth = compound.getInteger("Riches");
	        this.careerId = compound.getInteger("Career");
	        this.careerLevel = compound.getInteger("CareerLevel");
	        this.isWillingToMate = compound.getBoolean("Willing");

	        if (compound.hasKey("Offers", 10))
	        {
	            NBTTagCompound nbttagcompound = compound.getCompoundTag("Offers");
	            this.buyingList = new MerchantRecipeList(nbttagcompound);
	        }

	        NBTTagList nbttaglist = compound.getTagList("Inventory", 10);

	        for (int i = 0; i < nbttaglist.tagCount(); ++i)
	        {
	            ItemStack itemstack = new ItemStack(nbttaglist.getCompoundTagAt(i));

	            if (!itemstack.isEmpty())
	            {
	                this.villagerInventory.addItem(itemstack);
	            }
	        }

	        this.setCanPickUpLoot(true);
	        this.setAdditionalAItasks();
		 
	 }
	 private void populateBuyingList()
	    {
	        if (this.careerId != 0 && this.careerLevel != 0)
	        {
	            ++this.careerLevel;
	        }
	        else
	        {
	            this.careerId = this.getProfessionForge().getRandomCareer(this.rand) + 1;
	            this.careerLevel = 1;
	        }

	        if (this.buyingList == null)
	        {
	            this.buyingList = new MerchantRecipeList();
	        }

	        int i = this.careerId - 1;
	        int j = this.careerLevel - 1;
	        java.util.List<EntityVillager.ITradeList> trades = this.getProfessionForge().getCareer(i).getTrades(j);

	        if (trades != null)
	        {
	            for (EntityVillager.ITradeList entityvillager$itradelist : trades)
	            {
	                entityvillager$itradelist.addMerchantRecipe(this, this.buyingList, this.rand);
	            }
	        }
	    }
	 @Override
	 public boolean processInteract(EntityPlayer player, EnumHand hand){
		if (world.isRemote == false){
			BlockPos blockpos = new BlockPos(this);
			this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32);

		}
        ItemStack itemstack = player.getHeldItem(hand);
        if (itemstack.getItem() == IvItems.thieving_nose && !this.isChild()){
        	itemstack.damageItem(1, player);
        	this.setHealth(this.getHealth() - 2);
        	this.playHurtSound(getLastDamageSource());
        	if (rand.nextInt(10) + 1 < 6){
        		
        	}
        	if (rand.nextInt(10) + 1 < 9 && rand.nextInt(10) + 1  > 5){
        		this.entityDropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), 0);
        	}
        	if (rand.nextInt(10) + 1 < 10 && rand.nextInt(10) + 1  > 8){
        		this.entityDropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), 0);
        	}
        	if (world.isRemote == false){
        	if (this.villageObj != null)
	            {
	        		this.villageObj.modifyPlayerReputation(player.getName(), -2);
	            }
        	}
            return true;
        }
        else if (!this.holdingSpawnEggOfClass(itemstack, this.getClass()) && this.isEntityAlive() && !this.isTrading() && !this.isChild())
        {
            if (this.buyingList == null)
            {
                this.populateBuyingList();
            }

            if (hand == EnumHand.MAIN_HAND)
            {
                player.addStat(StatList.TALKED_TO_VILLAGER);
            }

            if (!this.world.isRemote && !this.buyingList.isEmpty())
            {
                this.setCustomer(player);
                player.displayVillagerTradeGui(this);
            }
            else if (this.buyingList.isEmpty())
            {
                return super.processInteract(player, hand);
            }

            return true;
        }
        else
        {
            return super.processInteract(player, hand);
        }
    }

}

Edited February 12, 2017 by OrangeVillager61
syntax hightlighting

OrangeVillager61 · February 12, 2017

On 2/11/2017 at 4:45 PM, diesieben07 said:

What do you mean by removed? And do you seriously expect me (or anyone) to know the answer to such a broad question without even being able to run the code?

Okay, sorry. I mean that when I spawn a villager with the code above, the villagers gets removed and has this a NullPointerException:

Quote

[21:31:43] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
   at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_121]
   at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_121]
   at net.minecraft.util.Util.runTask(Util.java:27) [Util.class:?]
   at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:753) [MinecraftServer.class:?]
   at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) [MinecraftServer.class:?]
   at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?]
   at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?]
   at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]
Caused by: java.lang.NullPointerException
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.setGender(IvVillager.java:126) ~[IvVillager.class:?]
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.entityInit(IvVillager.java:92) ~[IvVillager.class:?]
   at net.minecraft.entity.Entity.<init>(Entity.java:252) ~[Entity.class:?]
   at net.minecraft.entity.EntityLivingBase.<init>(EntityLivingBase.java:197) ~[EntityLivingBase.class:?]
   at net.minecraft.entity.EntityLiving.<init>(EntityLiving.java:101) ~[EntityLiving.class:?]
   at net.minecraft.entity.EntityCreature.<init>(EntityCreature.java:22) ~[EntityCreature.class:?]
   at net.minecraft.entity.EntityAgeable.<init>(EntityAgeable.java:27) ~[EntityAgeable.class:?]
   at net.minecraft.entity.passive.EntityVillager.<init>(EntityVillager.java:130) ~[EntityVillager.class:?]
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.<init>(IvVillager.java:79) ~[IvVillager.class:?]
   at orangeVillager61.ImprovedVillagers.OverrideVillagers.doOverwriteVillager(OverrideVillagers.java:27) ~[OverrideVillagers.class:?]
   at orangeVillager61.ImprovedVillagers.OverrideVillagers.entityJoinedWorldEventHandler(OverrideVillagers.java:19) ~[OverrideVillagers.class:?]
   at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_7_OverrideVillagers_entityJoinedWorldEventHandler_EntityJoinWorldEvent.invoke(.dynamic) ~[?:?]
   at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
   at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?]
   at net.minecraft.world.World.spawnEntity(World.java:1291) ~[World.class:?]
   at net.minecraft.world.WorldServer.spawnEntity(WorldServer.java:1125) ~[WorldServer.class:?]
   at net.minecraft.item.ItemMonsterPlacer.spawnCreature(ItemMonsterPlacer.java:251) ~[ItemMonsterPlacer.class:?]
   at net.minecraft.item.ItemMonsterPlacer.onItemUse(ItemMonsterPlacer.java:101) ~[ItemMonsterPlacer.class:?]
   at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:812) ~[ForgeHooks.class:?]
   at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:179) ~[ItemStack.class:?]
   at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:506) ~[PlayerInteractionManager.class:?]
   at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:701) ~[NetHandlerPlayServer.class:?]
   at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
   at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
   at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
   at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_121]
   at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_121]
   at net.minecraft.util.Util.runTask(Util.java:26) ~[Util.class:?]
   ... 5 more
[21:31:43] [Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.entity.EntityJoinWorldEvent@2a3b1ab:
java.lang.NullPointerException
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.setGender(IvVillager.java:126) ~[IvVillager.class:?]
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.entityInit(IvVillager.java:92) ~[IvVillager.class:?]
   at net.minecraft.entity.Entity.<init>(Entity.java:252) ~[Entity.class:?]
   at net.minecraft.entity.EntityLivingBase.<init>(EntityLivingBase.java:197) ~[EntityLivingBase.class:?]
   at net.minecraft.entity.EntityLiving.<init>(EntityLiving.java:101) ~[EntityLiving.class:?]
   at net.minecraft.entity.EntityCreature.<init>(EntityCreature.java:22) ~[EntityCreature.class:?]
   at net.minecraft.entity.EntityAgeable.<init>(EntityAgeable.java:27) ~[EntityAgeable.class:?]
   at net.minecraft.entity.passive.EntityVillager.<init>(EntityVillager.java:130) ~[EntityVillager.class:?]
   at orangeVillager61.ImprovedVillagers.Entities.IvVillager.<init>(IvVillager.java:79) ~[IvVillager.class:?]
   at orangeVillager61.ImprovedVillagers.OverrideVillagers.doOverwriteVillager(OverrideVillagers.java:27) ~[OverrideVillagers.class:?]
   at orangeVillager61.ImprovedVillagers.OverrideVillagers.entityJoinedWorldEventHandler(OverrideVillagers.java:19) ~[OverrideVillagers.class:?]
   at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_7_OverrideVillagers_entityJoinedWorldEventHandler_EntityJoinWorldEvent.invoke(.dynamic) ~[?:?]
   at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
   at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) [EventBus.class:?]
   at net.minecraft.world.World.spawnEntity(World.java:1291) [World.class:?]
   at net.minecraft.world.WorldServer.spawnEntity(WorldServer.java:1125) [WorldServer.class:?]
   at net.minecraft.item.ItemMonsterPlacer.spawnCreature(ItemMonsterPlacer.java:251) [ItemMonsterPlacer.class:?]
   at net.minecraft.item.ItemMonsterPlacer.onItemUse(ItemMonsterPlacer.java:101) [ItemMonsterPlacer.class:?]
   at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:812) [ForgeHooks.class:?]
   at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:179) [ItemStack.class:?]
   at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:506) [PlayerInteractionManager.class:?]
   at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:701) [NetHandlerPlayServer.class:?]
   at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) [CPacketPlayerTryUseItemOnBlock.class:?]
   at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) [CPacketPlayerTryUseItemOnBlock.class:?]
   at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) [PacketThreadUtil$1.class:?]
   at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_121]
   at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_121]
   at net.minecraft.util.Util.runTask(Util.java:26) [Util.class:?]
   at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:753) [MinecraftServer.class:?]
   at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) [MinecraftServer.class:?]
   at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?]
   at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?]
   at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]

OrangeVillager61 · February 12, 2017

6 minutes ago, diesieben07 said:

You have duplication of data, you store the gender both in the data manager and the capability. Pick one.

And then use the debugger to find out what is null on that line and why.

I would normally use a capability but is it possible to use a capability and have the game show the name without reloading?

jeffryfisher · February 14, 2017

On 2/12/2017 at 0:33 PM, OrangeVillager61 said:

Caused by: java.lang.NullPointerException
at orangeVillager61.ImprovedVillagers.Entities.IvVillager.setGender(IvVillager.java:126)

Did you know that you can click on the "126" to go directly to the problem line? Have you set a breakpoint there? Have you used the debugger at all?

As my signature used to say (before the site "upgrade", we had signatures), the debugger is an essential development tool. No matter how weird and mysterious it seems, you must pierce the barrier to its use. Just dive in and start reading its help pages. Once you discover its stepping and its runtime variable examination, you'll wonder how you ever lived without it.

Edited February 14, 2017 by jeffryfisher
What happened to my signature?

Draco18s · February 14, 2017

We still have signatures, just that per-user-settings they are turned off by default.

OrangeVillager61 · February 18, 2017

Okay, so I fixed much of my issues, but the game only displays "None" instead of a name. The game does correctly set names in the WriteNBT but those names don't seem to persist in reloads or actually show. I determined this using printlns.

public class IvVillager extends EntityVillager{
	
	protected Village villageObj; 
	public String name;
	public int gender;
    protected boolean isWillingToMate;
    protected int wealth;
    protected MerchantRecipeList buyingList;
    protected static final DataParameter<String> Name = EntityDataManager.<String>createKey(IvVillager.class, DataSerializers.STRING);
    protected static final DataParameter<Integer> Gender = EntityDataManager.<Integer>createKey(IvVillager.class, DataSerializers.VARINT);
    private int careerId;
    private int careerLevel;
    private boolean isLookingForHome;
    private boolean areAdditionalTasksSet;
    protected final InventoryBasic villagerInventory;
    Random r = new Random();
    /** A multi-dimensional array mapping the various professions, careers and career levels that a Villager may offer */
	protected String[] male_list = {"Bob", "Joseph", "Aaron", "Philp", "Adam", "Paul", "Donald", "Ryan", 
									"Mark", "Brian", "Robert", "Willam", "Harold", "Anthony", "Julius", 
									"Mathew", "Tyler", "Noah", "Patrick", "Caden", "Michael", "Jeffery",
									"James", "John", "Thomas", "Otto", "Bill", "Sheldon", "Leonard", 
									"Howard", "Carter", "Theodore", "Herbert"};
	protected String[] female_list = {"Karen", "Lessie", "Kayla", "Brianna", "Isabella", "Elizabeth",
									  "Kira", "Jadzia", "Abigail", "Chloe", "Olivia", "Sophia", "Emily", 
									  "Charlotte", "Amelia", "Maria", "Daria", "Sarah", "Theodora",
									  "Tia", "Jennifer", "Anglica", "Denna", "Tasha", "Catherine", "Lily",
									  "Amy", "Penny", "Julina", "Audrey", "Avery"};
	
	public IvVillager(World world) {
		super(world);
        this.villagerInventory = new InventoryBasic("Items", false, 20);
	}
	public IvVillager(World world, int professionId) {
		super(world, professionId);
	    this.setProfession(professionId);
        this.villagerInventory = new InventoryBasic("Items", false, 20);
	}
	public InventoryBasic getVillagerInventory()
    {
        return this.villagerInventory;
    }
	@Override
	protected void entityInit()
    {
		super.entityInit();
		this.getDataManager().register(Gender, Integer.valueOf(0));
		this.getDataManager().register(Name, String.valueOf("None"));
    }
	@Override
	protected void initEntityAI()
    {
        this.tasks.addTask(0, new EntityAISwimming(this));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityZombie.class, 8.0F, 0.6D, 0.6D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityEvoker.class, 12.0F, 0.8D, 0.8D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityVindicator.class, 8.0F, 0.8D, 0.8D));
        this.tasks.addTask(1, new EntityAIAvoidEntity(this, EntityVex.class, 8.0F, 0.6D, 0.6D));
        this.tasks.addTask(1, new EntityAITradePlayer(this));
        this.tasks.addTask(2, new EntityAILookAtTradePlayer(this));
        this.tasks.addTask(2, new EntityAIMoveIndoors(this));
        this.tasks.addTask(3, new EntityAIRestrictOpenDoor(this));
        this.tasks.addTask(4, new EntityAITempt(this, 1.25D, Items.EMERALD, false));
        this.tasks.addTask(4, new EntityAIOpenDoor(this, true));
        this.tasks.addTask(5, new EntityAIMoveTowardsRestriction(this, 0.6D));
        this.tasks.addTask(6, new VilsPerDoor(this));
        this.tasks.addTask(7, new EntityAIFollowGolem(this));
        this.tasks.addTask(9, new EntityAIWatchClosest2(this, EntityPlayer.class, 3.0F, 1.0F));
        this.tasks.addTask(9, new EntityAIVillagerInteract(this));
        this.tasks.addTask(9, new EntityAIWanderAvoidWater(this, 0.6D));
        this.tasks.addTask(10, new EntityAIWatchClosest(this, EntityLiving.class, 8.0F));
    }
	public int getGender()
    {
        return ((Integer)this.getDataManager().get(Gender)).intValue();
    }
	public void setGender(int value)
	{
		this.getDataManager().set(Gender, Integer.valueOf(value));
	}
	public String getName()
	{
        return ((String)this.getDataManager().get(Name));
	}
	public void setName(String value)
	{
		this.getDataManager().set(Name, String.valueOf(value));
	}
	private void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
        }
    }
	 @Override
	 public void writeEntityToNBT(NBTTagCompound compound)
	    {
	        super.writeEntityToNBT(compound);
	        compound.setInteger("Profession", this.getProfession());
	        compound.setString("ProfessionName", this.getProfessionForge().getRegistryName().toString());
	        compound.setInteger("Riches", this.wealth);
	        compound.setInteger("Career", this.careerId);
	        compound.setInteger("CareerLevel", this.careerLevel);
	        compound.setBoolean("Willing", this.isWillingToMate);

	        if (this.buyingList != null)
	        {
	            compound.setTag("Offers", this.buyingList.getRecipiesAsTags());
	        }

	        NBTTagList nbttaglist = new NBTTagList();

	        for (int i = 0; i < this.getVillagerInventory().getSizeInventory(); ++i)
	        {
	            ItemStack itemstack = this.villagerInventory.getStackInSlot(i);

	            if (!itemstack.isEmpty())
	            {
	                nbttaglist.appendTag(itemstack.writeToNBT(new NBTTagCompound()));
	            }
	        }

	        compound.setTag("Inventory", nbttaglist);
	        if (world.isRemote == false){
	        	if (this.getGender() != 1 || this.getGender() != 2){
	        		this.gender = r.nextInt(2) + 1;
	        	}
	        	compound.setInteger("Gender", this.gender);
	        	if (this.getName() == null || this.getName() == "None"){
	        		if (this.gender == 1){
	        			this.name = male_list[r.nextInt(male_list.length)];
	        			System.out.println("Male Name");
	        		}
	        		else if (this.gender == 2){
	        			this.name = female_list[r.nextInt(male_list.length)];
	        			System.out.println("Female Name");
	        		}
	        		else if (this.gender != 1|| this.gender != 2){
	        			this.name = "None";
	        			System.out.println("Something went wrong with gender, please report.");
	        			System.out.println("No Name");
	        		}
	        	compound.setString("Name", this.name);
	        	this.setGender(this.gender);
	        	this.setName(this.name);
	        }
	        }
	        
	    }
	 @Override
	 public void readEntityFromNBT(NBTTagCompound compound){
		 super.writeEntityToNBT(compound);
		 if (world.isRemote == false){
			 this.gender = compound.getInteger("Gender");
			 this.name = compound.getString("Name");
			 this.getGender();
			 this.getName();
			 this.setCustomNameTag(this.getName());
		 }
		 this.setProfession(compound.getInteger("Profession"));
	        if (compound.hasKey("ProfessionName"))
	        {
	            net.minecraftforge.fml.common.registry.VillagerRegistry.VillagerProfession p =
	                net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation(compound.getString("ProfessionName")));
	            if (p == null)
	                p = net.minecraftforge.fml.common.registry.VillagerRegistry.instance().getRegistry().getValue(new net.minecraft.util.ResourceLocation("minecraft:farmer"));
	            this.setProfession(p);
	        }
	        this.wealth = compound.getInteger("Riches");
	        this.careerId = compound.getInteger("Career");
	        this.careerLevel = compound.getInteger("CareerLevel");
	        this.isWillingToMate = compound.getBoolean("Willing");

	        if (compound.hasKey("Offers", 10))
	        {
	            NBTTagCompound nbttagcompound = compound.getCompoundTag("Offers");
	            this.buyingList = new MerchantRecipeList(nbttagcompound);
	        }

	        NBTTagList nbttaglist = compound.getTagList("Inventory", 10);

	        for (int i = 0; i < nbttaglist.tagCount(); ++i)
	        {
	            ItemStack itemstack = new ItemStack(nbttaglist.getCompoundTagAt(i));

	            if (!itemstack.isEmpty())
	            {
	                this.villagerInventory.addItem(itemstack);
	            }
	        }

	        this.setCanPickUpLoot(true);
	        this.setAdditionalAItasks();
		 
	 }
	 private void populateBuyingList()
	    {
	        if (this.careerId != 0 && this.careerLevel != 0)
	        {
	            ++this.careerLevel;
	        }
	        else
	        {
	            this.careerId = this.getProfessionForge().getRandomCareer(this.rand) + 1;
	            this.careerLevel = 1;
	        }

	        if (this.buyingList == null)
	        {
	            this.buyingList = new MerchantRecipeList();
	        }

	        int i = this.careerId - 1;
	        int j = this.careerLevel - 1;
	        java.util.List<EntityVillager.ITradeList> trades = this.getProfessionForge().getCareer(i).getTrades(j);

	        if (trades != null)
	        {
	            for (EntityVillager.ITradeList entityvillager$itradelist : trades)
	            {
	                entityvillager$itradelist.addMerchantRecipe(this, this.buyingList, this.rand);
	            }
	        }
	    }
	 @Override
	 public boolean processInteract(EntityPlayer player, EnumHand hand){
		if (world.isRemote == false){
			BlockPos blockpos = new BlockPos(this);
			this.villageObj = this.world.getVillageCollection().getNearestVillage(blockpos, 32);

		}
        ItemStack itemstack = player.getHeldItem(hand);
        if (itemstack.getItem() == IvItems.thieving_nose && !this.isChild()){
        	itemstack.damageItem(1, player);
        	this.setHealth(this.getHealth() - 2);
        	this.playHurtSound(getLastDamageSource());
        	if (rand.nextInt(10) + 1 < 6){
        		
        	}
        	if (rand.nextInt(10) + 1 < 9 && rand.nextInt(10) + 1  > 5){
        		this.entityDropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), 0);
        	}
        	if (rand.nextInt(10) + 1 < 10 && rand.nextInt(10) + 1  > 8){
        		this.entityDropItem(new ItemStack(Items.EMERALD, r.nextInt(2) + 1), 0);
        	}
        	if (world.isRemote == false){
        	if (this.villageObj != null)
	            {
	        		this.villageObj.modifyPlayerReputation(player.getName(), -2);
	            }
        	}
            return true;
        }
        else if (!this.holdingSpawnEggOfClass(itemstack, this.getClass()) && this.isEntityAlive() && !this.isTrading() && !this.isChild())
        {
            if (this.buyingList == null)
            {
                this.populateBuyingList();
            }

            if (hand == EnumHand.MAIN_HAND)
            {
                player.addStat(StatList.TALKED_TO_VILLAGER);
            }

            if (!this.world.isRemote && !this.buyingList.isEmpty())
            {
                this.setCustomer(player);
                player.displayVillagerTradeGui(this);
            }
            else if (this.buyingList.isEmpty())
            {
                return super.processInteract(player, hand);
            }

            return true;
        }
        else
        {
            return super.processInteract(player, hand);
        }
    }

}

Sign In

Renamed: Figured out most of villagers, need help ironing out bugs

Recommended Posts

OrangeVillager61

Choonster

OrangeVillager61

Choonster

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

OrangeVillager61

jeffryfisher

Draco18s

OrangeVillager61

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information