Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.10.2] Underground structure generation problem

Featured Replies

Posted

So i'm trying to spawn a structure underground but the problem is that is too common, despite i give it a really low chance of spawn. This is the code i'm using in the WorldGenerator class

if (world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_MOUNTAINS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_PLAINS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.MUTATED_ICE_FLATS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(MWWorld.arctic)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(MWWorld.iceHills)
				&& random.nextInt(1000) == 1) {
			int randPosX = x + random.nextInt(35);
			int randPosZ = z + random.nextInt(35);
			int randPosY = 30 + random.nextInt(10);
			BlockPos position = new BlockPos(randPosX, randPosY, randPosZ);
			if (!(world.getBlockState(position).getBlock().equals(Blocks.WATER)))
				new WorldGenIceDungeon(position, world);
		}

 

And this is the amount of structures that are generated

T86Du6l.png

As you can see there are too much of this. So how can i spawn the structure with the properly rarity?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Also wrap your booleans.

 

By having them unwrapped it does this:

if (world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_MOUNTAINS)...

"Hmm, is it ice mountains?  Yes, yes it is.  This whole statement evaluates to true."

 

And bypasses your random call.

 

https://en.wikipedia.org/wiki/Order_of_operations#Programming_languages

A || B && C ≡ A || (B && C)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

*facepalm* totally forgot the wrap! And that's why i should never program when i'm sick, that was a really dumb "error" :/ Thanks for pointed it out, now it works :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.