Jump to content

[1.10.2] Underground structure generation problem


JimiIT92

Recommended Posts

So i'm trying to spawn a structure underground but the problem is that is too common, despite i give it a really low chance of spawn. This is the code i'm using in the WorldGenerator class

if (world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_MOUNTAINS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_PLAINS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.MUTATED_ICE_FLATS)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(MWWorld.arctic)
				|| world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(MWWorld.iceHills)
				&& random.nextInt(1000) == 1) {
			int randPosX = x + random.nextInt(35);
			int randPosZ = z + random.nextInt(35);
			int randPosY = 30 + random.nextInt(10);
			BlockPos position = new BlockPos(randPosX, randPosY, randPosZ);
			if (!(world.getBlockState(position).getBlock().equals(Blocks.WATER)))
				new WorldGenIceDungeon(position, world);
		}

 

And this is the amount of structures that are generated

T86Du6l.png

As you can see there are too much of this. So how can i spawn the structure with the properly rarity?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Also wrap your booleans.

 

By having them unwrapped it does this:

if (world.getBiomeGenForCoords(new BlockPos(x, 30, z)).equals(Biomes.ICE_MOUNTAINS)...

"Hmm, is it ice mountains?  Yes, yes it is.  This whole statement evaluates to true."

 

And bypasses your random call.

 

https://en.wikipedia.org/wiki/Order_of_operations#Programming_languages

A || B && C ≡ A || (B && C)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.