Jump to content

Recommended Posts

Posted (edited)

I'm having issues getting my animated model to work properly. When the block is placed, the model animates properly however there is an underlying, non-animating black version of it that is rendering within it. I get no console errors. 

 

The black version has all of the fan-blades rendered instead of alternating from one set to another.

giphy.gif

 

Block Init:

Spoiler

public class OddmentsBlocks {
	
	public static Block kettle;
	public static Block fan;
	public static Block flatscreen_tv;
	public static Block floor_lamp_off;
	public static Block hot_tub_empty;
	public static Block led_ceiling_light_off;
	
	public static void init() {
		kettle = new BlockKettle(Material.iron).setUnlocalizedName("kettle");
		fan = new BlockFan(Material.rock).setUnlocalizedName("fan");
		flatscreen_tv = new BlockFlatscreenTV(Material.iron).setUnlocalizedName("flatscreen_tv");
		floor_lamp_off = new BlockFloorLamp(Material.cloth).setUnlocalizedName("floor_lamp_off");
		hot_tub_empty = new BlockHotTub(Material.wood).setUnlocalizedName("hot_tub_empty");
		led_ceiling_light_off = new BlockLED(Material.glass).setUnlocalizedName("led_ceiling_light_off");
	}
	
	public static void registerBlocks() {
		GameRegistry.registerBlock(kettle, kettle.getUnlocalizedName().substring(5));
		GameRegistry.registerBlock(fan, fan.getUnlocalizedName().substring(5));
		GameRegistry.registerBlock(flatscreen_tv, flatscreen_tv.getUnlocalizedName().substring(5));
		GameRegistry.registerBlock(floor_lamp_off, floor_lamp_off.getUnlocalizedName().substring(5));
		GameRegistry.registerBlock(hot_tub_empty, hot_tub_empty.getUnlocalizedName().substring(5));
		GameRegistry.registerBlock(led_ceiling_light_off, led_ceiling_light_off.getUnlocalizedName().substring(5));
	}
	
	public static void registerRenders() {
		registerRender(kettle);
		registerRender(fan);
		registerRender(flatscreen_tv);
		registerRender(floor_lamp_off);
		registerRender(hot_tub_empty);
		registerRender(led_ceiling_light_off);
	}
	
	public static void registerRender(Block block) {
		Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(Item.getItemFromBlock(block), 0, new ModelResourceLocation(Reference.MOD_ID + ":" + block.getUnlocalizedName().substring(5), "inventory"));
	}
}

 

Fan Class:

Spoiler

public class BlockFan extends Block {
	
	public static final PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);
	public static final PropertyBool ON = PropertyBool.create("on");
	private IBlockState actualState;
	
	public BlockFan(Material materialIn) {
		super(materialIn);
		this.setCreativeTab(OddmentsMod.tabOddments);
		this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH).withProperty(ON, false));
	}
	
	@Override
	public boolean isOpaqueCube() {
		return false;
	}
	
	@Override
	public boolean isFullCube() {
		return false;
	}
	
	public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer) {
        return this.getDefaultState().withProperty(FACING, placer.getHorizontalFacing());
    }
	
	protected BlockState createBlockState() {
        return new BlockState(this, new IProperty[] {FACING, ON});
    }
	
	public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
    }
	
	public int getMetaFromState(IBlockState state) {
        return ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();
    } 
	
	@Override
	public IBlockState getActualState(IBlockState state, IBlockAccess world, BlockPos pos) { 
		actualState = state.withProperty(ON, true);
		return actualState;
	}
	
	public void addCollisionBoxesToList(World worldIn, BlockPos pos, IBlockState state, AxisAlignedBB mask, List<AxisAlignedBB> list, Entity collidingEntity)
    {
        this.setBlockBounds(0.3F, 0.25F, 0.2F, 0.7F, 0.875F, 0.75F);
        super.addCollisionBoxesToList(worldIn, pos, state, mask, list, collidingEntity);
        this.setBlockBounds(0.125F, 0.0F, 0.125F, 0.8675F, 0.25F, 0.87F);
        super.addCollisionBoxesToList(worldIn, pos, state, mask, list, collidingEntity);
    }
	
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ) {
		getActualState(state, worldIn, pos);
		return true;
    }
}

 

Fan Blockstate:

Spoiler

{
    "variants": {
        "facing=north,on=false": {"model": "odm:fan"},
        "facing=south,on=false": { "model": "odm:fan", "y": 180 },
        "facing=west,on=false": { "model": "odm:fan", "y": 270 },
        "facing=east,on=false": { "model": "odm:fan", "y": 90 },
        "facing=north,on=true": { "model": "odm:fan_on" },
        "facing=south,on=true": { "model": "odm:fan_on", "y": 180 },
        "facing=west,on=true":  { "model": "odm:fan_on", "y": 270 },
        "facing=east,on=true":  { "model": "odm:fan_on", "y": 90 }   
    }
}

 

 

Edited by Branone
Posted

Update:

After thinking about it, the problem could be to do with the fact that I am only using one blockstate which switches between an animated and non-animated model. Am I allowed to do this, or is that the problem?

Posted (edited)

By default, transparent pixels in textures are rendered black if the opacity is 0%. Otherwise all other pixels are set to 100% opacity. Assuming using 1.11.2, this code will resolve your problem.

public BlockRenderLayer getBlockLayer()
{
    return BlockRenderLayer.CUTOUT;
}

Edit: Goes in your block class

Edited by mr_crayfish
  • Like 1
Posted (edited)
22 minutes ago, mr_crayfish said:

By default, transparent pixels in textures are rendered black if the opacity is 0%. Otherwise all other pixels are set to 100% opacity. Assuming using 1.11.2, this code will resolve your problem.


public BlockRenderLayer getBlockLayer()
{
    return BlockRenderLayer.CUTOUT;
}

Edit: Goes in your block class

Thank you so much! I've been looking for an answer for quite some time now, and of all the people I get help from - MrCrayFish himself, the very person I have been watching tutorials of and have received so much inspiration from (assuming you aren't an imposter). 

Edited by Branone

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Im trying to build my mod using shade since i use the luaj library however i keep getting this error Reason: Task ':reobfJar' uses this output of task ':shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. So i try adding reobfJar.dependsOn shadowJar  Could not get unknown property 'reobfJar' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. my gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'com.github.johnrengelman.shadow' version '7.1.2' id 'org.spongepowered.mixin' version '0.7.+' } apply plugin: 'net.minecraftforge.gradle' apply plugin: 'org.spongepowered.mixin' apply plugin: 'com.github.johnrengelman.shadow' version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) //jarJar.enable() println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: mapping_channel, version: mapping_version copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' arg "-mixin.config=derp.mixin.json" mods { "${mod_id}" { source sourceSets.main } } } client { // Comma-separated list of namespaces to load gametests from. Empty = all namespaces. property 'forge.enabledGameTestNamespaces', mod_id } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { workingDirectory project.file('run-data') args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { flatDir { dirs './libs' } maven { url = "https://jitpack.io" } } configurations { shade implementation.extendsFrom shade } dependencies { minecraft "net.minecraftforge:forge:${minecraft_version}-${forge_version}" implementation 'org.luaj:luaj-jse-3.0.2' implementation fg.deobf("com.github.Virtuoel:Pehkui:${pehkui_version}") annotationProcessor 'org.spongepowered:mixin:0.8.5:processor' minecraftLibrary 'luaj:luaj-jse:3.0.2' shade 'luaj:luaj-jse:3.0.2' } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"), "TweakClass" : "org.spongepowered.asm.launch.MixinTweaker", "TweakOrder" : 0, "MixinConfigs" : "derp.mixin.json" ]) } rename 'mixin.refmap.json', 'derp.mixin-refmap.json' } shadowJar { archiveClassifier = '' configurations = [project.configurations.shade] finalizedBy 'reobfShadowJar' } assemble.dependsOn shadowJar reobf { re shadowJar {} } publishing { publications { mavenJava(MavenPublication) { artifact jar } } repositories { maven { url "file://${project.projectDir}/mcmodsrepo" } } }  
    • All versions of Minecraft Forge suddenly black screen even without mods (tried reinstalling original Minecraft, Java, updating drivers doesn't work)
    • When i join minecraft all ok, when i join world all working fine, but when i open indentity menu, i get this The game crashed whilst unexpected error Error: java.lang.NullPointerException: Cannot invoke "top.ribs.scguns.common.Gun$Projectile.getDamage()" because "this.projectile" is null crash report here https://paste.ee/p/0vKaf
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.