Jump to content

Recommended Posts

Posted

Context:

I have a 'pillar' sort of block.

The player can right click it with an item/block and the item will placed for display on top of the block.

The player can then remove the item by right clicking again with an empty hand.

This works almost exactly like the jukebox only with the additional rendering of EntityItem on top of the block.

 

The problem:

Two or more Pillar blocks do not uniquely hold items.

An item can be placed on the first pillar...

once an item is placed on the second pillar, the first item is deleted (it stays rendered, but cannot be recovered) and the second item becomes the only one in existence. This continues for each additional pillar.

I have tried everything to fix this issue and can not seem to figure it out.

 

The tile entity is properly registered in the Common Proxy.

 

The Block:

public class ArcanePillarBlock extends BlockContainer {
    public static final PropertyBool HAS_DISPLAY = PropertyBool.create("has_display");

    public ArcanePillarBlock(String unlocalizedName, Material material, float hardness, float resistance) {
        super(material);
        this.setDefaultState(this.blockState.getBaseState().withProperty(HAS_DISPLAY, Boolean.valueOf(false)));
        this.setCreativeTab(Ref.CTAB);
        this.setUnlocalizedName(unlocalizedName);
        this.setRegistryName(unlocalizedName);
        this.setHardness(hardness);
        this.setResistance(resistance);
    }

    @Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
        if (state.getValue(HAS_DISPLAY).booleanValue()) {
            dropRecord(worldIn, pos, state, playerIn.getPosition());
        } else if (heldItem != null) {
            insertRecord(worldIn, pos, state, heldItem);
            if (!playerIn.capabilities.isCreativeMode) {
                heldItem.stackSize--;
            }
        }
        return true;
    }

    public void insertRecord(World worldIn, BlockPos pos, IBlockState state, ItemStack heldItem) {
        if (!worldIn.isRemote) {
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof ArcanePillarTileEntity) {
                ArcanePillarTileEntity arcaneTileEntity = (ArcanePillarTileEntity) tileentity;
                worldIn.setBlockState(pos, state.withProperty(HAS_DISPLAY, Boolean.valueOf(true)), 2);
                arcaneTileEntity.setDisplay(heldItem.copy());
            }
        }
    }

    private void dropRecord(World worldIn, BlockPos pos, IBlockState state, BlockPos spawnPos) {
        if (!worldIn.isRemote) {
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof ArcanePillarTileEntity) {
                ArcanePillarTileEntity arcaneTileEntity = (ArcanePillarTileEntity) tileentity;
                ItemStack itemstack = arcaneTileEntity.getDisplay();

                if (itemstack != null) {
                    arcaneTileEntity.setDisplay((ItemStack) null);
                    arcaneTileEntity.endDisplay();
                    ItemStack itemstack1 = itemstack.copy();
                    itemstack1.stackSize = 1;
                    EntityItem entityitem = new EntityItem(worldIn, spawnPos.getX(), spawnPos.getY(), spawnPos.getZ(), itemstack1);
                    entityitem.setDefaultPickupDelay();
                    worldIn.setBlockState(pos, state.withProperty(HAS_DISPLAY, Boolean.valueOf(false)), 2);
                    worldIn.spawnEntityInWorld(entityitem);
                }
            }
        }
    }

    @Override
    public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
        dropRecord(worldIn, pos, state, pos);
        super.breakBlock(worldIn, pos, state);
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(HAS_DISPLAY, Boolean.valueOf(meta > 0));
    }

    @Override
    public int getMetaFromState(IBlockState state) {
        return ((Boolean) state.getValue(HAS_DISPLAY)).booleanValue() ? 1 : 0;
    }

    @Override
    protected BlockStateContainer createBlockState() {
        return new BlockStateContainer(this, new IProperty[]{HAS_DISPLAY});
    }

    @Override
    public TileEntity createNewTileEntity(World worldIn, int meta) {
        return new ArcanePillarTileEntity();
    }

    @Override
    public EnumBlockRenderType getRenderType(IBlockState state) {
        return EnumBlockRenderType.MODEL;
    }

    @Override
    public boolean isOpaqueCube(IBlockState state) {
        return false;
    }

    @Override
    public boolean isFullCube(IBlockState state) {
        return false;
    }

    @Override
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer() {
        return BlockRenderLayer.TRANSLUCENT;
    }

    @Override
    @SideOnly(Side.CLIENT)
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
        return true;
    }

The Tile Entity:

public class ArcanePillarTileEntity extends TileEntity {
    private static ItemStack displayItem;
    private static EntityItem displayEntity;

    public void readFromNBT(NBTTagCompound compound) {
        super.readFromNBT(compound);

        if (compound.hasKey("DisplayItem", 10)) {
            this.setDisplay(ItemStack.loadItemStackFromNBT(compound.getCompoundTag("DisplayItem")));
        } else if (compound.getInteger("DisplayItem") > 0) {
            this.setDisplay(new ItemStack(Item.getItemById(compound.getInteger("Item"))));
        }
    }

    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        super.writeToNBT(compound);

        if (getDisplay() != null) {
            compound.setTag("DisplayItem", getDisplay().writeToNBT(new NBTTagCompound()));
        }

        return compound;
    }

    @Nullable
    public ItemStack getDisplay() {
        System.out.println(this);
        return this.displayItem;
    }

    public void setDisplay(@Nullable ItemStack itemStack) {
        this.displayItem = itemStack;
        if (itemStack != null) {
            ItemStack tempStack = new ItemStack(this.displayItem.getItem(), 1);
            this.displayEntity = new EntityItem(worldObj, pos.getX() + .5, pos.getY() + 1, pos.getZ() + .5, tempStack);
            this.displayEntity.setInfinitePickupDelay();
            this.displayEntity.setNoDespawn();
            this.displayEntity.setVelocity(0D, 0D, 0D);
            if (!worldObj.isRemote) {
                worldObj.spawnEntityInWorld(displayEntity);
            }
        }
        this.markDirty();
    }

    public void endDisplay() {
        this.displayEntity.setDead();
        this.displayItem = null;
        this.markDirty();
    }
}

Does anyone know of either a solution to my issue or possibly a better way to make an item display block?

Thanks for any help you can offer!

My GitHub with the rest of my code.

Posted (edited)

Your ItemStack variables in your TileEntity are static, which means they are shared between every instance of the TileEntity.

Edited by larsgerrits

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted
  On 2/10/2017 at 6:43 PM, TheSunCat said:

Welcome to the forums! Mr. Crayfish's Furniture Mod does something similar with the table, and another block whose name I forgot... Deobfuscate his code and take a look.

Expand  

Do you know the name of the block?

Posted
  On 2/10/2017 at 6:45 PM, cj3636 said:

The pillar does not work at all when the variables are not set to static.

Expand  

Then you're doing something wrong.  Mine isn't static.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Verified users can now unlock a $100 OFF Temu Coupon Code using the verified promo code [ALF401700]. This Temu $100 OFF code works for both new and existing customers and can be used to redeem up to 50% off your next order. Our exclusive Temu coupon code [ALF401700] delivers a flat $100 OFF on top of existing deals. First-time customers using code ALF401700 can save an extra 100% off select items. Returning users also qualify for an automatic $100 OFF discount just by applying this code at checkout. But wait—there’s more. With our Temu coupon codes for 2025, users can score up to 90% OFF on clearance items. Whether you’re shopping in the USA, Canada, UK, or elsewhere, Temu promo code ALF401700 unlocks extra discounts tailored to your account. Some users are saving 100% on items using this 2025 Temu promo code. 🔥 Temu Coupon Highlights Using Code [ALF401700]: Temu new user code – ALF401700: Save 50% off your first order + $100 OFF. Temu promo for existing customers – ALF401700: Enjoy flat $100 OFF instantly. Global availability: Works in the USA, UK, Canada, Germany, France, Japan, Chile, Colombia, Malaysia, Mexico, South Korea, Philippines, Saudi Arabia, Qatar, Pakistan, and more. Top 2025 Coupon Deal: Get $200 OFF plus 100% bonus discounts using code ALF401700. Top-Ranked Temu Deals for 2025 (Coupon Code: ALF401700): ✅ Temu $100 OFF Memorial Day Sale — Use ALF401700 ✅ Temu First Order Coupon — Use ALF401700 for 50% + $100 OFF ✅ Temu USA Coupon Code — Save $100 instantly with ALF401700 ✅ Temu Japan, Germany, Chile Codes — All support ALF401700 ✅ Temu Reddit Discount – $100 OFF: Valid for both new and old users ✅ Temu Coupon Bundle 2025 — $100 OFF + up to 50% slash ✅ 100% OFF Free Gift Code — Use ALF401700, no invite needed ✅ Temu Sign-Up Bonus Promo — Get a welcome $100 OFF instantly ✅ Free Temu Code for New Users — Use ALF401700, no referral required  Temu Clearance Codes 2025 — Use ALF401700 for 85–100% discounts Why ALF401700 is the Best Temu Code in 2025 Using Temu code ALF401700 is your ticket to massive savings, free shipping, first-order discounts, and stackable coupon bundles. Whether you're browsing electronics, fashion, home goods, or beauty products, this verified Temu discount code offers real savings—up to 90% OFF + $100 OFF on qualified orders. 💡 Pro Tip: Apply ALF401700 during checkout in the Temu app or website to activate your instant $100 discount, even if you’re not a new user. Temu $100 OFF Code by Country (All Use ALF401700): 🇺🇸 Temu USA – ALF401700 🇯🇵 Temu Japan – ALF401700 🇲🇽 Temu Mexico – ALF401700 🇨🇱 Temu Chile – ALF401700 🇨🇴 Temu Colombia – ALF401700 🇲🇾 Temu Malaysia – ALF401700 🇵🇭 Temu Philippines – ALF401700 🇰🇷 Temu Korea – ALF401700 🇵🇰 Temu Pakistan – ALF401700 🇫🇮 Temu Finland – ALF401700 🇸🇦 Temu Saudi Arabia – ALF401700 🇶🇦 Temu Qatar – ALF401700 🇫🇷 Temu France – ALF401700 🇩🇪 Temu Germany – ALF401700 🇮🇱 Temu Israel – ALF401700 Temu Coupon Code [ALF401700] Summary for SEO: Temu $100 OFF Code  Temu First Order Discount Code 2025  Temu Verified Promo Code ALF401700  Temu 50% OFF + $100 Bonus  Temu 100% OFF Code 2025  Temu App Promo ALF401700  Temu Working Discount Code 2025 
    • Hey there, nothing to do with the code, I am just suggesting you use Intelij IDEA. Trust me, it is the best.
    • Hey there, nothing to do with the code, I am just suggesting you use Intelij IDEA. Trust me, it is the best.
    • You can check the config of Geckolib and Mowzie's Mobs - maybe there is a way to disable some render features
    • You can use the .requires() function  the server also has a permission level of 4, which is the highest permission level.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.