Search the Forums BEFORE making a new post.

ConcurrentModificationException

Posted February 18, 20178 yr

	public void playerTick(PlayerTickEvent event)
	{
		List<Entity> entities = event.player.getEntityWorld().getEntitiesWithinAABBExcludingEntity(event.player, event.player.getEntityBoundingBox().expand(1.0D, 1.0D, 1.0D));
		for(Entity entity : entities){
			if((entity instanceof EntityMob && ((EntityLivingBase) entity).getHeldItemMainhand() != null && !previousmobs.contains(entity))){
				event.player.addChatMessage(((EntityLivingBase) entity).getHeldItemMainhand().getTextComponent());
				previousmobs.add((EntityMob) entity);
			}
		}
		
		if(!previousmobs.isEmpty()){
		for(Entity e : previousmobs){
			if(e.isDead){
				previousmobs.remove(e);
				}
			}
		}

ConcurrentModificationException: (I am assuming that means that at the same time it is removing it from the list it is also checking if its on the list causing it to crash)

The game crashes right after I kill a mob and the body drops.

Stacktrace:

java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(Unknown Source) ~[?:1.8.0_65]
	at java.util.ArrayList$Itr.next(Unknown Source) ~[?:1.8.0_65]
	at com.vivabenfica4ps3.gmail.DungeonRealmsMod.playerTick(DungeonRealmsMod.java:74) ~[DungeonRealmsMod.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_DungeonRealmsMod_playerTick_PlayerTickEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) [EventBus.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:360) [FMLCommonHandler.class:?]
	at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:215) [EntityPlayer.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:341) [EntityPlayerMP.class:?]
	at net.minecraft.network.NetHandlerPlayServer.update(NetHandlerPlayServer.java:174) [NetHandlerPlayServer.class:?]
	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.update(NetworkDispatcher.java:216) [NetworkDispatcher$1.class:?]
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:308) [NetworkManager.class:?]
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:195) [NetworkSystem.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:806) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_65]
[13:01:22] [Server thread/ERROR] [FML]: Index: 1 Listeners:
[13:01:22] [Server thread/ERROR] [FML]: 0: NORMAL
[13:01:22] [Server thread/ERROR] [FML]: 1: ASM: com.vivabenfica4ps3.gmail.DungeonRealmsMod@158774d3 playerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent;)V
[13:01:22] [Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.util.ReportedException: Ticking player
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:210) ~[NetworkSystem.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:806) ~[MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) ~[MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) ~[IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_65]
Caused by: java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(Unknown Source) ~[?:1.8.0_65]
	at java.util.ArrayList$Itr.next(Unknown Source) ~[?:1.8.0_65]
	at com.vivabenfica4ps3.gmail.DungeonRealmsMod.playerTick(DungeonRealmsMod.java:74) ~[DungeonRealmsMod.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_DungeonRealmsMod_playerTick_PlayerTickEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:360) ~[FMLCommonHandler.class:?]
	at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:215) ~[EntityPlayer.class:?]
	at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:341) ~[EntityPlayerMP.class:?]
	at net.minecraft.network.NetHandlerPlayServer.update(NetHandlerPlayServer.java:174) ~[NetHandlerPlayServer.class:?]
	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.update(NetworkDispatcher.java:216) ~[NetworkDispatcher$1.class:?]
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:308) ~[NetworkManager.class:?]
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:195) ~[NetworkSystem.class:?]
	... 5 more
[13:01:22] [Server thread/ERROR]: This crash report has been saved to: D:\DRMod\run\.\crash-reports\crash-2017-02-18_13.01.22-server.txt
[13:01:22] [Server thread/INFO]: Stopping server
[13:01:22] [Server thread/INFO]: Saving players
[13:01:22] [Server thread/INFO]: Saving worlds
[13:01:22] [Server thread/INFO]: Saving chunks for level 'New World'/Overworld
[13:01:22] [Client thread/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:649]: ---- Minecraft Crash Report ----
// You're mean.

Time: 2/18/17 1:01 PM
Description: Ticking player

java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
	at java.util.ArrayList$Itr.next(Unknown Source)
	at com.vivabenfica4ps3.gmail.DungeonRealmsMod.playerTick(DungeonRealmsMod.java:74)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_DungeonRealmsMod_playerTick_PlayerTickEvent.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185)
	at net.minecraftforge.fml.common.FMLCommonHandler.onPlayerPreTick(FMLCommonHandler.java:360)
	at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:215)
	at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:341)
	at net.minecraft.network.NetHandlerPlayServer.update(NetHandlerPlayServer.java:174)
	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.update(NetworkDispatcher.java:216)
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:308)
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:195)
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:806)
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536)
	at java.lang.Thread.run(Unknown Source)

Does anyone know how to fix this?

Quote

February 18, 20178 yr

Author

Oh yeah. I forgot about the iterator method

Quote

February 18, 20178 yr

Author

Got it: Solved

I dont know how I forgot such a basic rule of java. Whenever iterating through a List always use an Iterator.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/50755-concurrentmodificationexception/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 4 hours ago4 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 10 hours ago10 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 18 hours ago18 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 22 hours ago22 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

TileEntity

Sign In

ConcurrentModificationException

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)