[1.11.2] Capability not working right

[Kokkie]

Hello, I am working on a money system but it doesn't work right, I have a block, the bank, which has a gui and all that works fine, until I try to buy a gold ingot, it keeps telling me I don't have enough money even though I surely have because I just sold a gold ingot... So obviously there is something wrong with the GUI, packet or capability... Here's my code:

Gui:

public class CheeseBankGui extends GuiScreen {
	private GuiButtonBank COIN_SELL;
	private GuiButtonBank GOLD_SELL;
	private GuiButtonBank COIN_BUY;
	private GuiButtonBank GOLD_BUY;

	@Override
	public void initGui() {
		buttonList.add(new GuiButtonExt(1, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
				"Welcome in the " + TextFormatting.YELLOW + "Cheese Bank" + TextFormatting.RESET));
		COIN_SELL = new GuiButtonBank(2, this.width / 2 - 30, this.height / 2 - 30, 0);
		GOLD_SELL = new GuiButtonBank(3, this.width / 2 + 10, this.height / 2 - 30, 1);
		COIN_BUY = new GuiButtonBank(4, this.width / 2 - 30, this.height / 2 + 10, 2);
		GOLD_BUY = new GuiButtonBank(5, this.width / 2 + 10, this.height / 2 + 10, 3);
	}

	@Override
	protected void actionPerformed(GuiButton button) throws IOException {
		buttonList.removeAll(buttonList);
		switch (button.id) {
		case 1:
			buttonList.add(COIN_SELL);
			buttonList.add(GOLD_SELL);
			buttonList.add(COIN_BUY);
			buttonList.add(GOLD_BUY);
			break;
		case 2:
			boolean containsCheese = false;
			for (int i = 0; i < this.mc.player.inventory.getSizeInventory(); i++) {
				Item item = this.mc.player.inventory.getStackInSlot(i).getItem();
				if (item == CheeseItems.CHEESE_MONEY) {
					containsCheese = true;
				}
			}
			if (containsCheese) {
				CheesePacketHandler.INSTANCE.sendToServer(new CheeseBankMessage(10));
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Succesfully added " + 10 + " C-coins"));
			} else {
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Not enough cheese"));
			}
			break;
		case 3:
			boolean containsGold = false;
			for (int i = 0; i < this.mc.player.inventory.getSizeInventory(); i++) {
				Item item = this.mc.player.inventory.getStackInSlot(i).getItem();
				if (item == Items.GOLD_INGOT) {
					containsGold = true;
				}
			}
			if (containsGold) {
				CheesePacketHandler.INSTANCE.sendToServer(new CheeseBankMessage(50));
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Succesfully added " + 50 + " C-coins"));
			} else {
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Not enough gold"));
			}
			break;
		case 4:
			boolean moneyCheese = false;
			IMoney moneyCapCheese = this.mc.player.getCapability(MoneyProvider.MONEY_CAP, null);
			if (moneyCapCheese.get() >= 10) {
				moneyCheese = true;
			} else {
				moneyCheese = false;
			}
			if (moneyCheese) {
				CheesePacketHandler.INSTANCE.sendToServer(new CheeseBankMessage(-10));
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Succesfully bought a cheese coin"));
			} else {
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Not enough money"));
			}
			break;
		case 5:
			boolean moneyGold = false;
			IMoney moneyCapGold = this.mc.player.getCapability(MoneyProvider.MONEY_CAP, null);
			if (moneyCapGold.get() >= 50) {
				moneyGold = true;
			} else {
				moneyGold = false;
			}
			if (moneyGold) {
				CheesePacketHandler.INSTANCE.sendToServer(new CheeseBankMessage(-50));
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Succesfully bought gold"));
			} else {
				buttonList.add(new GuiButtonExt(6, this.width / 2 - 100, this.height / 2 - 10, 200, 20,
						"Not enough money"));
			}
			break;
		case 6:
			this.mc.displayGuiScreen((GuiScreen) null);
			break;
		}
	}

	@Override
	public boolean doesGuiPauseGame() {
		return false;
	}
}

Gui button:

public class GuiButtonBank extends GuiButton {
	private final ResourceLocation BANK_BUTTON_TEXTURE = new ResourceLocation(
			Reference.MODID + ":textures/gui/bank_button.png");
	private int textureOffsetX;

	public GuiButtonBank(int buttonID, int xPos, int yPos, int type) {
		super(buttonID, xPos, yPos, 20, 20, "");
		if (type == 0 || type == 2) {
			this.textureOffsetX = 0;
		} else if (type == 1 || type == 3) {
			this.textureOffsetX = 20;
		}
	}

	public void drawButton(Minecraft mc, int mouseX, int mouseY) {
		if (this.visible) {
			mc.getTextureManager().bindTexture(BANK_BUTTON_TEXTURE);
			GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
			boolean flag = mouseX >= this.xPosition && mouseY >= this.yPosition && mouseX < this.xPosition + this.width
					&& mouseY < this.yPosition + this.height;
			int i = 0;

			if (flag) {
				i += this.height;
			}

			this.drawModalRectWithCustomSizedTexture(this.xPosition, this.yPosition, textureOffsetX, i, this.width, this.height, 40, 40);
		}
	}
}

The packet:

public class CheeseBankMessage implements IMessage {

	public CheeseBankMessage() {
	}

	private int value;

	public CheeseBankMessage(int value) {
		this.value = value;
	}

	@Override
	public void toBytes(ByteBuf buf) {
		buf.writeInt(value);
	}

	@Override
	public void fromBytes(ByteBuf buf) {
		value = buf.readInt();
	}

	public int getValue() {
		return value;
	}
}

The packet handler:

public class CheeseBankMessageHandler implements IMessageHandler<CheeseBankMessage, IMessage> {
	@Override
	public IMessage onMessage(final CheeseBankMessage message, final MessageContext ctx) {
		final EntityPlayerMP player = ctx.getServerHandler().playerEntity;
		IThreadListener mainThread = (WorldServer) player.world;
		mainThread.addScheduledTask(new Runnable() {
			@Override
			public void run() {
				IMoney money = player.getCapability(MoneyProvider.MONEY_CAP, null);
				if (message.getValue() == 10) {
					player.inventory.clearMatchingItems(CheeseItems.CHEESE_MONEY, -1, 1, null);
					money.add(message.getValue());
				} else if (message.getValue() == 50) {
					player.inventory.clearMatchingItems(Items.GOLD_INGOT, -1, 1, null);
					money.add(message.getValue());
				} else if (message.getValue() == -10) {
					player.world.spawnEntity(new EntityItem(player.world, player.posX, player.posY, player.posZ, new ItemStack(CheeseItems.CHEESE_MONEY, 1)));
					money.remove(10);
				} else if (message.getValue() == -50) {
					player.world.spawnEntity(new EntityItem(player.world, player.posX, player.posY, player.posZ, new ItemStack(Items.GOLD_INGOT, 1)));
					money.remove(50);
				}
			}
		});
		return null;
	}
}

Capability interface:

public interface IMoney {

	public void set(int set);
	public void add(int add);
	public void remove(int remove);
	
	public int get();

}

Capability:

public class Money implements IMoney {
	
	private int money = 20;

	@Override
	public void set(int set) {
		money = set;
		if(money < 0) money = 0;
	}

	@Override
	public void add(int add) {
		money += add;
		if(money < 0) money = 0;
	}

	@Override
	public void remove(int remove) {
		money -= remove;
		if(money < 0) money = 0;
	}

	@Override
	public int get() {
		return money;
	}

}

Capability storage:

public class MoneyStorage implements IStorage<IMoney> {

	@Override
	public NBTBase writeNBT(Capability<IMoney> capability, IMoney instance, EnumFacing side) {
		NBTTagInt comp = new NBTTagInt(instance.get());
		return comp;
	}

	@Override
	public void readNBT(Capability<IMoney> capability, IMoney instance, EnumFacing side, NBTBase nbt) {
		NBTTagInt comp = (NBTTagInt) nbt;
		instance.set(comp.getInt());
	}

}

And capability provider:

public class MoneyProvider implements ICapabilitySerializable<NBTBase> {
	
	@CapabilityInject(IMoney.class)
	public static final Capability<IMoney> MONEY_CAP = null;
	
	private IMoney instance = MONEY_CAP.getDefaultInstance();

	@Override
	public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
		return capability == MONEY_CAP;
	}

	@Override
	public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
		return capability == MONEY_CAP ? MONEY_CAP.<T> cast(this.instance) : null;
	}

	@Override
	public NBTBase serializeNBT() {
		return MONEY_CAP.getStorage().writeNBT(MONEY_CAP, instance, null);
	}

	@Override
	public void deserializeNBT(NBTBase nbt) {
		MONEY_CAP.getStorage().readNBT(MONEY_CAP, instance, null, nbt);
	}

}

 

[Choonster]

I can't see any obvious issues from a quick skim of your code, so I suggest you set some breakpoints and step through the code in the debugger to figure out exactly what's happening and where and why it's failing.

[Kokkie]

For all the code go to my github, idk why I didn't send you there immediately but..

[Kokkie]

bump

[Choonster]

Did you try using the debugger?

[Kokkie]

Turned up nothing

[Kokkie]

bumo

[Animefan8888]

Do you ever sync the money after changing it?

[Kokkie]

No..? How should I do that?

[Animefan8888]

Packets, or Container#detectAndSendChanges

[Kokkie]

Oh that, well I send a packet to the server so yes I do... But I don't change it on the client, should I?

[Animefan8888]

  On 2/25/2017 at 9:50 PM, Kokkie said:

Oh that, well I send a packet to the server so yes I do... But I don't change it on the client, should I?

Expand  

Guis are on the client so if the data doesn't update on the client and you use the data in an if statement then yes.

[Kokkie]

Thanks, it works!