FIXED OreGenerating, no ore?

[clowcadia]

I am back, so i made an ore generator handler and i still cant find my ores

OreGenHandler

package com.clowcadia.tutorial.world;

import java.util.Random;

import com.clowcadia.tutorial.handlers.BlockHandler;
import com.google.common.base.Predicate;

import net.minecraft.block.state.IBlockState;
import net.minecraft.block.state.pattern.BlockMatcher;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;

public class WorldGenOre implements IWorldGenerator{

	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) 
	{
		  switch(world.provider.getDimension())
		  {
		  
		  }
	}
	
	private void genSurface(World world, Random random, int chunkX, int chunkZ)
	{
		 addOreSpawn(BlockHandler.blockTutorial.getDefaultState(), world, random, chunkX, chunkZ, 16, 16, 100, 20, 74, 126, BlockMatcher.forBlock(Blocks.STONE));
	}
	
	private void addOreSpawn(IBlockState block, World world, Random random, int blockXPos, int blockZPos, int maxX, int maxZ, int maxVeinSize, int chance, int minY, int maxY, Predicate<IBlockState> blockToSpawnIn)
	{
		int diffMinMaxY = maxY - minY;
		for(int x = 0; x < chance; x++)
		{
		   int posX = blockXPos + random.nextInt(maxX);
		   int posY = minY + random.nextInt(diffMinMaxY);
		   int posZ = blockZPos + random.nextInt(maxZ);
		   (new WorldGenMinable(block, maxVeinSize, blockToSpawnIn)).generate(world, random, new BlockPos(posX, posY, posZ));
		}
	}

}

ClientProxy

package com.clowcadia.tutorial.proxy;

import com.clowcadia.tutorial.handlers.BlockHandler;
import com.clowcadia.tutorial.handlers.ItemHandler;
import com.clowcadia.tutorial.world.WorldGenOre;

import net.minecraftforge.fml.common.registry.GameRegistry;

//Class to put Tile Entities
public class ClientProxy extends CommonProxy
{
	public void init() 
	{
		ItemHandler.registerRenders();
		BlockHandler.registerRenders();
		GameRegistry.registerWorldGenerator(new WorldGenOre(), 0);
	}

}

 

Edited February 20, 2017 by clowcadia

[clowcadia]

i missed something but it had no immpact

 

package com.clowcadia.tutorial.world;

import java.util.Random;

import com.clowcadia.tutorial.handlers.BlockHandler;
import com.google.common.base.Predicate;

import net.minecraft.block.state.IBlockState;
import net.minecraft.block.state.pattern.BlockMatcher;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;

public class WorldGenOre implements IWorldGenerator{

	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) 
	{
		  switch(world.provider.getDimension())
		  {
		  case -1: genSurface(world, random, chunkX, chunkZ);
		  	break;
		  case 0: genSurface(world, random, chunkX, chunkZ);
		  	break;
		  case 1: genSurface(world, random, chunkX, chunkZ);
		  	break;
		  default: genSurface(world, random, chunkX, chunkZ);
		  	break;
		  }
	}
	
	private void genSurface(World world, Random random, int chunkX, int chunkZ)
	{
		 addOreSpawn(BlockHandler.blockTutorial.getDefaultState(), world, random, chunkX, chunkZ, 16, 16, 100, 20, 74, 126, BlockMatcher.forBlock(Blocks.STONE));
	}
	
	private void addOreSpawn(IBlockState block, World world, Random random, int blockXPos, int blockZPos, int maxX, int maxZ, int maxVeinSize, int chance, int minY, int maxY, Predicate<IBlockState> blockToSpawnIn)
	{
		int diffMinMaxY = maxY - minY;
		for(int x = 0; x < chance; x++)
		{
		   int posX = blockXPos + random.nextInt(maxX);
		   int posY = minY + random.nextInt(diffMinMaxY);
		   int posZ = blockZPos + random.nextInt(maxZ);
		   (new WorldGenMinable(block, maxVeinSize, blockToSpawnIn)).generate(world, random, new BlockPos(posX, posY, posZ));
		}
	}

}

 

[Lhykos]

You have to register your WorldGenerator on the Server Side, in the "CommonProxy". Not on the Client side.

[clowcadia]

1 minute ago, Lhykos said:

You have to register your WorldGenerator on the Server Side, in the "CommonProxy". Not on the Client side.

@PotatoGaming

[clowcadia]

Still nothing

[Lhykos]

Hmm. One thing I see is you have to multiply your chunkX and chunkZ with 16, because these define the chunk coordinates, not the ones of the blocks.

[clowcadia]

That was the solution actually

[clowcadia]

Awsome thank you

[clowcadia]

1 minute ago, TheSunCat said:

By the way, you can check if something is generating easily if you do a System.out.println(pos.getX() + " " + pos.getY() + " " + pos.getZ()); That is how I check if my ores and generated structures spawn...

Your very kind, but for the sake of the post and others who may have similar issues. Where would you plug that in?

[Lhykos]

5 minutes ago, TheSunCat said:

By the way, you can check if something is generating easily if you do a System.out.println(pos.getX() + " " + pos.getY() + " " + pos.getZ()); That is how I check if my ores and generated structures spawn...

That's a neat way to check that. I will do this in the future too.

[clowcadia]

Just glanced at your signature^^ once ive done with armor tutorial, i shall take a look. Glad to meet an interactive tutorial maker^^

May I ask if you have any ready made modes I can admire?

[Draco18s]

Or use the logger that Forge gives you during the event lifecycle....